New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 702584 link

Starred by 1 user
Status: Duplicate
Merged: issue 703657
Owner: ----
Closed: Mar 2017
Cc:
jam@chromium.org
clamy@chromium.org
█ nasko@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 703657



Sign in to add a comment

SecurityExploitBrowserTest.AttemptDuplicateRenderWidgetHost is failing on Android when PlzNavigate is enabled

Project Member Reported by clamy@chromium.org, Mar 17 2017 
SecurityExploitBrowserTest.AttemptDuplicateRenderWidgetHost is failing flakely on Marshmallow 64 bit Tester when Plznavigate is enabled. We're hitting a DCHECK:

[FATAL:url_request_context.cc(134)] Check failed: false. Leaked 1 URLRequest(s). First URL: http://foo.com/simple_page.html#2

This sometimes happen in a few other tests (RenderFrameHostManagerTest.DontShowLoadingURLIfNotInitialNav for example), but seems to happen more consistently in SecurityExploitBrowserTest.AttemptDuplicateRenderWidgetHost. I'm going to do an early return in this test on Android when PlzNavigate is enabled while we investigate.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6955cae058e32565a628bb9c0c37f01aad23cdf3

commit 6955cae058e32565a628bb9c0c37f01aad23cdf3
Author: clamy <clamy@chromium.org>
Date: Fri Mar 17 13:42:43 2017

PlzNavigate: disable one test on Android

SecurityExploitBrowserTest.AttemptDuplicateRenderWidgetHost has been
failing a flaky manner on Android. This CL makes it return early on
Android when PlzNavigate is enabled while we investigate the root cause
of the failure.

BUG= 702584 
TBR=nasko@chromium.org

Review-Url: https://codereview.chromium.org/2759653002
Cr-Commit-Position: refs/heads/master@{#457752}

[modify] https://crrev.com/6955cae058e32565a628bb9c0c37f01aad23cdf3/content/browser/security_exploit_browsertest.cc

Comment 2 by clamy@chromium.org, Mar 17 2017

Cc: clamy@chromium.org jam@chromium.org nasko@chromium.org

Comment 3 by joh...@chromium.org, Mar 21 2017

Blocking: 703657
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d705708b78acf0c3399475f6bcd46433bdc65eee

commit d705708b78acf0c3399475f6bcd46433bdc65eee
Author: johnme <johnme@chromium.org>
Date: Tue Mar 21 15:03:50 2017

Mark 3 tests flaky on android

The following tests are flaky:
- SecurityExploitBrowserTest.AttemptDuplicateRenderWidgetHost
- SecurityExploitBrowserTest.AttemptDuplicateRenderViewHost
- RenderFrameHostManagerTest.DontShowLoadingURLIfNotInitialNav

NOTREECHECKS=true
NOTRY=true
BUG=703657, 702584 
TBR=boliu@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2762203002
Cr-Commit-Position: refs/heads/master@{#458413}

[modify] https://crrev.com/d705708b78acf0c3399475f6bcd46433bdc65eee/content/browser/frame_host/render_frame_host_manager_browsertest.cc
[modify] https://crrev.com/d705708b78acf0c3399475f6bcd46433bdc65eee/content/browser/security_exploit_browsertest.cc

Comment 5 by jam@chromium.org, Mar 21 2017

Mergedinto: 703657
Status: Duplicate (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f61aa0c185b00ef4a6d5f5b83fd6aeeeb8972f8

commit 5f61aa0c185b00ef4a6d5f5b83fd6aeeeb8972f8
Author: jam <jam@chromium.org>
Date: Tue Mar 21 20:30:39 2017

Revert of Mark 3 tests flaky on android (patchset #1 id:1 of https://codereview.chromium.org/2762203002/ )

Reason for revert:
The fix relanded in https://codereview.chromium.org/2764613002/.

Original issue's description:
> Mark 3 tests flaky on android
>
> The following tests are flaky:
> - SecurityExploitBrowserTest.AttemptDuplicateRenderWidgetHost
> - SecurityExploitBrowserTest.AttemptDuplicateRenderViewHost
> - RenderFrameHostManagerTest.DontShowLoadingURLIfNotInitialNav
>
> NOTREECHECKS=true
> NOTRY=true
> BUG=703657, 702584 
> TBR=boliu@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Review-Url: https://codereview.chromium.org/2762203002
> Cr-Commit-Position: refs/heads/master@{#458413}
> Committed: https://chromium.googlesource.com/chromium/src/+/d705708b78acf0c3399475f6bcd46433bdc65eee

TBR=boliu@chromium.org,johnme@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=703657, 702584 

Review-Url: https://codereview.chromium.org/2767733002
Cr-Commit-Position: refs/heads/master@{#458534}

[modify] https://crrev.com/5f61aa0c185b00ef4a6d5f5b83fd6aeeeb8972f8/content/browser/frame_host/render_frame_host_manager_browsertest.cc
[modify] https://crrev.com/5f61aa0c185b00ef4a6d5f5b83fd6aeeeb8972f8/content/browser/security_exploit_browsertest.cc
►

Sign in to add a comment