shape detection: Invalid attribute type in DetectedBarcode.idl |
|||
Issue description
//third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.idl has the following declaration:
[SameObject] readonly attribute sequence<Point2D> cornerPoints;
However, https://heycam.github.io/webidl/#idl-sequence explicitly states "Sequences must not be used as the type of an attribute or constant".
We'd like to fix all occurrences of invalid attribute types in order to make the IDL compiler reject them in the future.
In this case, it looks like the upstream spec also needs to be fixed.
,
Mar 17 2017
The shape detection specification currently uses sequences incorrectly. I have filed an issue to track fixing that as well: https://github.com/WICG/shape-detection-api/issues/23
,
Mar 17 2017
Created a pull request to fix the spec: https://github.com/WICG/shape-detection-api/pull/24
,
Mar 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc4d9edc3304b2291bae8f93745654bedc2c2ecd commit fc4d9edc3304b2291bae8f93745654bedc2c2ecd Author: reillyg <reillyg@chromium.org> Date: Sat Mar 18 02:42:39 2017 Replace sequence with FrozenArray in DetectedBarcode.idl. It is invalid to use a sequence as an attribute type. I have submitted a pull request to the shape detection API specification to fix this there as well: https://github.com/WICG/shape-detection-api/pull/24 BUG= 702582 Review-Url: https://codereview.chromium.org/2756063003 Cr-Commit-Position: refs/heads/master@{#457936} [modify] https://crrev.com/fc4d9edc3304b2291bae8f93745654bedc2c2ecd/third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.idl
,
Mar 18 2017
Thanks raphael.kubo.da.costa@intel.com and reillyg@ ! |
|||
►
Sign in to add a comment |
|||
Comment 1 by raphael....@intel.com
, Mar 17 2017