New issue
Advanced search Search tips

Issue 702581 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 693513



Sign in to add a comment

payments: Invalid attribute type in PaymentRequestEvent.idl

Project Member Reported by raphael....@intel.com, Mar 17 2017

Issue description

//third_party/WebKit/Source/modules/payments/PaymentRequestEvent.idl contains the following declaration:

    readonly attribute PaymentAppRequest appRequest;

However, https://heycam.github.io/webidl/#idl-dictionaries explicitly states "Dictionaries must not be used as the type of an attribute or constant".

We'd like to fix all occurrences of invalid attribute types in order to make the IDL compiler reject them in the future.
 
Status: ExternalDependency (was: Available)
Filed a spec issue in https://github.com/w3c/webpayments-payment-apps-api/issues/111.
Owner: rouslan@chromium.org
Status: Assigned (was: ExternalDependency)
Spec issue was resolved. Seems to be in payment team's court to update to reflect this.
thx for the notification. hopefully can get this done in M60
Status: ExternalDependency (was: Assigned)
https://github.com/w3c/payment-handler/issues/175
Status: Available (was: ExternalDependency)
The spec is fixed in https://github.com/w3c/payment-handler/pull/177.
Status: Fixed (was: Available)
Fixed in http://crrev.com/2933023002. Raphael: please verify.
Status: Verified (was: Fixed)
Looks fine to me, thanks for working on this!

Sign in to add a comment