app_banner: Invalid attribute type in BeforeInstallPromptEvent.idl |
||
Issue description
//third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.idl contains the following declaration:
readonly attribute sequence<DOMString> platforms;
However, https://heycam.github.io/webidl/#idl-sequence explicitly states "Sequences must not be used as the type of an attribute or constant".
We'd like to fix all occurrences of invalid attribute types in order to make the IDL compiler reject them in the future.
,
Mar 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b41da6057cbf6fe719a7105881a195dcb49e297d commit b41da6057cbf6fe719a7105881a195dcb49e297d Author: mlamouri <mlamouri@chromium.org> Date: Mon Mar 20 13:29:53 2017 App Banner: BeforeInstallPrompt.platforms should use a FrozenArary<> BUG= 702580 R=dominickn@chromium.org Review-Url: https://codereview.chromium.org/2756933002 Cr-Commit-Position: refs/heads/master@{#458049} [modify] https://crrev.com/b41da6057cbf6fe719a7105881a195dcb49e297d/third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.idl
,
Mar 22 2017
Thanks; is there anything else you need to do or should this issue be closed?
,
Mar 22 2017
Closing sounds good :) |
||
►
Sign in to add a comment |
||
Comment 1 by mlamouri@chromium.org
, Mar 17 2017Status: Started (was: Available)