New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 702578 link

Starred by 2 users
Status: Fixed
Owner:
█ zakerinasab@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Cc:
█ junov@chromium.org
█ zakerinasab@chromium.org
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 634542
issue 693513



Sign in to add a comment

Canvas Color Space: Invalid attribute type in ImageData.idl

Project Member Reported by raphael....@intel.com, Mar 17 2017 
https://codereview.chromium.org/2728373004 added the following attribute to ImageData.idl:

    [RuntimeEnabled=ExperimentalCanvasFeatures] readonly attribute ImageDataColorSettings colorSettings;

However, ImageDataColorSettings is a dictionary, and https://heycam.github.io/webidl/#idl-dictionaries specifically states "Dictionaries must not be used as the type of an attribute or constant".

It looks like the Canvas Color Spec itself needs to be fixed, and the IDL then needs to be updated in Chromium.

Comment 1 by junov@chromium.org, Mar 20 2017

Owner: zakerinasab@chromium.org
Status: Assigned (was: Available)
We could make this a getter method then.

IDL:

ImageDataColorSettings getColorSettings();

Comment 2 by zakerinasab@chromium.org, Mar 29 2017

Labels: -Type-Bug Type-Feature
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c15a4e2b594e61442419a6fec5c5e15ba303dc01

commit c15a4e2b594e61442419a6fec5c5e15ba303dc01
Author: zakerinasab <zakerinasab@chromium.org>
Date: Mon Apr 03 22:55:17 2017

Convert colorSettins attribute in ImageData.idl to a getter method

ImageDataColorSettings is a dictionary, so it must not be used as the type of an attribute. This CL fixes this by converting the colorSettings attribute in ImageData interface to a getter method.

BUG= 702578 

Review-Url: https://codereview.chromium.org/2788373003
Cr-Commit-Position: refs/heads/master@{#461567}

[modify] https://crrev.com/c15a4e2b594e61442419a6fec5c5e15ba303dc01/third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace.html
[modify] https://crrev.com/c15a4e2b594e61442419a6fec5c5e15ba303dc01/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/c15a4e2b594e61442419a6fec5c5e15ba303dc01/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/c15a4e2b594e61442419a6fec5c5e15ba303dc01/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/c15a4e2b594e61442419a6fec5c5e15ba303dc01/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/c15a4e2b594e61442419a6fec5c5e15ba303dc01/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/c15a4e2b594e61442419a6fec5c5e15ba303dc01/third_party/WebKit/Source/core/html/ImageData.h
[modify] https://crrev.com/c15a4e2b594e61442419a6fec5c5e15ba303dc01/third_party/WebKit/Source/core/html/ImageData.idl
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a08d8f3b27df0ff438dc9bf7b903bc1893636bb

commit 1a08d8f3b27df0ff438dc9bf7b903bc1893636bb
Author: timloh <timloh@chromium.org>
Date: Tue Apr 04 05:17:21 2017

Revert of Convert colorSettins attribute in ImageData.idl to a getter method (patchset #2 id:20001 of https://codereview.chromium.org/2788373003/ )

Reason for revert:
Trying to land a revert of https://codereview.chromium.org/2771813003/ which added flaky crashing tests, but this conflicts with it.

Original issue's description:
> Convert colorSettins attribute in ImageData.idl to a getter method
>
> ImageDataColorSettings is a dictionary, so it must not be used as the type of an attribute. This CL fixes this by converting the colorSettings attribute in ImageData interface to a getter method.
>
> BUG= 702578 
>
> Review-Url: https://codereview.chromium.org/2788373003
> Cr-Commit-Position: refs/heads/master@{#461567}
> Committed: https://chromium.googlesource.com/chromium/src/+/c15a4e2b594e61442419a6fec5c5e15ba303dc01

TBR=junov@chromium.org,zakerinasab@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 702578 

Review-Url: https://codereview.chromium.org/2794233002
Cr-Commit-Position: refs/heads/master@{#461634}

[modify] https://crrev.com/1a08d8f3b27df0ff438dc9bf7b903bc1893636bb/third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace.html
[modify] https://crrev.com/1a08d8f3b27df0ff438dc9bf7b903bc1893636bb/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/1a08d8f3b27df0ff438dc9bf7b903bc1893636bb/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/1a08d8f3b27df0ff438dc9bf7b903bc1893636bb/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/1a08d8f3b27df0ff438dc9bf7b903bc1893636bb/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1a08d8f3b27df0ff438dc9bf7b903bc1893636bb/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/1a08d8f3b27df0ff438dc9bf7b903bc1893636bb/third_party/WebKit/Source/core/html/ImageData.h
[modify] https://crrev.com/1a08d8f3b27df0ff438dc9bf7b903bc1893636bb/third_party/WebKit/Source/core/html/ImageData.idl
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfdfa5a0d0415d80b0f284e14e90638c4b54b025

commit dfdfa5a0d0415d80b0f284e14e90638c4b54b025
Author: zakerinasab <zakerinasab@chromium.org>
Date: Tue Apr 04 19:42:02 2017

Convert colorSettins attribute in ImageData.idl to a getter method

ImageDataColorSettings is a dictionary, so it must not be used as the type of an attribute. This CL fixes this by converting the colorSettings attribute in ImageData interface to a getter method.

BUG= 702578 

Review-Url: https://codereview.chromium.org/2788373003
Cr-Original-Commit-Position: refs/heads/master@{#461567}
Committed: https://chromium.googlesource.com/chromium/src/+/c15a4e2b594e61442419a6fec5c5e15ba303dc01
Review-Url: https://codereview.chromium.org/2788373003
Cr-Commit-Position: refs/heads/master@{#461803}

[modify] https://crrev.com/dfdfa5a0d0415d80b0f284e14e90638c4b54b025/third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace.html
[modify] https://crrev.com/dfdfa5a0d0415d80b0f284e14e90638c4b54b025/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/dfdfa5a0d0415d80b0f284e14e90638c4b54b025/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/dfdfa5a0d0415d80b0f284e14e90638c4b54b025/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/dfdfa5a0d0415d80b0f284e14e90638c4b54b025/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/dfdfa5a0d0415d80b0f284e14e90638c4b54b025/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/dfdfa5a0d0415d80b0f284e14e90638c4b54b025/third_party/WebKit/Source/core/html/ImageData.h
[modify] https://crrev.com/dfdfa5a0d0415d80b0f284e14e90638c4b54b025/third_party/WebKit/Source/core/html/ImageData.idl

Comment 6 by zakerinasab@chromium.org, Apr 4 2017

Status: Fixed (was: Assigned)

Comment 7 by raphael....@intel.com, Apr 5 2017 

Thanks!

Comment 8 by zakerinasab@chromium.org, Nov 27 2017

Blocking: 634542
►

Sign in to add a comment