New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702557 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Replace booleans by enums NavigationHandleImpl::Create()

Project Member Reported by arthurso...@chromium.org, Mar 17 2017

Issue description

Please consider this function:
  static std::unique_ptr<NavigationHandleImpl> Create(
      const GURL& url,
      const std::vector<GURL>& redirect_chain,
      FrameTreeNode* frame_tree_node,
      bool is_renderer_initiated,
      bool is_same_page,
      const base::TimeTicks& navigation_start,
      int pending_nav_entry_id,
      bool started_from_context_menu,
      CSPDisposition should_check_main_world_csp,
      bool is_form_submission);

It begins to have too many booleans on this method. It might be useful to convert them to enums, so they are more meaningful when reading the callers of this method.

 
Summary: Replace booleans by enums NavigationHandleImpl::Create() (was: Replace booleans by enums in )

Sign in to add a comment