eCryptfs->ext4: Implement cryptohomed::MigrateToDircrypto Dbus method. |
||||||||||||
Issue descriptionMigration library by dspaid@ https://chromium-review.googlesource.com/c/436985/ and Dbus protocol to kick the migration by kinaba@ https://chromium-review.googlesource.com/c/454361/ is getting close to be ready. The remaining task here is add a code to mount the both types of home directory, and run the migration by using Dan's library.
,
Mar 27 2017
Yea, I can take it.
,
Apr 6 2017
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e792e0e91d5b20121b9eb634b43af7eeb04b612f commit e792e0e91d5b20121b9eb634b43af7eeb04b612f Author: hashimoto <hashimoto@chromium.org> Date: Thu Apr 06 01:34:18 2017 cryptohome: Make CryptohomeClient::Unmount non-blocking eCryptfs->ext4 crypto migrator will use Unmount. Before adding a new user, stop blocking the UI thread for this D-Bus method call. BUG= 702526 TEST=unit_tests --gtest_filter="CryptohomeAuthenticatorTest.*" Review-Url: https://codereview.chromium.org/2797163002 Cr-Commit-Position: refs/heads/master@{#462311} [modify] https://crrev.com/e792e0e91d5b20121b9eb634b43af7eeb04b612f/chromeos/dbus/cryptohome_client.cc [modify] https://crrev.com/e792e0e91d5b20121b9eb634b43af7eeb04b612f/chromeos/dbus/cryptohome_client.h [modify] https://crrev.com/e792e0e91d5b20121b9eb634b43af7eeb04b612f/chromeos/dbus/fake_cryptohome_client.cc [modify] https://crrev.com/e792e0e91d5b20121b9eb634b43af7eeb04b612f/chromeos/dbus/fake_cryptohome_client.h [modify] https://crrev.com/e792e0e91d5b20121b9eb634b43af7eeb04b612f/chromeos/dbus/mock_cryptohome_client.h [modify] https://crrev.com/e792e0e91d5b20121b9eb634b43af7eeb04b612f/chromeos/login/auth/cryptohome_authenticator.cc [modify] https://crrev.com/e792e0e91d5b20121b9eb634b43af7eeb04b612f/chromeos/login/auth/cryptohome_authenticator.h
,
Apr 10 2017
Uploaded all needed patches: - https://chromium-review.googlesource.com/c/461738 - https://chromium-review.googlesource.com/c/461781 - https://chromium-review.googlesource.com/c/472409 Please apply them locally for development.
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/4198b66c7ace982faff4054d3cfda55ea432839f commit 4198b66c7ace982faff4054d3cfda55ea432839f Author: Ryo Hashimoto <hashimoto@google.com> Date: Thu Apr 13 05:42:00 2017 cryptohome: Add a new mount argument for migration When this new argument is true, MountEx mounts the existing eCryptfs vault to a temporary location, while setting up a dircrypto home directory at the normal mount destination. - Add a new parameter to_migrate_from_ecryptfs to Mount::MountArgs - Fill Mount::MountArgs::to_migrate_from_ecryptfs in service.cc - Add a new switch to_migrate_from_ecryptfs to cryptohome.cc - Implement the logic in Mount::MountCryptohomeInner - Add a test CQ-DEPEND=CL:461738 BUG= chromium:702526 TEST=cryptohome --action=mount_ex --user=foo@foo.com --to_migrate_from_ecryptfs TEST=cros_workon_make cryptohome --test Change-Id: I3ea4f6f1d4e5c83e76fe4f3cf95742357288a748 Reviewed-on: https://chromium-review.googlesource.com/461781 Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org> Tested-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> [modify] https://crrev.com/4198b66c7ace982faff4054d3cfda55ea432839f/cryptohome/make_tests.cc [modify] https://crrev.com/4198b66c7ace982faff4054d3cfda55ea432839f/cryptohome/cryptohome.cc [modify] https://crrev.com/4198b66c7ace982faff4054d3cfda55ea432839f/cryptohome/mount.cc [modify] https://crrev.com/4198b66c7ace982faff4054d3cfda55ea432839f/cryptohome/mount.h [modify] https://crrev.com/4198b66c7ace982faff4054d3cfda55ea432839f/cryptohome/service.cc [modify] https://crrev.com/4198b66c7ace982faff4054d3cfda55ea432839f/cryptohome/mount_unittest.cc
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/system_api/+/f425c1c372b0077a67937855f03f1089d0df7970 commit f425c1c372b0077a67937855f03f1089d0df7970 Author: Ryo Hashimoto <hashimoto@google.com> Date: Thu Apr 13 05:42:00 2017 cryptohome: Add a new mount argument for migration When this new argument is true, MountEx mounts the existing eCryptfs vault to a temporary location, while setting up a dircrypto home directory at the normal mount destination. BUG= chromium:702526 TEST=cryptohome --action=mount_ex --user=foo@foo.com --to_migrate_from_ecryptfs Change-Id: I8081f8a0bc166fed3649b4577d36f92bab3a1778 Reviewed-on: https://chromium-review.googlesource.com/461738 Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org> Tested-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org> [modify] https://crrev.com/f425c1c372b0077a67937855f03f1089d0df7970/dbus/cryptohome/rpc.proto
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/system_api/+/f425c1c372b0077a67937855f03f1089d0df7970 commit f425c1c372b0077a67937855f03f1089d0df7970 Author: Ryo Hashimoto <hashimoto@google.com> Date: Thu Apr 13 05:42:00 2017 cryptohome: Add a new mount argument for migration When this new argument is true, MountEx mounts the existing eCryptfs vault to a temporary location, while setting up a dircrypto home directory at the normal mount destination. BUG= chromium:702526 TEST=cryptohome --action=mount_ex --user=foo@foo.com --to_migrate_from_ecryptfs Change-Id: I8081f8a0bc166fed3649b4577d36f92bab3a1778 Reviewed-on: https://chromium-review.googlesource.com/461738 Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org> Tested-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org> [modify] https://crrev.com/f425c1c372b0077a67937855f03f1089d0df7970/dbus/cryptohome/rpc.proto
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a15de7e2276f1ccaf8392b4268002f2979a246a5 commit a15de7e2276f1ccaf8392b4268002f2979a246a5 Author: hashimoto <hashimoto@chromium.org> Date: Thu Apr 13 09:28:30 2017 Roll cros_system_api to f425c1c372b0077a67937855f03f1089d0df7970 f425c1c cryptohome: Add a new mount argument for migration BUG= 702526 TEST=build Review-Url: https://codereview.chromium.org/2815163004 Cr-Commit-Position: refs/heads/master@{#464357} [modify] https://crrev.com/a15de7e2276f1ccaf8392b4268002f2979a246a5/DEPS
,
Apr 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/076ff4a8a39435d7c805bf17aa0683c7100c87d0 commit 076ff4a8a39435d7c805bf17aa0683c7100c87d0 Author: Ryo Hashimoto <hashimoto@google.com> Date: Mon Apr 17 05:39:03 2017 cryptohome: Implement Service::DoMigrateToDircrypto - Add Mount::MigrateToDircrypto. - SUCCESS/FAILED progress signals are sent by Service. - Implement cryptohome --action=migrate_to_dircrypto. BUG= chromium:702526 TEST=cryptohome --action=migrate_to_dircrypto --user=foo@foo.com Change-Id: If79262162942a862293b01a9740e185f1eb42385 Reviewed-on: https://chromium-review.googlesource.com/472409 Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org> Tested-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Dan Spaid <dspaid@chromium.org> [modify] https://crrev.com/076ff4a8a39435d7c805bf17aa0683c7100c87d0/cryptohome/service.h [modify] https://crrev.com/076ff4a8a39435d7c805bf17aa0683c7100c87d0/cryptohome/service.cc [modify] https://crrev.com/076ff4a8a39435d7c805bf17aa0683c7100c87d0/cryptohome/interface.h [modify] https://crrev.com/076ff4a8a39435d7c805bf17aa0683c7100c87d0/cryptohome/cryptohome.cc [modify] https://crrev.com/076ff4a8a39435d7c805bf17aa0683c7100c87d0/cryptohome/mount.cc [modify] https://crrev.com/076ff4a8a39435d7c805bf17aa0683c7100c87d0/cryptohome/dircrypto_data_migrator/migration_helper.cc [modify] https://crrev.com/076ff4a8a39435d7c805bf17aa0683c7100c87d0/cryptohome/dircrypto_data_migrator/migration_helper.h [modify] https://crrev.com/076ff4a8a39435d7c805bf17aa0683c7100c87d0/cryptohome/mount.h [modify] https://crrev.com/076ff4a8a39435d7c805bf17aa0683c7100c87d0/cryptohome/interface.cc [modify] https://crrev.com/076ff4a8a39435d7c805bf17aa0683c7100c87d0/cryptohome/dircrypto_data_migrator/migration_helper_unittest.cc [modify] https://crrev.com/076ff4a8a39435d7c805bf17aa0683c7100c87d0/cryptohome/cryptohome.xml
,
Apr 18 2017
Requesting merge of https://chromium-review.googlesource.com/472409 to M-59.
,
Apr 18 2017
This bug requires manual review: DEPS changes referenced in bugdroid comments. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 21 2017
DEPS roll was before the branch point, so the cherry pick request is for #10 ?
,
Apr 21 2017
,
Apr 24 2017
,
Apr 25 2017
Any update on merge review? What I want to merge is only https://chromium-review.googlesource.com/472409.
,
Apr 25 2017
,
Apr 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/b82ee01d18231fca1f3a662aeb5bf08d6cf34792 commit b82ee01d18231fca1f3a662aeb5bf08d6cf34792 Author: Ryo Hashimoto <hashimoto@google.com> Date: Wed Apr 26 04:46:55 2017 cryptohome: Implement Service::DoMigrateToDircrypto - Add Mount::MigrateToDircrypto. - SUCCESS/FAILED progress signals are sent by Service. - Implement cryptohome --action=migrate_to_dircrypto. BUG= chromium:702526 TEST=cryptohome --action=migrate_to_dircrypto --user=foo@foo.com Change-Id: If79262162942a862293b01a9740e185f1eb42385 Reviewed-on: https://chromium-review.googlesource.com/472409 Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org> Tested-by: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Dan Spaid <dspaid@chromium.org> (cherry picked from commit 076ff4a8a39435d7c805bf17aa0683c7100c87d0) Reviewed-on: https://chromium-review.googlesource.com/487761 Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> [modify] https://crrev.com/b82ee01d18231fca1f3a662aeb5bf08d6cf34792/cryptohome/service.h [modify] https://crrev.com/b82ee01d18231fca1f3a662aeb5bf08d6cf34792/cryptohome/service.cc [modify] https://crrev.com/b82ee01d18231fca1f3a662aeb5bf08d6cf34792/cryptohome/interface.h [modify] https://crrev.com/b82ee01d18231fca1f3a662aeb5bf08d6cf34792/cryptohome/cryptohome.cc [modify] https://crrev.com/b82ee01d18231fca1f3a662aeb5bf08d6cf34792/cryptohome/mount.cc [modify] https://crrev.com/b82ee01d18231fca1f3a662aeb5bf08d6cf34792/cryptohome/dircrypto_data_migrator/migration_helper.cc [modify] https://crrev.com/b82ee01d18231fca1f3a662aeb5bf08d6cf34792/cryptohome/dircrypto_data_migrator/migration_helper.h [modify] https://crrev.com/b82ee01d18231fca1f3a662aeb5bf08d6cf34792/cryptohome/mount.h [modify] https://crrev.com/b82ee01d18231fca1f3a662aeb5bf08d6cf34792/cryptohome/interface.cc [modify] https://crrev.com/b82ee01d18231fca1f3a662aeb5bf08d6cf34792/cryptohome/dircrypto_data_migrator/migration_helper_unittest.cc [modify] https://crrev.com/b82ee01d18231fca1f3a662aeb5bf08d6cf34792/cryptohome/cryptohome.xml
,
Apr 26 2017
,
May 17 2017
Verified on build 9460.42.0 ============================== localhost / # cryptohome --action=migrate_to_dircrypto --user=foo@foo.com MigrateToDircrypto call succeeded. localhost / # ==============================
,
Jun 16 2017
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by kinaba@chromium.org
, Mar 27 2017Status: Assigned (was: Available)