factory: Check and fail if deprecated regional VPDs were found. |
|||||||
Issue descriptionAs found in issue 700625, there may be still partners provisioning old regional VPD values (initial_locale. initial_timezone, keyboar_layout) even while our stand factory toolkits are not using / checking them anymore. And unfortunately, they may do it wrong. Since all devices should be already using FSI >= M47, we can assume all devices should only have 'region' in VPD. Let's try to improve the process so partners won't make mistakes. I think we can a step - either in finalization pytest or gooftool, to check and fail if these VPD names and found. You can give some error message and forward them to this issue, or ask them to reach SIE or factory team for help.
,
Mar 20 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/docs/+/6666bbe1b5224030d275e762020bd170bf62d879 commit 6666bbe1b5224030d275e762020bd170bf62d879 Author: Hung-Te Lin <hungte@chromium.org> Date: Mon Mar 20 02:02:26 2017
,
Mar 20 2017
,
Mar 29 2017
Re-assign to yhong. This is probably better as a start for learning pytests & gooftool.
,
May 18 2017
Reassign to petershih.
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/fff50e6f1c87de263dd8f3d2405729c8be10a195 commit fff50e6f1c87de263dd8f3d2405729c8be10a195 Author: Hung-Te Lin <hungte@chromium.org> Date: Tue Jun 06 17:33:40 2017 gooftool: Deprecate legacy regional VPD values. The initial_locale, initial_timezone, keyboard_layout legacy field should be removed and raise exception if found. BUG= chromium:702503 TEST=make test Change-Id: I40e1c6318c260b75e35b04fc530c34deae594123 Reviewed-on: https://chromium-review.googlesource.com/525273 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> [modify] https://crrev.com/fff50e6f1c87de263dd8f3d2405729c8be10a195/doc/regions.rst [modify] https://crrev.com/fff50e6f1c87de263dd8f3d2405729c8be10a195/py/gooftool/core.py [modify] https://crrev.com/fff50e6f1c87de263dd8f3d2405729c8be10a195/py/test/l10n/regions.py
,
Jun 6 2017
,
Jun 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/7d4a779d54bbb7e6d946b11944a7c4ae841b66e5 commit 7d4a779d54bbb7e6d946b11944a7c4ae841b66e5 Author: Hung-Te Lin <hungte@chromium.org> Date: Tue Jun 06 17:47:42 2017 gooftool: Deprecate legacy regional VPD values. The initial_locale, initial_timezone, keyboard_layout legacy field should be removed and raise exception if found. BUG= chromium:702503 TEST=make test Change-Id: I40e1c6318c260b75e35b04fc530c34deae594123 Reviewed-on: https://chromium-review.googlesource.com/525273 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/525655 Reviewed-by: Hung-Te Lin <hungte@chromium.org> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Trybot-Ready: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/7d4a779d54bbb7e6d946b11944a7c4ae841b66e5/doc/regions.rst [modify] https://crrev.com/7d4a779d54bbb7e6d946b11944a7c4ae841b66e5/py/gooftool/core.py [modify] https://crrev.com/7d4a779d54bbb7e6d946b11944a7c4ae841b66e5/py/test/l10n/regions.py
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/81503efa3f0952b61229653d3544d86e6469dceb commit 81503efa3f0952b61229653d3544d86e6469dceb Author: Hung-Te Lin <hungte@chromium.org> Date: Wed Jun 07 02:47:01 2017 gooftool: Deprecate legacy regional VPD values. The initial_locale, initial_timezone, keyboard_layout legacy field should be removed and raise exception if found. BUG= chromium:702503 TEST=make test Change-Id: I40e1c6318c260b75e35b04fc530c34deae594123 Reviewed-on: https://chromium-review.googlesource.com/525273 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/526173 Reviewed-by: Youcheng Syu <youcheng@google.com> Commit-Queue: Hung-Te Lin <hungte@chromium.org> Trybot-Ready: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/81503efa3f0952b61229653d3544d86e6469dceb/doc/regions.rst [modify] https://crrev.com/81503efa3f0952b61229653d3544d86e6469dceb/py/gooftool/core.py [modify] https://crrev.com/81503efa3f0952b61229653d3544d86e6469dceb/py/test/l10n/regions.py
,
Jan 22 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by hungte@chromium.org
, Mar 17 2017Owner: yllin@chromium.org
Status: Assigned (was: Untriaged)