New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 702495 link

Starred by 1 user
Status: Fixed
Owner:
hcarmona@chromium.org
Closed: Mar 2017
Cc:
nyerramilli@chromium.org
kkaluri@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessary people section is seen in background while opening 'Manage passwords' overlay.

Reported by mni...@etouch.net, Mar 17 2017 
Version: 59.0.3043.0 fe785a58e31217e1ef0e1c8946a4e853829371f8-refs/heads/master@{#457297}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.1)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings and scroll down the page and open 'Advanced' section
2. Now click on 'Manage passwords' and observe background while opening 'Manage passwords' overlay

Actual: Unnecessary profile name and picture is seen in background while opening 'Manage passwords' overlay at first instance
Expected: Unnecessary profile name and picture should not be seen in background while opening 'Manage passwords' overlay at first instance

This is regression issue, broken in ‘M 58’ and will soon update other info :
Good build:58.0.3014.0
Bad build: 58.0.3015.0
Actual_video.mp4
361 KB View Download
Expected_video.mp4
403 KB View Download

Comment 1 by kkaluri@chromium.org, Mar 17 2017

Cc: kkaluri@chromium.org
Labels: hasbisect-per-revision
Owner: hcarmona@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========
Good build :  58.0.3014.0,  Revision Range - 450840
Bad build  :  58.0.3016.0,  Revision Range - 451403

After executing the per-revision bisect script , i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/80afbc06fd130755c7648d008bd6a9ddb8f65e16..7320f5e364e6c02b2d044612e4e488d70bb1e24f

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/7320f5e364e6c02b2d044612e4e488d70bb1e24f

Review-Url: https://codereview.chromium.org/2627123002

hcarmona@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

Comment 2 by hcarmona@chromium.org, Mar 21 2017

Status: Started (was: Assigned)
This looks related to the opening animation for the sub page.

The CL in the blame list seems like a likely culprit, because it changed when we load data.

I'm thinking that making all the binding async will remove the visual glitch.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2375ddd498a6ee826fc3ac6edf220b91f41cc615

commit 2375ddd498a6ee826fc3ac6edf220b91f41cc615
Author: hcarmona <hcarmona@chromium.org>
Date: Thu Mar 23 00:15:36 2017

MD Settings: Add listeners on attached instead of ready.

This prevents a visual glitch where you can see the top of the settings
page before the sub page loads.

BUG= 702495 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2766603003
Cr-Commit-Position: refs/heads/master@{#458946}

[modify] https://crrev.com/2375ddd498a6ee826fc3ac6edf220b91f41cc615/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js
[modify] https://crrev.com/2375ddd498a6ee826fc3ac6edf220b91f41cc615/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js

Comment 4 by hcarmona@chromium.org, Mar 29 2017

Status: Fixed (was: Started)
►

Sign in to add a comment