New issue
Advanced search Search tips

Issue 702454 link

Starred by 1 user
Status: Fixed
Owner:
isherman@chromium.org
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Only upload crash reports over unmetered networks

Project Member Reported by isherman@chromium.org, Mar 17 2017 
We currently only upload crash reports over WiFi or Ethernet, with the intention of not using metered networks.  However, WiFi networks can be metered; we should really be uploading over /unmetered/ networks.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba20b44face1a92875fab6a62959f68faa400aa6

commit ba20b44face1a92875fab6a62959f68faa400aa6
Author: isherman <isherman@chromium.org>
Date: Tue Mar 28 22:44:42 2017

[Crash Reporting] Only upload Chrome crash reports over unmetered networks.

BUG= 702454 
TEST=none
R=gsennton@chromium.org, mariakhomenko@chromium.org

Review-Url: https://codereview.chromium.org/2751333004
Cr-Commit-Position: refs/heads/master@{#460227}

[modify] https://crrev.com/ba20b44face1a92875fab6a62959f68faa400aa6/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
[modify] https://crrev.com/ba20b44face1a92875fab6a62959f68faa400aa6/android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java
[modify] https://crrev.com/ba20b44face1a92875fab6a62959f68faa400aa6/chrome/android/BUILD.gn
[modify] https://crrev.com/ba20b44face1a92875fab6a62959f68faa400aa6/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java
[modify] https://crrev.com/ba20b44face1a92875fab6a62959f68faa400aa6/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java
[modify] https://crrev.com/ba20b44face1a92875fab6a62959f68faa400aa6/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
[modify] https://crrev.com/ba20b44face1a92875fab6a62959f68faa400aa6/chrome/android/java_sources.gni
[delete] https://crrev.com/feb94cb92b94f6cba3a8ba53d1b30c2bd617ae74/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManagerTest.java
[add] https://crrev.com/ba20b44face1a92875fab6a62959f68faa400aa6/chrome/android/junit/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManagerTest.java
[modify] https://crrev.com/ba20b44face1a92875fab6a62959f68faa400aa6/components/minidump_uploader/BUILD.gn
[modify] https://crrev.com/ba20b44face1a92875fab6a62959f68faa400aa6/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadJobService.java
[add] https://crrev.com/ba20b44face1a92875fab6a62959f68faa400aa6/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/NetworkPermissionUtil.java

Comment 2 by isherman@chromium.org, Mar 28 2017

Status: Fixed (was: Started)

Comment 3 by aluo@chromium.org, Mar 30 2017

Status: Verified (was: Fixed)
Verified on Pixel 59.0.3056.4

Comment 4 by aluo@chromium.org, Mar 30 2017

Status: Fixed (was: Verified)
Verified for WebView only, moving back to fixed.  Still needs to verify for Chrome.
►

Sign in to add a comment