New issue
Advanced search Search tips

Issue 702441 link

Starred by 1 user
Status: Fixed
Owner:
aleloi@chromium.org
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

chromium Debug building will crash on Android

Project Member Reported by braveyao@chromium.org, Mar 17 2017 
Chrome Version: 59.0.3042
OS: Android 6.0.1

What steps will reproduce the problem?
(1) build a chromium for Android with debug building
(2) launch chromium on Android device, mine is N5,Android M 6.0.1
(3) start a loopback call against appr.tc demo, https://appr.tc/?debug=loopback

What is the expected result?
loopback call will be established with both video and audio

What happens instead?
Chromium crashes

Please use labels and text to provide additional information.

Call stack is:
03-16 17:02:10.812  9061  9262 F chromium: [FATAL:media_stream_audio_processor.cc(535)] Check failed: audio_processing_->echo_control_mobile()->is_enabled(). 
03-16 17:02:10.812  9061  9262 F chromium: #00 0x9fdcc6bd /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so+0x000a16bd
03-16 17:02:10.812  9061  9262 F chromium: #01 0x9a5e6a21 /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so+0x00b2ba21
03-16 17:02:10.812  9061  9262 F chromium: #02 0x9a62411f /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so+0x00b6911f
03-16 17:02:10.812  9061  9262 F chromium: #03 0x9a627def /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so+0x00b6cdef
03-16 17:02:10.812  9061  9262 F chromium: #04 0x9d7cce81 /data/app/org.chromium.chrome-2/lib/arm/libmedia.cr.so+0x00114e81
03-16 17:02:10.812  9061  9262 F chromium: #05 0x9a627c39 /data/app/org.chromium.chrome-2/lib/arm/libcontent.cr.so+0x00b6cc39
03-16 17:02:10.812  9061  9262 F chromium: #06 0x9d7b78f3 /data/app/org.chromium.chrome-2/lib/arm/libmedia.cr.so+0x000ff8f3
03-16 17:02:10.812  9061  9262 F chromium: #07 0x9d7abff1 /data/app/org.chromium.chrome-2/lib/arm/libmedia.cr.so+0x000f3ff1
03-16 17:02:10.812  9061  9262 F chromium: #08 0x9fe0ed63 /data/app/org.chromium.chrome-2/lib/arm/libbase.cr.so+0x000e3d63
03-16 17:02:10.812  9061  9262 F chromium: #09 0xb6cc745f /system/lib/libc.so+0x0003f45f
03-16 17:02:10.812  9061  9262 F chromium: #10 0xb6ca1b43 /system/lib/libc.so+0x00019b43
03-16 17:02:10.812  9061  9262 F chromium: #11 0xffffffff <unknown>
03-16 17:02:10.812  9061  9262 F chromium: 


It fails at a DCHECK https://cs.chromium.org/chromium/src/content/renderer/media/media_stream_audio_processor.cc?type=cs&q=media_stream_audio_processor&l=535.
This is a regression in revision #456677, cl https://codereview.chromium.org/2699113002.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0729944af28ece2d2a2c215de01ecc2dba29a7e3

commit 0729944af28ece2d2a2c215de01ecc2dba29a7e3
Author: aleloi <aleloi@chromium.org>
Date: Fri Jun 09 10:37:54 2017

Clean up DCHECKs in MediaStreamAudioProcessor

In http://crrev/2699113002, MediaStreamAudioProcessor was made to
always register itself as a WebRtcPlayoutDataSource::Sink in
AudioDeviceImpl, independently of doing echo cancellation or
not. DCHECKs were left in MediaStreamAudioProcessor::OnPlayoutData
that checked that echo cancellation was active. That is an invalid
assumption, because we always want to register the
MediaStreamAudioProcessor and run audio through
webrtc::AudioProcessingModule (which has other functionality but echo
cancellation, e.g. noise suppression or echo detection). The
assumption that echo cancellation is active is not used anywhere else
in the code.

This CL removes these DCHECKs.

BUG= 702441 

Review-Url: https://codereview.chromium.org/2932063002
Cr-Commit-Position: refs/heads/master@{#478241}

[modify] https://crrev.com/0729944af28ece2d2a2c215de01ecc2dba29a7e3/content/renderer/media/media_stream_audio_processor.cc

Comment 2 by aleloi@chromium.org, Jun 12 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment