New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

issue 699310
issue 701916

Sign in to add a comment

GN target //media/base/android:android should not be copied into multiple libraries

Project Member Reported by, Mar 16 2017 Back to list

Issue description

GN target //media/base/android:android is a source_set(), yet it is referenced in multiple places [1] [2]. This means when making a component build multiple copies of the same files get included in various different dlls.

I noticed this when debugging issues 699310 and 701916. There ended up being multiple copies of
    static MediaClientAndroid* g_media_client = nullptr;
and the actual code that needed to use it couldn't find the client.

//media/base/android:android should have limited visibility (only //media/base), and everything else should only depend of //media.


Comment 1 by, Mar 17 2017

Blocking: 699310

Comment 2 by, Mar 17 2017

This could also affect Android TV. Adding sanfin@ and yucliu@ FYI.
Blocking: 701916

Comment 4 by, Mar 18 2017

I tried a non-component build and it works fine. So this is not affecting official builds. 
Project Member

Comment 5 by, Mar 20 2017

The following revision refers to this bug:

commit 397905b7040fa1c0329d3675bcfd1120c04d7867
Author: jrummell <>
Date: Mon Mar 20 22:36:25 2017

Restrict use of GN target //media/base/android:android

As //media/base/android:android is a source_set, multiple targets referencing
it using DEPS result in multiple copies of the code being used when
is_component_build = true. Adding a visibility restriction to the target,
and changing all users to use //media (which should be the only target
including the code).

BUG= 702438 
TEST=gn check passes;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;

Cr-Commit-Position: refs/heads/master@{#458207}


Comment 6 by, Apr 10 2017

Is this fixed now?
Status: Fixed

Sign in to add a comment