62.0.3200.0 (Official Build) canary (64-bit) (cohort: 64-Bit)
Windows 10

The focus does not move to tabstrip. After focus on Omnibox, pressing shift+tab rotates through security chip, refresh, forward button, back button, settings, extensions, bookmarks, back to Omnibox. 

Note from Laura A: Progress was made on Mac side, but it progress has not been made on Windows for this. She was able to do this successfully. 

Unchecking Mac from this bug because Laura A confirmed it is fixed in 62.0.3202.0

Update from Laura E: 
Workaround: switch tabs using ctrl + tab to navigate through tabs, ctrl + w to close a tab. There is no workaround for opening the context menu on keyboard. 

Setting to p2 since this was found during our assessment

I think this is the same as 100412?

Also, see Mac version of this bug that's been fixed, https://bugs.chromium.org/p/chromium/issues/detail?id=699667

 Issue 100412  has been merged into this issue.

Google Chrome	70.0.3514.0 (Official Build) dev (64-bit) (cohort: Dev)
Win 10

Since there is no way to focus a tab using the keyboard, you can't invoke the context menu. Keyboard only users are unable to do the following on Chrome OS:

Duplicate
Pin tab
mute site
Close other tabs
Close tabs to the right

 Issue 873008  has been merged into this issue.

Reproduces on Chrome OS

Google Chrome	69.0.3497.35 (Official Build) dev (64-bit)
Firmware Version	Google_Lulu.6301.136.57

In latest Chrome for Windows, none of the toolbar buttons are reachable via tab either. Is this by design or a regression?

@21: I can reach the toolbar buttons via tab, when first using F6 to accessibility-focus the omnibox (then closing the dropdown via <esc> if ZeroSuggest opens it automatically).

I have a CL that makes tabs and the new tab button accessibility-focusable: https://chromium-review.googlesource.com/c/chromium/src/+/1241845

This allows the tab strip to be reached by shift+F6 from the omnibox, then tabs can be focused with TAB. It draws a focus ring around the focused tab.

Does this look good, or should it be polished more?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2635b23eeffa4713fdf2c540f704b3e1ed7eee7

commit c2635b23eeffa4713fdf2c540f704b3e1ed7eee7
Author: Collin Baker <collinbaker@chromium.org>
Date: Tue Oct 16 00:36:31 2018

Make tabs focusable and add focus ring

This allows tabs to be reached by the keyboard. Only tabs are made
focusable, not the tab close buttons since tabs can
be easily closed from the context menu.

This also makes the tabstrip as an accessible pane so it can be
reached by F6 and SHIFT+F6.

Follow-up changes:
- Look into having CTRL+W close the focused tab rather than the
  active tab when in keyboard accessibility mode.
- Make keyboard focus advance to the next tab when closing the
  focused tab (rather than disappearing as it does now).

Bug:  702414 
Change-Id: I052ac56a6adfbc317a67c00314fd9259ab83fc2e
Reviewed-on: https://chromium-review.googlesource.com/c/1241845
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599795}
[modify] https://crrev.com/c2635b23eeffa4713fdf2c540f704b3e1ed7eee7/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/c2635b23eeffa4713fdf2c540f704b3e1ed7eee7/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/c2635b23eeffa4713fdf2c540f704b3e1ed7eee7/chrome/browser/ui/views/tabs/tab.h
[modify] https://crrev.com/c2635b23eeffa4713fdf2c540f704b3e1ed7eee7/chrome/browser/ui/views/tabs/tab_close_button.cc
[modify] https://crrev.com/c2635b23eeffa4713fdf2c540f704b3e1ed7eee7/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/c2635b23eeffa4713fdf2c540f704b3e1ed7eee7/chrome/browser/ui/views/tabs/tab_style.cc
[modify] https://crrev.com/c2635b23eeffa4713fdf2c540f704b3e1ed7eee7/chrome/browser/ui/views/tabs/tab_style.h

Able to reproduce the issue on win-10 using chrome build without fix.

Tried testing the fix on win-10 and ubuntu 17.10 using chrome version #72.0.3582.0 as per comment #27 and #28.
Observed that on pressing SHIFT+F6, the focus got shifted to the tabstip from omnibox and on pressing TAB key, focus ring is drawn around the focused tab.
Attached a screen cast for reference.

collinbaker@ - Could you please check the attached screen cast and please help us in confirming the fix.

Thanks...!!

Deleted: 702414.mp4 282 KB

	702414.mp4 282 KB View Download

To clarify, 72.0.3582.0 is indeed the first version that contained the fix. I would not expect it to work in a prior version.

The video looks correct.

Things to test:
* Pressing Space on a tab should select it
* Pressing Space on a close button should close the tab, focus should go to something else nearby
* Pressing the Menu key on your keyboard, or alternatively Shift+F10, should open the context menu for the tab.
* If using a screen reader like NVDA, the text of tabs should be announced when focusing them

Open questions:
* Do Left/right arrow also move between tab?

Future work:
* How about Shift+arrows to select multiple tabs?
* How about other modifier keys to rearrange tabs or do other things with them - ideally there should be nothing you can do with the mouse you can't also accomplish with the keyboard

Updating the status since I forgot to do so before...

Currently, pressing space when a tab is focused doesn't select it. I'll address that in a follow-up change. As to the question: on my machine, the left/right arrows also move the focus.

Perhaps SHIFT+SPACE and CTRL+SPACE could be used for selecting multiple tabs, in line with SHIFT+Click and CTRL+Click?

Handling Space to select seems like the highest priority!

Shift+Space and Ctrl+Space to select a range of tabs sounds great.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c1b6e2d780e499d8798eed5b541f66f8486f38e

commit 2c1b6e2d780e499d8798eed5b541f66f8486f38e
Author: Collin Baker <collinbaker@chromium.org>
Date: Wed Oct 17 01:53:16 2018

Allow keyboard-focused tab to be selected with SPACE

Bug:  702414 
Change-Id: I0c4cc986a6a0cc5a823ba56426a66a9076546e7f
Reviewed-on: https://chromium-review.googlesource.com/c/1284440
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600236}
[modify] https://crrev.com/2c1b6e2d780e499d8798eed5b541f66f8486f38e/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/2c1b6e2d780e499d8798eed5b541f66f8486f38e/chrome/browser/ui/views/tabs/tab.h

Able to reproduce the issue on win-10 using chrome build without fix.

Tried testing the fix on win-10 and ubuntu 17.10 using chrome version #72.0.3584.0 as per comment #31 and #34. Below are the observations.
Observations:
=============
1. On pressing SHIFT+F6, the focus got shifted to the tabstip from omnibox and on pressing TAB key, focus ring is drawn around the focused tab.
2. On pressing space key allowed keyboard-focused tab to be selected.
3. On pressing left/right arrows moved the focus.
4. On pressing space on a close button closed the tab.
5. On pressing the Shift+F10 key opened the context menu for the tab.
6. Screen reader like NVDA, also announced the text of tabs when focusing them.
Attached a screen cast for reference.

collinbaker@ - Could you please check the attached screen cast and please help us in confirming the fix.

Thanks...!!

Deleted: 702414@M72.mp4 741 KB

	702414@M72.mp4 741 KB View Download

Please review this bug and switch status to Fixed if all that remains is verification.

Working on Win, Lin, CrOS.
Just needs to be verified on Mac.
collinbaker@ is on it.

With full keyboard access enabled, tabs are in the normal tab order on Mac. So the tab strip is reachable by keyboard on all platforms now.