New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 702412 link

Starred by 1 user
Status: Fixed
Owner:
█ kapishnikov@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Cc:
█ mge...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Update org/chromium/net/smoke/QuicTest.java

Project Member Reported by xunji...@chromium.org, Mar 16 2017 
org/chromium/net/smoke/QuicTest.java currently writes an unrecognized experimental option ("host_whitelist"). The test needs to be updated.

        JSONObject quicParams = new JSONObject().put("delay_tcp_race", true);
        JSONObject experimentalOptions = new JSONObject().put("QUIC", quicParams);
        mTestSupport.addHostResolverRules(experimentalOptions);
        experimentalOptions.put("host_whitelist", url.getHost());

"host_whitelist" should be a field in quicParams and not as a standalone experiment.

Comment 1 by kapishnikov@chromium.org, Apr 6 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48296219d472221d30d3a8cc4d03317ee2dd2851

commit 48296219d472221d30d3a8cc4d03317ee2dd2851
Author: kapishnikov <kapishnikov@chromium.org>
Date: Thu Apr 06 21:13:09 2017

"host_whitelist" QUIC parameter is deprecated starting from version 31 (see https://cs.chromium.org/chromium/src/net/http/http_stream_factory_impl_job_controller.cc?type=cs&q=%22The+QUIC+whitelist+is+not+needed+in+QUIC+versions+after+30.%22&l=913).

Removed the parameter from the Cronet tests but kept it in the Cronet implementation since there still may be servers that speak QUIC prior 31.

BUG= 702412 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2798403002
Cr-Commit-Position: refs/heads/master@{#462621}

[modify] https://crrev.com/48296219d472221d30d3a8cc4d03317ee2dd2851/components/cronet/android/test/javaperftests/src/org/chromium/net/CronetPerfTestActivity.java
[modify] https://crrev.com/48296219d472221d30d3a8cc4d03317ee2dd2851/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamQuicTest.java
[modify] https://crrev.com/48296219d472221d30d3a8cc4d03317ee2dd2851/components/cronet/android/test/javatests/src/org/chromium/net/PkpTest.java
[modify] https://crrev.com/48296219d472221d30d3a8cc4d03317ee2dd2851/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
[modify] https://crrev.com/48296219d472221d30d3a8cc4d03317ee2dd2851/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/QuicUploadTest.java
[modify] https://crrev.com/48296219d472221d30d3a8cc4d03317ee2dd2851/components/cronet/android/test/smoketests/src/org/chromium/net/smoke/QuicTest.java

Comment 3 by kapishnikov@chromium.org, Apr 6 2017

Status: Fixed (was: Started)
►

Sign in to add a comment