Separate/add more NetLogs for QuicStreamFactory::Job |
|||||||
Issue descriptionMost of QUIC logs are in QUIC_SESSION where QUIC session has already been created. Need to add more NetLogs so that we could connect from HttpStreamFactoryImpl::Job to QuicStreamFactory::Job. Currently QuicStreamFactory::Job events are logged in HTTP_STREAM_JOB if the HttpStreamFactiryImpl::Job(alt job) needs to create a new QuicStreamFactory::Job to serve the server id. It will be nicer to have separate QUIC_STREAM_FACTORY_JOB netlogs, connecting to those HTTP_STREAM_JOB which depends on this QUIC job so that if a HttpStreamFactiryImpl::Job(alt job) binds to an existing QUIC job, we might have QUIC job net log available. I did this for a instrumented build in order to help debug crbug.com/700617 and felt this might also be useful in the future.
,
Mar 17 2017
Changing to available to remove from the triager queue.
,
Mar 23 2017
,
Mar 23 2017
,
Mar 24 2017
,
Apr 5 2017
Cherie, do you think we can get this one in time for M59 cut? It will be nice to have some logging in case we run into this again in the new release.
,
Apr 5 2017
We should be, I will send out the CL for review ASAP.
,
Apr 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/069464ff67c5ba19b7a0aff04cd88cb646872d81 commit 069464ff67c5ba19b7a0aff04cd88cb646872d81 Author: zhongyi <zhongyi@chromium.org> Date: Thu Apr 06 19:53:37 2017 Add NetLog for HttpStreamFactoryImpl::Job::DoInitConnection so that if the connection initialization hangs NetLog will log the behavior. This will help investigate bugs similar to crbug.com/700617 in the future. BUG= 702411 Review-Url: https://codereview.chromium.org/2798243006 Cr-Commit-Position: refs/heads/master@{#462594} [modify] https://crrev.com/069464ff67c5ba19b7a0aff04cd88cb646872d81/net/http/http_stream_factory_impl_job.cc [modify] https://crrev.com/069464ff67c5ba19b7a0aff04cd88cb646872d81/net/log/net_log_event_type_list.h
,
Apr 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/96b7a82c70628fa03e8972668fe26310fc1e52ba commit 96b7a82c70628fa03e8972668fe26310fc1e52ba Author: zhongyi <zhongyi@chromium.org> Date: Fri Apr 07 22:37:11 2017 Create a separate NetLog source type QUIC_STREAM_FACTORY_JOB for each QuicStreamFactory::Job created. BUG= 702411 Review-Url: https://codereview.chromium.org/2800023002 Cr-Commit-Position: refs/heads/master@{#463023} [modify] https://crrev.com/96b7a82c70628fa03e8972668fe26310fc1e52ba/net/log/net_log_event_type_list.h [modify] https://crrev.com/96b7a82c70628fa03e8972668fe26310fc1e52ba/net/log/net_log_source_type_list.h [modify] https://crrev.com/96b7a82c70628fa03e8972668fe26310fc1e52ba/net/quic/chromium/quic_stream_factory.cc
,
Apr 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc46696ff2d37c43d4604cc2e996c8f2e3d2dcf0 commit fc46696ff2d37c43d4604cc2e996c8f2e3d2dcf0 Author: zhongyi <zhongyi@chromium.org> Date: Sat Apr 08 01:33:51 2017 Add QUIC_STREAM_FACTORY_JOB specific logs to track the Job's state machine. BUG= 702411 Review-Url: https://codereview.chromium.org/2806883002 Cr-Commit-Position: refs/heads/master@{#463099} [modify] https://crrev.com/fc46696ff2d37c43d4604cc2e996c8f2e3d2dcf0/net/log/net_log_event_type_list.h [modify] https://crrev.com/fc46696ff2d37c43d4604cc2e996c8f2e3d2dcf0/net/quic/chromium/quic_stream_factory.cc
,
Apr 10 2017
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/011ef8d97d0b06877ca4cfc621d2e56f19aeef8c commit 011ef8d97d0b06877ca4cfc621d2e56f19aeef8c Author: zhongyi <zhongyi@chromium.org> Date: Tue Apr 11 05:01:06 2017 Link NetLogs for HttpStreamFactoryImpl::Job and existing QuicStreamFactory::Job When HttpStreamFactoryImpl::Job init connection to QUIC server, in some cases, it might not result in QuicStreamFactory creating a new QuicStreamFactory::Job to serve the QuicRequest but use an exisitng QuicStreamFactory::Job. Link the HttpStreamFactoryImpl::Job and QuicStreamFactory::Job so that the HttpStreamFactoryImpl::Job::DoInitConnection is traceable. BUG= 702411 Review-Url: https://codereview.chromium.org/2811573003 Cr-Commit-Position: refs/heads/master@{#463536} [modify] https://crrev.com/011ef8d97d0b06877ca4cfc621d2e56f19aeef8c/net/quic/chromium/quic_stream_factory.cc
,
Apr 11 2017
With the new NetLogs added, we should be able to track QUIC connecting status for a HttpStreamFactoryImpl::Job. I am going to mark this as fixed.
,
Apr 12 2017
\o/ |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mmenke@chromium.org
, Mar 17 2017