Issue metadata
Sign in to add a comment
|
Mac Security Chip tooltip should not repeat Verbose State text |
||||||||||||||||||||||||||
Issue descriptionRepro: Hover over the Security Chip (bubble) at the left of the Omnibox on WashingtonPost.com Expect: Tooltip reads "View site information" Actual: Tooltip reads "The Washington Post (WP Company LLC) [US]. View site information" This was done in https://codereview.chromium.org/2407853002, as a fix for Issue 447191 . When I tried to port that change to Windows in Issue 692683 , I got shut down by the UX team who want to keep the current "View site information" tooltip and want the Mac code to use a different mechanism for changing the VoiceOver information for accessibility. [The VoiceOver text and the Tooltip can differ in Cocoa. Today we currently couple the Tooltip to VoiceOver because the current DecorationAccessibilityView implementation of accessibilityLabel just grabs the tooltip text for use in VoiceOver.]
,
Mar 27 2017
,
Apr 21 2017
,
Aug 3 2017
I'll try to get to this in the next two weeks.
,
Aug 4 2017
,
Aug 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d7b37d1258fd3a24d07ef745aa37747a3732650 commit 1d7b37d1258fd3a24d07ef745aa37747a3732650 Author: Elly Fong-Jones <ellyjones@google.com> Date: Fri Aug 04 20:04:42 2017 cocoa: add separate a11y label for security state decoration Right now, the tooltip for this repeats the text of the decoration. The text only really should be repeated in the a11y label, so this change gives SecurityStateBubbleDecoration a separate a11y label and makes the tooltip just the "view site information" text. Bug: 702406 Change-Id: Iff75abd59b558c1c71a02fecb508629132a4e63e Reviewed-on: https://chromium-review.googlesource.com/602528 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#492110} [modify] https://crrev.com/1d7b37d1258fd3a24d07ef745aa37747a3732650/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.h [modify] https://crrev.com/1d7b37d1258fd3a24d07ef745aa37747a3732650/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm
,
Aug 7 2017
,
Aug 8 2017
Tested this issue on Mac 10.12.6 using latest Dev#62.0.3178.0. Steps followed: -------------- 1. Voice over is ON 2. Launch chrome 3. Navigate to WashingtonPost.com site 4. Hover over 'secure' Observations: ------------ 1. Tooltip displayed as "View site information" at the left of the Omnibox which is as intended (Comment#0) 2. Observed that voice over is reading only the popup messages but not the tooltips. Please let us know if we miss anything from our end. Thanks.
,
Aug 8 2017
#8: I believe that is correct.
,
Aug 18 2017
The NextAction date has arrived: 2017-08-18
,
Aug 18 2017
|
|||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||
Comment 1 by elawrence@chromium.org
, Mar 16 2017