New issue
Advanced search Search tips

Issue 702386 link

Starred by 1 user
Status: Assigned
Owner:
vmp...@chromium.org
Cc:
pdr@chromium.org
enne@chromium.org
khushals...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Replace SkImage with PaintImage on PaintCanvas.

Project Member Reported by khushals...@chromium.org, Mar 16 2017 
Checker-imaging in cc requires more information from blink that is not captured through an SkImage. For instance, we need to know if it is an animated image. We need a stable identifier for a progressive image, instead of the current path where each image update has blink painting with a new SkImage.

The first step is having all cc/paint clients use a PaintImage instead of SkImage, and then plumbing the data via PaintImage from the correct places in blink.

Comment 1 by khushals...@chromium.org, Apr 7 2017

Cc: -vmp...@chromium.org khushals...@chromium.org
Owner: vmp...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94cfa88dd9922d14e7b08544b3b9710fc53ea94c

commit 94cfa88dd9922d14e7b08544b3b9710fc53ea94c
Author: vmpstr <vmpstr@chromium.org>
Date: Fri Apr 14 01:19:35 2017

paint: Introduce PaintImage that wraps SkImage in paint calls.

This patch introduces a PaintImage object that wraps an SkImage for the
purposes of paint. It also introduces two states:
AnimationType - indicates whether the image is animated (ie this is a
                single frame of a larger stack of images)
CompletionState - indicates whether this image is fully loaded.

R=enne@chromium.org, khushalsagar@chromium.org
BUG=702386
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2812763002
Cr-Commit-Position: refs/heads/master@{#464643}

[modify] https://crrev.com/94cfa88dd9922d14e7b08544b3b9710fc53ea94c/cc/layers/picture_image_layer.cc
[modify] https://crrev.com/94cfa88dd9922d14e7b08544b3b9710fc53ea94c/cc/paint/BUILD.gn
[modify] https://crrev.com/94cfa88dd9922d14e7b08544b3b9710fc53ea94c/cc/paint/paint_canvas.h
[add] https://crrev.com/94cfa88dd9922d14e7b08544b3b9710fc53ea94c/cc/paint/paint_image.cc
[add] https://crrev.com/94cfa88dd9922d14e7b08544b3b9710fc53ea94c/cc/paint/paint_image.h
[modify] https://crrev.com/94cfa88dd9922d14e7b08544b3b9710fc53ea94c/cc/paint/skia_paint_canvas.cc
[modify] https://crrev.com/94cfa88dd9922d14e7b08544b3b9710fc53ea94c/cc/paint/skia_paint_canvas.h
[modify] https://crrev.com/94cfa88dd9922d14e7b08544b3b9710fc53ea94c/cc/test/fake_content_layer_client.cc
[modify] https://crrev.com/94cfa88dd9922d14e7b08544b3b9710fc53ea94c/media/renderers/skcanvas_video_renderer.cc
[modify] https://crrev.com/94cfa88dd9922d14e7b08544b3b9710fc53ea94c/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp
[modify] https://crrev.com/94cfa88dd9922d14e7b08544b3b9710fc53ea94c/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp
[modify] https://crrev.com/94cfa88dd9922d14e7b08544b3b9710fc53ea94c/third_party/WebKit/Source/platform/graphics/Image.cpp
[modify] https://crrev.com/94cfa88dd9922d14e7b08544b3b9710fc53ea94c/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp
[modify] https://crrev.com/94cfa88dd9922d14e7b08544b3b9710fc53ea94c/third_party/WebKit/Source/platform/graphics/StaticBitmapImage.cpp
[add] https://crrev.com/94cfa88dd9922d14e7b08544b3b9710fc53ea94c/third_party/WebKit/Source/platform/graphics/paint/PaintImage.h
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d525c83dc997c24ecd618d45c2d932cd2e7feccc

commit d525c83dc997c24ecd618d45c2d932cd2e7feccc
Author: khushalsagar <khushalsagar@chromium.org>
Date: Fri Apr 14 02:09:04 2017

cc: Use an enum for tracking images vetoed for async decodes.

This adds an option for permanent vetoes to come from blink.

BUG=702386
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2817473002
Cr-Commit-Position: refs/heads/master@{#464656}

[modify] https://crrev.com/d525c83dc997c24ecd618d45c2d932cd2e7feccc/cc/tiles/checker_image_tracker.cc
[modify] https://crrev.com/d525c83dc997c24ecd618d45c2d932cd2e7feccc/cc/tiles/checker_image_tracker.h
►

Sign in to add a comment