New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702384 link

Starred by 18 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 694547
issue 728451


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Tracking bug: DevTools protocol Interception, Blocking and Modification of network requests

Project Member Reported by alexclarke@chromium.org, Mar 16 2017

Issue description

As described in this design doc, we'd like to build devtools support for interception, blocking and modification of network requests. 

https://docs.google.com/document/d/1nEN0SqC1jEpHgKuQPrppwSabC8JRAuJb7MSTGCe2Pzg/edit#
 
Components: Internals>Headless
Blocking: 728451
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f5b3053ff11488b985c18e8d03472356e049fd5

commit 6f5b3053ff11488b985c18e8d03472356e049fd5
Author: alexclarke <alexclarke@chromium.org>
Date: Fri Jun 02 14:32:30 2017

DevTools protocol interception, blocking & modification of requests

Adds Network.enableFetchInterception which sends Network.interceptedRequest for fetch requests and Network.interceptedRedirect for any redirects.  The fetch or redirect
is paused until one of the following commands is sent: Network.allowRequest, Network.blockRequest, Network.mockResponse, Network.modifyRequest.

Design doc: https://docs.google.com/document/d/1nEN0SqC1jEpHgKuQPrppwSabC8JRAuJb7MSTGCe2Pzg/edit#

BUG= 702384 ,  546953 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2739323003
Cr-Commit-Position: refs/heads/master@{#476635}

[modify] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/content/browser/BUILD.gn
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/content/browser/devtools/devtools_url_interceptor_request_job.cc
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/content/browser/devtools/devtools_url_interceptor_request_job.h
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/content/browser/devtools/devtools_url_request_interceptor.cc
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/content/browser/devtools/devtools_url_request_interceptor.h
[modify] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/content/browser/devtools/protocol_config.json
[modify] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/content/browser/storage_partition_impl_map.cc
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/disable-interception-midway-expected.txt
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/disable-interception-midway.html
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-test.js
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/navigation-interception-expected.txt
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/navigation-interception.html
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/redirect-interception-blocked-expected.txt
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/redirect-interception-blocked.html
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/redirect-interception-expected.txt
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/redirect-interception-mocked-expected.txt
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/redirect-interception-mocked.html
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/redirect-interception-modified-expected.txt
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/redirect-interception-modified.html
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/redirect-interception.html
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-expected.txt
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-mock302-expected.txt
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-mock302.html
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-mock404-expected.txt
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-mock404.html
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-modify-get-to-post-expected.txt
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-modify-get-to-post.html
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception.html
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/alternative.js
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/final.js
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/post-echo.pl
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/redirect-iframe.html
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/redirect1.pl
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/redirect2.pl
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/redirect3.pl
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/resource-iframe.html
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/test.css
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/unauthorised.pl
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/xhr-iframe-auth-fail.html
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/xhr-iframe.html
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/xhr-interception-auth-fail-expected.txt
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/xhr-interception-auth-fail.html
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/xhr-interception-expected.txt
[add] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/xhr-interception.html
[modify] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/Source/core/inspector/inspector_protocol_config.json
[modify] https://crrev.com/6f5b3053ff11488b985c18e8d03472356e049fd5/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6789fd15af2f0d4505f3460134885e29a0a0b60b

commit 6789fd15af2f0d4505f3460134885e29a0a0b60b
Author: Alex Clarke <alexclarke@chromium.org>
Date: Wed Jun 07 10:52:40 2017

Exposes the resource type of an intercepted resource

This provides a convenient way to (for example) filter out all image or
media requests.

Bug:  702384 
Change-Id: I0b73d2fa63a6c504f686a86e8bba970ef2fec95b
Reviewed-on: https://chromium-review.googlesource.com/525552
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477607}
[modify] https://crrev.com/6789fd15af2f0d4505f3460134885e29a0a0b60b/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/6789fd15af2f0d4505f3460134885e29a0a0b60b/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/6789fd15af2f0d4505f3460134885e29a0a0b60b/content/browser/devtools/devtools_url_request_interceptor.cc
[modify] https://crrev.com/6789fd15af2f0d4505f3460134885e29a0a0b60b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/disable-interception-midway-expected.txt
[modify] https://crrev.com/6789fd15af2f0d4505f3460134885e29a0a0b60b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-test.js
[modify] https://crrev.com/6789fd15af2f0d4505f3460134885e29a0a0b60b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/navigation-interception-expected.txt
[modify] https://crrev.com/6789fd15af2f0d4505f3460134885e29a0a0b60b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/redirect-interception-blocked-expected.txt
[modify] https://crrev.com/6789fd15af2f0d4505f3460134885e29a0a0b60b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/redirect-interception-expected.txt
[modify] https://crrev.com/6789fd15af2f0d4505f3460134885e29a0a0b60b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/redirect-interception-mocked-expected.txt
[modify] https://crrev.com/6789fd15af2f0d4505f3460134885e29a0a0b60b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/redirect-interception-modified-expected.txt
[modify] https://crrev.com/6789fd15af2f0d4505f3460134885e29a0a0b60b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-expected.txt
[modify] https://crrev.com/6789fd15af2f0d4505f3460134885e29a0a0b60b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-mock302-expected.txt
[modify] https://crrev.com/6789fd15af2f0d4505f3460134885e29a0a0b60b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-mock404-expected.txt
[modify] https://crrev.com/6789fd15af2f0d4505f3460134885e29a0a0b60b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-modify-get-to-post-expected.txt
[modify] https://crrev.com/6789fd15af2f0d4505f3460134885e29a0a0b60b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/xhr-interception-auth-fail-expected.txt
[modify] https://crrev.com/6789fd15af2f0d4505f3460134885e29a0a0b60b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/xhr-interception-expected.txt
[modify] https://crrev.com/6789fd15af2f0d4505f3460134885e29a0a0b60b/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/6789fd15af2f0d4505f3460134885e29a0a0b60b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29e207dd862ae4f4ebf24a81b7e7634e213be7c2

commit 29e207dd862ae4f4ebf24a81b7e7634e213be7c2
Author: Alex Clarke <alexclarke@chromium.org>
Date: Wed Jun 14 08:18:23 2017

Fix typo in continueInterceptedRequest
The interceptionId paramater should start with a lower case i.

Bug:  732697 ,  702384 
Change-Id: Iaee18b918baf8551ad8d5005f99ddb8cab2fbf2e
Reviewed-on: https://chromium-review.googlesource.com/532996
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479325}
[modify] https://crrev.com/29e207dd862ae4f4ebf24a81b7e7634e213be7c2/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-test.js
[modify] https://crrev.com/29e207dd862ae4f4ebf24a81b7e7634e213be7c2/third_party/WebKit/Source/core/inspector/browser_protocol.json

Network.requestIntercepted doesn't fire on the Linux dev build - 61.0.3128.3 (but works on the same version on Mac). Are you able to replicate this?
No, it works on for linux for me.  I'd need more details to try and understand what's gone wrong.
@Alex,

Here's my test code - https://pastebin.com/raw/BSEHbvWS

This works in Mac, but not on Linux. FWIW, when testing for Linux, I run it inside Docker.
Project Member

Comment 9 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4640aeaa9e5e64220d4344e619d6d3ab92023df1

commit 4640aeaa9e5e64220d4344e619d6d3ab92023df1
Author: Alex Clarke <alexclarke@chromium.org>
Date: Fri Jun 16 10:01:07 2017

Allow Auth Credentials to be passed over DevTools protocol

When Network request interception is turned on and we intercept a 401 or 407
we now give the protocol user a chance to either provide the credentials,
cancel the auth request, or fall back to the default implementation (likely
canceling the auth, or possibly displaying a dialog box).

Bug:  729525 ,  702384 
Change-Id: I8e7c92a0f44a07a30767a2f2076b0feb1c9c2bed
Reviewed-on: https://chromium-review.googlesource.com/535695
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480005}
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/content/browser/devtools/devtools_url_request_interceptor.cc
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/content/browser/devtools/devtools_url_request_interceptor.h
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/content/browser/devtools/protocol_config.json
[add] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-auth-cancel-expected.txt
[add] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-auth-cancel.html
[add] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-auth-provide-credentials-expected.txt
[add] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-auth-provide-credentials.html
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/interception-test.js
[add] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/.htaccess
[add] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/iframe-auth-js.html
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/unauthorised.pl
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/xhr-interception-auth-fail-expected.txt
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/xhr-interception-auth-fail.html
[modify] https://crrev.com/4640aeaa9e5e64220d4344e619d6d3ab92023df1/third_party/WebKit/Source/core/inspector/browser_protocol.json

Re #8 perhaps the problems you're experiencing are due to running in the docker container? This feature was developed on desktop linux and I can't see any general reason why it should work on mac but not on linux.

Comment 11 Deleted

I finally got my hands on a Linux box, and this is super-weird, but I can confirm that it doesn't work *only* inside Docker!
Thanks for that, very odd. We would like this to work from within a Docker container.  I can't promise a time scale but we'll try and investigate.
@Alex

Okay so I tried this on a hunch - I installed wireshark and interception works now!!

Can you tell which of these is being used by Chrome for interception? This paste contains the list of all dependencies for Wireshark 2.2.6 on Ubuntu Xenial.

https://pastebin.com/wJE3ZtP1
 Issue 732154  has been merged into this issue.
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da8c2648e0f8b5779ab1e2546bb27ac12be60e6c

commit da8c2648e0f8b5779ab1e2546bb27ac12be60e6c
Author: Alex Clarke <alexclarke@chromium.org>
Date: Thu Jun 29 16:08:23 2017

Make headless::Request::GetFrameTreeNodeId work with interception

A number of systems including headless::Request::GetFrameTreeNodeId
expect net::URLRequests to have ResourceRequestInfo. This patch
associates a copy of the parent resource's ResourceRequestInfoImpl
with the DevToolsURLInterceptorRequestJob::SubRequest.

Bug:  702384 
Change-Id: I168d9060a76af0e96ffae7297e464dcfecce150a
Reviewed-on: https://chromium-review.googlesource.com/551898
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483377}
[modify] https://crrev.com/da8c2648e0f8b5779ab1e2546bb27ac12be60e6c/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/da8c2648e0f8b5779ab1e2546bb27ac12be60e6c/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/da8c2648e0f8b5779ab1e2546bb27ac12be60e6c/headless/lib/frame_id_browsertest.cc

Owner: alexclarke@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f85ffa8e9d1834d5cc527521edf089211b08f04b

commit f85ffa8e9d1834d5cc527521edf089211b08f04b
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Aug 01 08:12:20 2017

[DevTools] Merge navigations control into requests interception

Bug:  546953 ,  702384 
Change-Id: I73460b641d4083d615dfffb284aee8fd9cd1cdd7
Reviewed-on: https://chromium-review.googlesource.com/590348
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490912}
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/content/browser/BUILD.gn
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/content/browser/devtools/devtools_url_interceptor_request_job.cc
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/content/browser/devtools/devtools_url_interceptor_request_job.h
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/content/browser/devtools/devtools_url_request_interceptor.cc
[delete] https://crrev.com/27e058389d2e581df6299b630b4ead0028cdc29a/content/browser/devtools/page_navigation_throttle.cc
[delete] https://crrev.com/27e058389d2e581df6299b630b4ead0028cdc29a/content/browser/devtools/page_navigation_throttle.h
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/content/browser/devtools/protocol/page_handler.h
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/content/browser/devtools/protocol_config.json
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/headless/app/headless_shell.cc
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/headless/app/headless_shell.h
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/headless/app/shell_navigation_request.cc
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/headless/app/shell_navigation_request.h
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/headless/lib/headless_devtools_client_browsertest.cc
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/headless/public/util/navigation_request.h
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/third_party/WebKit/Source/core/inspector/browser_protocol-1.2.json
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
[modify] https://crrev.com/f85ffa8e9d1834d5cc527521edf089211b08f04b/third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js

Project Member

Comment 19 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fd9cc03dc6623f5988e29bf49eb407bc2655249

commit 8fd9cc03dc6623f5988e29bf49eb407bc2655249
Author: Matt Menke <mmenke@chromium.org>
Date: Tue Aug 01 17:16:40 2017

Add a pair of suppressions tests using the network service.

In particular, DevToolsProtocolTest.ControlNavigationsMainFrame and
IsolatedDevToolsProtocolTest.ControlNavigationsChildFrames are now
failing, likely as a result of
https://chromium-review.googlesource.com/c/590348

TBR=rdsmith@chromium.org
NOTRY=true

Bug:  546953 ,  702384 
Change-Id: I1b49e35e4519951111acd8c77853c78998da2846
Reviewed-on: https://chromium-review.googlesource.com/596248
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491030}
[modify] https://crrev.com/8fd9cc03dc6623f5988e29bf49eb407bc2655249/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Project Member

Comment 20 by bugdroid1@chromium.org, Aug 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/241c6b4df3f4c0b93d783ed2b5b8b448e4e2d285

commit 241c6b4df3f4c0b93d783ed2b5b8b448e4e2d285
Author: Nathan Bruer <allada@chromium.org>
Date: Fri Aug 25 15:40:12 2017

[Devtools] Request interception will now forwards based on patterns.

Changed protocol to now use pattern matching to forward only requests
that match a pattern provided over protocol instead of all requests.
This should increase the stalled speed a bit.

R=dgozman,caseq,pfeldman
BUG= 752617 , 702384 , 694547 

Change-Id: I4df44475023c9d275bb6818f4270620945d0c7bd
Reviewed-on: https://chromium-review.googlesource.com/602483
Commit-Queue: Blaise Bruer <allada@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497419}
[modify] https://crrev.com/241c6b4df3f4c0b93d783ed2b5b8b448e4e2d285/content/browser/devtools/devtools_url_request_interceptor.cc
[modify] https://crrev.com/241c6b4df3f4c0b93d783ed2b5b8b448e4e2d285/content/browser/devtools/devtools_url_request_interceptor.h
[modify] https://crrev.com/241c6b4df3f4c0b93d783ed2b5b8b448e4e2d285/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/241c6b4df3f4c0b93d783ed2b5b8b448e4e2d285/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/241c6b4df3f4c0b93d783ed2b5b8b448e4e2d285/content/public/test/test_browser_context.cc
[modify] https://crrev.com/241c6b4df3f4c0b93d783ed2b5b8b448e4e2d285/content/public/test/test_browser_context.h
[add] https://crrev.com/241c6b4df3f4c0b93d783ed2b5b8b448e4e2d285/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-patterns-expected.txt
[add] https://crrev.com/241c6b4df3f4c0b93d783ed2b5b8b448e4e2d285/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/request-interception-patterns.js
[add] https://crrev.com/241c6b4df3f4c0b93d783ed2b5b8b448e4e2d285/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/small-test-1.txt
[add] https://crrev.com/241c6b4df3f4c0b93d783ed2b5b8b448e4e2d285/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/resources/small-test-2.txt
[modify] https://crrev.com/241c6b4df3f4c0b93d783ed2b5b8b448e4e2d285/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/241c6b4df3f4c0b93d783ed2b5b8b448e4e2d285/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

Status: Fixed (was: Started)

Sign in to add a comment