HTTP Authentication should not call DidSuppressDialog WebStateObserver callback |
||
Issue descriptionweb layer should not make assumptions that chrome handles HTTP Authentication by showing the dialog.
,
Mar 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/862085fdce1bb084ad57e893e1068a739546122d commit 862085fdce1bb084ad57e893e1068a739546122d Author: eugenebut <eugenebut@chromium.org> Date: Tue Mar 28 16:47:42 2017 Do not suppress HTTP Authenticaiton in WebController. web layer should not make assumptions that chrome handles HTTP Authentication by showing the dialog. So even if |shouldSuppressDialogs| value is set to YES, CRWWebController still should ask the delegate to handle HTTP Authentication. BUG= 702381 Review-Url: https://codereview.chromium.org/2772723006 Cr-Commit-Position: refs/heads/master@{#460130} [modify] https://crrev.com/862085fdce1bb084ad57e893e1068a739546122d/ios/chrome/browser/tabs/tab.h [modify] https://crrev.com/862085fdce1bb084ad57e893e1068a739546122d/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/862085fdce1bb084ad57e893e1068a739546122d/ios/web/web_state/ui/crw_web_controller.mm
,
Mar 28 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by eugene...@chromium.org
, Mar 24 2017