New issue
Advanced search Search tips

Issue 702381 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature



Sign in to add a comment

HTTP Authentication should not call DidSuppressDialog WebStateObserver callback

Project Member Reported by eugene...@chromium.org, Mar 16 2017

Issue description

web layer should not make assumptions that chrome handles HTTP Authentication by showing the dialog.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/862085fdce1bb084ad57e893e1068a739546122d

commit 862085fdce1bb084ad57e893e1068a739546122d
Author: eugenebut <eugenebut@chromium.org>
Date: Tue Mar 28 16:47:42 2017

Do not suppress HTTP Authenticaiton in WebController.

web layer should not make assumptions that chrome handles HTTP
Authentication by showing the dialog. So even if |shouldSuppressDialogs|
value is set to YES, CRWWebController still should ask the delegate to
handle HTTP Authentication.

BUG= 702381 

Review-Url: https://codereview.chromium.org/2772723006
Cr-Commit-Position: refs/heads/master@{#460130}

[modify] https://crrev.com/862085fdce1bb084ad57e893e1068a739546122d/ios/chrome/browser/tabs/tab.h
[modify] https://crrev.com/862085fdce1bb084ad57e893e1068a739546122d/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/862085fdce1bb084ad57e893e1068a739546122d/ios/web/web_state/ui/crw_web_controller.mm

Status: Fixed (was: Started)

Sign in to add a comment