New issue
Advanced search Search tips

Issue 702353 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Task

Blocking:
issue 674317



Sign in to add a comment

[CompositeAfterPaint] transition animation in iframe doesn't start

Project Member Reported by wkorman@chromium.org, Mar 16 2017

Issue description

transitions/transition-end-event-destroy-iframe.html

With SPv2 enabled, this test's iframe html adds a transitionEnd listener on box1, then sets a translate transform on box1, and the listener is never called.

Test's purpose per its opening text is:

Tests element removal and hiding in webkitTransitionEnd event handler. Should not crash.
 
Labels: BugSource-Team PaintTeamTriaged-20170316
virtual/threaded/transitions/extra-transition.html looks like the same issue.
Labels: -Type-Bug Type-Task
Owner: ----
Status: Available (was: Started)
Still in SPv2 expectations file.
Project Member

Comment 5 by sheriffbot@chromium.org, Dec 7

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
Components: Blink>Animation
Summary: SPv2: transition animation in iframe doesn't start (was: SPv2: iframe transition layout test transitionEnd listener never called.)
Tested in content_shell, and saw that the animation in iframe didn't start. The animation will start if I open the iframe's inner document directly in content_shell.
Cc: flackr@chromium.org pdr@chromium.org
Summary: [CompositeAfterPaint] transition animation in iframe doesn't start (was: SPv2: transition animation in iframe doesn't start)
The animation just doesn't start with CAP:

<iframe srcdoc="
  <div id='target' style='width: 100px; height: 100px; background: blue; transition: transform 2s'></div>
  <script>
    onload = function() { target.style.transform = 'translate(100px, 0)'; };
  </script>"
</iframe>

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5af1abbbe19b919a32abe86ba0827ffb4250ff1

commit f5af1abbbe19b919a32abe86ba0827ffb4250ff1
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Dec 11 16:44:00 2018

[CompositeAfterPaint] Ensure animation timeline is attached to host

We need to attach the document animation timeline to the animation host
to make animations work. In pre-CompositeAfterPaint, this is done from
PaintLayerCompositor.

For CompositeAfterPaint, attach animation timeline from
Document::Initialize() and WebLocalFrameImpl::SetFrameWidget().

Bug:  702353 
Change-Id: I5e19add5196e5b52ebcade42b58e336051b111e6
Reviewed-on: https://chromium-review.googlesource.com/c/1368994
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615554}
[modify] https://crrev.com/f5af1abbbe19b919a32abe86ba0827ffb4250ff1/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/f5af1abbbe19b919a32abe86ba0827ffb4250ff1/third_party/blink/renderer/core/dom/document.h
[modify] https://crrev.com/f5af1abbbe19b919a32abe86ba0827ffb4250ff1/third_party/blink/renderer/core/frame/web_local_frame_impl.cc
[modify] https://crrev.com/f5af1abbbe19b919a32abe86ba0827ffb4250ff1/third_party/blink/renderer/core/page/chrome_client_impl.cc
[modify] https://crrev.com/f5af1abbbe19b919a32abe86ba0827ffb4250ff1/third_party/blink/web_tests/FlagExpectations/enable-blink-features=CompositeAfterPaint

Status: Fixed (was: Assigned)

Sign in to add a comment