New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702329 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 700956
Owner: ----
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

"TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 16 2017

Issue description

"TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUwsSBUZsYWtlIkhUZXh0dXJlTGF5ZXJDaGFuZ2VJbnZpc2libGVNYWlsYm94VGVzdC5SdW5NdWx0aVRocmVhZF9EZWxlZ2F0aW5nUmVuZGVyZXIM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Components: Internals>Compositing
Status: Available (was: Untriaged)
This test frequently fail on win, mac, linux and android:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=cc_unittests (with patch)&tests=TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer

Sample output:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/410871

[ RUN      ] TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer
../../cc/layers/texture_layer_unittest.cc:1195: Failure
Value of: 5
Expected: commit_count_
Which is: 4
[  FAILED  ] TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer (21 ms)
Labels: OS-Android OS-Linux OS-Mac OS-Windows
I'm now landing a patch to disable the test:
https://codereview.chromium.org/2756853002/
Labels: -Sheriff-Chromium
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2ef1195d4f15d4a589110dd682baaa1174225b8

commit a2ef1195d4f15d4a589110dd682baaa1174225b8
Author: nhiroki <nhiroki@chromium.org>
Date: Fri Mar 17 05:40:23 2017

Disable flaky TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer

BUG= 702329 
TBR=enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2756853002
Cr-Commit-Position: refs/heads/master@{#457697}

[modify] https://crrev.com/a2ef1195d4f15d4a589110dd682baaa1174225b8/cc/test/layer_tree_test.h

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47d64d328b84b893246a65264781df243d428ae6

commit 47d64d328b84b893246a65264781df243d428ae6
Author: danakj <danakj@chromium.org>
Date: Fri Mar 17 14:01:12 2017

Revert of Disable flaky TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer (patchset #2 id:20001 of https://codereview.chromium.org/2756853002/ )

Reason for revert:
Disables half of cc unittests, this is of course not good.

Original issue's description:
> Disable flaky TextureLayerChangeInvisibleMailboxTest.RunMultiThread_DelegatingRenderer
>
> BUG= 702329 
> TBR=enne@chromium.org
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
>
> Review-Url: https://codereview.chromium.org/2756853002
> Cr-Commit-Position: refs/heads/master@{#457697}
> Committed: https://chromium.googlesource.com/chromium/src/+/a2ef1195d4f15d4a589110dd682baaa1174225b8

TBR=enne@chromium.org,nhiroki@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 702329 

Review-Url: https://codereview.chromium.org/2761483002
Cr-Commit-Position: refs/heads/master@{#457756}

[modify] https://crrev.com/47d64d328b84b893246a65264781df243d428ae6/cc/test/layer_tree_test.h

Comment 7 by danakj@chromium.org, Mar 17 2017

Cc: danakj@chromium.org fsam...@chromium.org piman@chromium.org enne@chromium.org
This test was written by piman a long time ago. Someone else has made it flaky more recently with some other system change I guess.

Comment 8 by danakj@chromium.org, Mar 17 2017

Mergedinto: 700956
Status: Duplicate (was: Available)

Sign in to add a comment