New issue
Advanced search Search tips

Issue 702318 link

Starred by 1 user
Status: Fixed
Owner:
altimin@chromium.org
Closed: May 2018
Cc:
skyos...@chromium.org
gab@chromium.org
haraken@chromium.org
altimin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 702314
issue 762453

Show other hotlists

Hotlists containing this issue:
TaskThrottling


Sign in to add a comment

Report total duration of tasks split per task type

Project Member Reported by altimin@chromium.org, Mar 16 2017 
As a development of reporting task duration per queue type, split it further — per task type (see TaskType from TaskRunnerHelper [1]. It needs to be exposed to other parts of codebase, probably by moving to base).


Difficulty here is to plumb metadata about a task through all layers. Most likely it will involve changing base::PendingTask or base::TaskTraits (or will involve some other form of integration with Lucky Luke).

[1]https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/dom/TaskRunnerHelper.h?q=TaskRunnerHelper&dr=CSs&l=20

Comment 1 by altimin@chromium.org, Mar 16 2017

Components: Blink>Scheduling
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0edf4370be6dfc4296c645a7482a9518d74d9e43

commit 0edf4370be6dfc4296c645a7482a9518d74d9e43
Author: Alexander Timin <altimin@chromium.org>
Date: Mon Jul 17 17:01:03 2017

[scheduler] Plumb task reference to RendererScheduler::OnTaskCompleted.

Make renderer scheduler aware of a completed task. This will enable
us to record per-task metrics.

R=alexclarke@chromium.org
BUG= 702318 

Change-Id: Iaff9ca2c8f8398847c854dfc569db90176cdb7c6
Reviewed-on: https://chromium-review.googlesource.com/574538
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487126}
[modify] https://crrev.com/0edf4370be6dfc4296c645a7482a9518d74d9e43/third_party/WebKit/Source/platform/scheduler/base/task_queue.cc
[modify] https://crrev.com/0edf4370be6dfc4296c645a7482a9518d74d9e43/third_party/WebKit/Source/platform/scheduler/base/task_queue.h
[modify] https://crrev.com/0edf4370be6dfc4296c645a7482a9518d74d9e43/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/0edf4370be6dfc4296c645a7482a9518d74d9e43/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h
[modify] https://crrev.com/0edf4370be6dfc4296c645a7482a9518d74d9e43/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
[modify] https://crrev.com/0edf4370be6dfc4296c645a7482a9518d74d9e43/third_party/WebKit/Source/platform/scheduler/renderer/main_thread_task_queue.cc
[modify] https://crrev.com/0edf4370be6dfc4296c645a7482a9518d74d9e43/third_party/WebKit/Source/platform/scheduler/renderer/main_thread_task_queue.h
[modify] https://crrev.com/0edf4370be6dfc4296c645a7482a9518d74d9e43/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/0edf4370be6dfc4296c645a7482a9518d74d9e43/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h

Comment 3 by altimin@chromium.org, Sep 6 2017

Blockedon: 762453

Comment 4 by altimin@chromium.org, May 23 2018

Status: Fixed (was: Available)
We now have RendererScheduler.TaskDurationPerTaskType metrics.
►

Sign in to add a comment