> We should make sure that devices with invalid vpd do not cause crashes...

I can't agree with that. We cannot have global default here, so if VPD is incorrect, I think we'd better crash.

Making sure that VPD entries are correct by crashing, seems like a horrible user experience. I understand writing out error logs, but crashing seems, excessive.

Albert what is your opinion here?

BTW, I don't think we need to ensure that 'all' VPD entries are valid. We just should make sure that if a piece of code is parsing data coming from an external source (wherever it comes from, VPD, Network, anywhere), shouldn't crash if the data isn't as expected. Our code should be more fault tolerant than that.

So I would suggest adding test cases to issues we fix, not a general 'is VPD data correct' test case.

Well, we can have some default here, but it will make debugging more difficult. Because we'll start getting issues like "I cannot log in".