Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 702316 Move Android's ChildProcessLauncher from content/ to base/
Starred by 1 user Project Member Reported by jcivelli@chromium.org, Mar 16 Back to list
Status: Untriaged
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment
This bug tracks the effort for moving ChildProcessLauncher on Android to base/.
Some of the motivations:
- base/test/android uses MultiprocessTestClientLauncher which duplicates what's done in ChildProcessLauncher. It could use ChildProcessLauncher when it's moved to base.
- as part of the servicification effort the Mojo service manager will be used to start all child processes and cannot depend on content/
 
Cc: yfried...@chromium.org mariakhomenko@chromium.org agrieve@chromium.org
Labels: OS-Android
will pull out things that don't belong in base, and then move pieces when they no longer depend on things in content. no code duplication here. semi-orthogonal to all the refactor stuff I want to do.
Project Member Comment 2 by bugdroid1@chromium.org, Mar 17
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9796a271448f237118bbc54316c664a678ada68b

commit 9796a271448f237118bbc54316c664a678ada68b
Author: jcivelli <jcivelli@chromium.org>
Date: Fri Mar 17 03:45:11 2017

Abstracting parameters passed to child processes on Android.

Making the parameters passed to a child process part of a Bundle as part
of the effort to move child process launcher code to base/.

BUG=702316

Review-Url: https://codereview.chromium.org/2756053002
Cr-Commit-Position: refs/heads/master@{#457679}

[modify] https://crrev.com/9796a271448f237118bbc54316c664a678ada68b/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
[modify] https://crrev.com/9796a271448f237118bbc54316c664a678ada68b/content/public/android/java/src/org/chromium/content/app/ChromiumLinkerParams.java
[modify] https://crrev.com/9796a271448f237118bbc54316c664a678ada68b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
[modify] https://crrev.com/9796a271448f237118bbc54316c664a678ada68b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConstants.java
[modify] https://crrev.com/9796a271448f237118bbc54316c664a678ada68b/content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java
[modify] https://crrev.com/9796a271448f237118bbc54316c664a678ada68b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

Project Member Comment 3 by bugdroid1@chromium.org, Mar 21
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08f54ecc76964badb626b2426b6f01f46cac7717

commit 08f54ecc76964badb626b2426b6f01f46cac7717
Author: jcivelli <jcivelli@chromium.org>
Date: Tue Mar 21 01:22:38 2017

Remove the linker parameter from ChildProcessConnection.

Removing a library loader linker specific parameter from the Android
ChildProcessConnection class to make it more generic (it was always
set to the same value).
This is part of the effort to move Android child process creation to
base/.

BUG=702316

Review-Url: https://codereview.chromium.org/2762773002
Cr-Commit-Position: refs/heads/master@{#458267}

[modify] https://crrev.com/08f54ecc76964badb626b2426b6f01f46cac7717/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java
[modify] https://crrev.com/08f54ecc76964badb626b2426b6f01f46cac7717/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
[modify] https://crrev.com/08f54ecc76964badb626b2426b6f01f46cac7717/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
[modify] https://crrev.com/08f54ecc76964badb626b2426b6f01f46cac7717/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java

Project Member Comment 4 by bugdroid1@chromium.org, Mar 21
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d62ca1238e8c477dfbbbe928febfa67dd19bfe35

commit d62ca1238e8c477dfbbbe928febfa67dd19bfe35
Author: jcivelli <jcivelli@chromium.org>
Date: Tue Mar 21 21:54:43 2017

Moving FileDescriptorInfo from content/ to base/ and making base
multiprocess test client use this class (instead of their own version).

BUG=702316

Review-Url: https://codereview.chromium.org/2765453004
Cr-Commit-Position: refs/heads/master@{#458568}

[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/base/BUILD.gn
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/base/android/OWNERS
[rename] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/base/android/java/src/org/chromium/base/process_launcher/FileDescriptorInfo.aidl
[add] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/base/android/java/src/org/chromium/base/process_launcher/FileDescriptorInfo.java
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/base/android/java/src/org/chromium/base/process_launcher/OWNERS
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/base/test/BUILD.gn
[delete] https://crrev.com/a0a1b3df67b6a958b8dd7007cc8edcae18a4d9bb/base/test/android/java/src/org/chromium/base/FileDescriptorInfo.java
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/base/test/android/java/src/org/chromium/base/ITestClient.aidl
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/base/test/android/java/src/org/chromium/base/MultiprocessTestClientLauncher.java
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/base/test/android/java/src/org/chromium/base/MultiprocessTestClientService.java
[add] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/base/test/android/java/src/org/chromium/base/OWNERS
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/content/browser/child_process_launcher_helper_android.cc
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/content/public/android/BUILD.gn
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
[delete] https://crrev.com/a0a1b3df67b6a958b8dd7007cc8edcae18a4d9bb/content/public/android/java/src/org/chromium/content/common/FileDescriptorInfo.java
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestHelperService.java

Project Member Comment 5 by bugdroid1@chromium.org, Mar 22
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27d06a66030cece252b659e1eca0be955d4d7475

commit 27d06a66030cece252b659e1eca0be955d4d7475
Author: jcivelli <jcivelli@chromium.org>
Date: Wed Mar 22 01:40:37 2017

Making callbacks in Android ChildProcessLauncher generic.

As part of the effort of moving ChildProcessLauncher.java to base,
making the callbacks passed to the child processes generic (an IBinder)
and moving the content ones to a specific content class.

BUG=702316

Review-Url: https://codereview.chromium.org/2760093002
Cr-Commit-Position: refs/heads/master@{#458612}

[modify] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/browser/BUILD.gn
[modify] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/browser/android/browser_jni_registrar.cc
[add] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/browser/android/gpu_process_callback.cc
[add] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/browser/android/gpu_process_callback.h
[modify] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/browser/child_process_launcher_helper_android.cc
[modify] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/public/android/BUILD.gn
[modify] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
[modify] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java
[modify] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
[modify] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
[add] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/public/android/java/src/org/chromium/content/browser/GpuProcessCallback.java
[modify] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/public/android/java/src/org/chromium/content/common/IChildProcessService.aidl
[rename] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/public/android/java/src/org/chromium/content/common/IGpuProcessCallback.aidl
[modify] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java

Project Member Comment 6 by bugdroid1@chromium.org, Mar 31
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce6ef2968b6785ccc8c29bf8b5954b5242845552

commit ce6ef2968b6785ccc8c29bf8b5954b5242845552
Author: jcivelli <jcivelli@chromium.org>
Date: Fri Mar 31 03:58:27 2017

Moving IChildProcessService to base/

As part of the effort of moving Android process launching to base/,
moving IChildProcessService.aidl to base/.

BUG=702316

Review-Url: https://codereview.chromium.org/2777013005
Cr-Commit-Position: refs/heads/master@{#461020}

[modify] https://crrev.com/ce6ef2968b6785ccc8c29bf8b5954b5242845552/base/BUILD.gn
[rename] https://crrev.com/ce6ef2968b6785ccc8c29bf8b5954b5242845552/base/android/java/src/org/chromium/base/process_launcher/IChildProcessService.aidl
[modify] https://crrev.com/ce6ef2968b6785ccc8c29bf8b5954b5242845552/content/public/android/BUILD.gn
[modify] https://crrev.com/ce6ef2968b6785ccc8c29bf8b5954b5242845552/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
[modify] https://crrev.com/ce6ef2968b6785ccc8c29bf8b5954b5242845552/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java
[modify] https://crrev.com/ce6ef2968b6785ccc8c29bf8b5954b5242845552/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
[modify] https://crrev.com/ce6ef2968b6785ccc8c29bf8b5954b5242845552/content/public/android/java/src/org/chromium/content/common/common.aidl
[modify] https://crrev.com/ce6ef2968b6785ccc8c29bf8b5954b5242845552/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java

Project Member Comment 7 by bugdroid1@chromium.org, Apr 4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd463aa3da242c236addb4fdf26ee4500bd429f5

commit dd463aa3da242c236addb4fdf26ee4500bd429f5
Author: jcivelli <jcivelli@chromium.org>
Date: Tue Apr 04 19:19:35 2017

Clean-up in ChildProcessLauncher.

This is a clean-up follow-up for
https://codereview.chromium.org/2760093002:
- the callback type parameter is replaced with the actual callback
  object.
- the alwaysInForeground parameter is now part of the SpawnData class.
- SpawnData accessors are renamed to follow Java naming conventions.

BUG=702316

Review-Url: https://codereview.chromium.org/2792093002
Cr-Commit-Position: refs/heads/master@{#461798}

[modify] https://crrev.com/dd463aa3da242c236addb4fdf26ee4500bd429f5/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
[modify] https://crrev.com/dd463aa3da242c236addb4fdf26ee4500bd429f5/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java

Project Member Comment 8 by bugdroid1@chromium.org, Apr 6
Labels: merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cd461bcd7239b71ba190bb1633246cce3336a76

commit 6cd461bcd7239b71ba190bb1633246cce3336a76
Author: Bo Liu <boliu@chromium.org>
Date: Thu Apr 06 17:09:23 2017

[Merge m58] Abstracting parameters passed to child processes on Android.

Making the parameters passed to a child process part of a Bundle as part
of the effort to move child process launcher code to base/.

BUG=702316

Review-Url: https://codereview.chromium.org/2756053002
Cr-Commit-Position: refs/heads/master@{#457679}
(cherry picked from commit 9796a271448f237118bbc54316c664a678ada68b)

Merging so a follow up CL can be merged for
BUG=690118

Review-Url: https://codereview.chromium.org/2795333002 .
Cr-Commit-Position: refs/branch-heads/3029@{#607}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/6cd461bcd7239b71ba190bb1633246cce3336a76/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
[modify] https://crrev.com/6cd461bcd7239b71ba190bb1633246cce3336a76/content/public/android/java/src/org/chromium/content/app/ChromiumLinkerParams.java
[modify] https://crrev.com/6cd461bcd7239b71ba190bb1633246cce3336a76/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
[modify] https://crrev.com/6cd461bcd7239b71ba190bb1633246cce3336a76/content/public/android/java/src/org/chromium/content/browser/ChildProcessConstants.java
[modify] https://crrev.com/6cd461bcd7239b71ba190bb1633246cce3336a76/content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java
[modify] https://crrev.com/6cd461bcd7239b71ba190bb1633246cce3336a76/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

Project Member Comment 9 by bugdroid1@chromium.org, Apr 6
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bd4d39997fab20c32cd0c7a75c45dbcf3f00642

commit 9bd4d39997fab20c32cd0c7a75c45dbcf3f00642
Author: jcivelli <jcivelli@chromium.org>
Date: Thu Apr 06 23:37:16 2017

Change ITestClient to be similar to IChildProcessService.

Preparing the MultiprocessTestClientLauncher for transitioning to the
new base ChildProcessLauncher. More specifically, making ITestClient
similar to IChildProcessService. This requires moving extra methods to
a new interface ITestController, and creating a callback interface
ITestCallback that lets the service sets the ITestController interface
on the client.

BUG=702316

Review-Url: https://codereview.chromium.org/2781913002
Cr-Commit-Position: refs/heads/master@{#462683}

[modify] https://crrev.com/9bd4d39997fab20c32cd0c7a75c45dbcf3f00642/base/test/BUILD.gn
[add] https://crrev.com/9bd4d39997fab20c32cd0c7a75c45dbcf3f00642/base/test/android/java/src/org/chromium/base/ChildProcessConstants.java
[add] https://crrev.com/9bd4d39997fab20c32cd0c7a75c45dbcf3f00642/base/test/android/java/src/org/chromium/base/ITestCallback.aidl
[modify] https://crrev.com/9bd4d39997fab20c32cd0c7a75c45dbcf3f00642/base/test/android/java/src/org/chromium/base/ITestClient.aidl
[add] https://crrev.com/9bd4d39997fab20c32cd0c7a75c45dbcf3f00642/base/test/android/java/src/org/chromium/base/ITestController.aidl
[modify] https://crrev.com/9bd4d39997fab20c32cd0c7a75c45dbcf3f00642/base/test/android/java/src/org/chromium/base/MultiprocessTestClientLauncher.java
[modify] https://crrev.com/9bd4d39997fab20c32cd0c7a75c45dbcf3f00642/base/test/android/java/src/org/chromium/base/MultiprocessTestClientService.java

Project Member Comment 10 by bugdroid1@chromium.org, Apr 10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/857cc7b94a374decb02c7c98a3b84dd14ec6a275

commit 857cc7b94a374decb02c7c98a3b84dd14ec6a275
Author: jcivelli <jcivelli@chromium.org>
Date: Mon Apr 10 23:17:49 2017

Adding a new annotation to set ChildProcessAllocator settings in tests.

Created a new annotation that lets tests specify settings for the
allocation of child services. It is mostly a clean-up to replace the
current use of the command line annotation with a more specific one.
As a result I had to create a new content specific instrumentation test
runner that registers that new content specific annotation.

BUG=702316

Review-Url: https://codereview.chromium.org/2814533002
Cr-Commit-Position: refs/heads/master@{#463440}

[modify] https://crrev.com/857cc7b94a374decb02c7c98a3b84dd14ec6a275/chrome/android/javatests/src/org/chromium/chrome/browser/BindingManagerIntegrationTest.java
[modify] https://crrev.com/857cc7b94a374decb02c7c98a3b84dd14ec6a275/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java
[modify] https://crrev.com/857cc7b94a374decb02c7c98a3b84dd14ec6a275/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
[modify] https://crrev.com/857cc7b94a374decb02c7c98a3b84dd14ec6a275/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
[modify] https://crrev.com/857cc7b94a374decb02c7c98a3b84dd14ec6a275/content/public/test/android/BUILD.gn
[add] https://crrev.com/857cc7b94a374decb02c7c98a3b84dd14ec6a275/content/public/test/android/javatests/src/org/chromium/content/browser/test/ChildProcessAllocatorSettings.java
[add] https://crrev.com/857cc7b94a374decb02c7c98a3b84dd14ec6a275/content/public/test/android/javatests/src/org/chromium/content/browser/test/ChildProcessAllocatorSettingsHook.java
[add] https://crrev.com/857cc7b94a374decb02c7c98a3b84dd14ec6a275/content/public/test/android/javatests/src/org/chromium/content/browser/test/ContentInstrumentationTestRunner.java
[modify] https://crrev.com/857cc7b94a374decb02c7c98a3b84dd14ec6a275/content/shell/android/javatests/AndroidManifest.xml

Project Member Comment 11 by bugdroid1@chromium.org, Apr 12
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/185a6fa4442ecee538c9f7539c3bc7f52bb0ea36

commit 185a6fa4442ecee538c9f7539c3bc7f52bb0ea36
Author: jcivelli <jcivelli@chromium.org>
Date: Wed Apr 12 03:21:51 2017

Factor out inner-classes out of ChildProcessLauncher.

Factoring out ChildProcessAllocator and SpawnData out of
ChildProcessLauncher.
Also:
- simplifying ChildProcessAllocator by lazy allocating on access rather
  than explicitly.
- removing forWarmUp from SpawnData has it can be handled as a parameter
  passed around in ChildProcessLauncher.

BUG=702316

Review-Url: https://codereview.chromium.org/2795113003
Cr-Commit-Position: refs/heads/master@{#463916}

[modify] https://crrev.com/185a6fa4442ecee538c9f7539c3bc7f52bb0ea36/content/public/android/BUILD.gn
[add] https://crrev.com/185a6fa4442ecee538c9f7539c3bc7f52bb0ea36/content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java
[modify] https://crrev.com/185a6fa4442ecee538c9f7539c3bc7f52bb0ea36/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
[modify] https://crrev.com/185a6fa4442ecee538c9f7539c3bc7f52bb0ea36/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java
[add] https://crrev.com/185a6fa4442ecee538c9f7539c3bc7f52bb0ea36/content/public/android/java/src/org/chromium/content/browser/ChildSpawnData.java
[modify] https://crrev.com/185a6fa4442ecee538c9f7539c3bc7f52bb0ea36/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
[modify] https://crrev.com/185a6fa4442ecee538c9f7539c3bc7f52bb0ea36/content/public/test/android/javatests/src/org/chromium/content/browser/test/ChildProcessAllocatorSettingsHook.java

Project Member Comment 12 by bugdroid1@chromium.org, May 17 (6 days ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9cf3fd03d8f4d885b6e1c88cf3ae6ecc8d5542b0

commit 9cf3fd03d8f4d885b6e1c88cf3ae6ecc8d5542b0
Author: jcivelli <jcivelli@chromium.org>
Date: Wed May 17 18:09:27 2017

Moving some CPL logic to CPLH.

In preparation of the move of some of the child process launcher logic to
base, moved the code responsible for building the parameters passed to
the service from ChildProcessLauncher to ChildProcessLauncherHelper.
The ChildSpawnData class now contains both bundles used when starting the
service, and it's the responsibility of the ChildProcessLauncherHelper to
include the command line and file descriptors in the bundles.

BUG=702316

Review-Url: https://codereview.chromium.org/2882823002
Cr-Commit-Position: refs/heads/master@{#472494}

[modify] https://crrev.com/9cf3fd03d8f4d885b6e1c88cf3ae6ecc8d5542b0/content/browser/child_process_launcher_helper_android.cc
[modify] https://crrev.com/9cf3fd03d8f4d885b6e1c88cf3ae6ecc8d5542b0/content/public/android/java/src/org/chromium/content/browser/ChildConnectionAllocator.java
[modify] https://crrev.com/9cf3fd03d8f4d885b6e1c88cf3ae6ecc8d5542b0/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java
[modify] https://crrev.com/9cf3fd03d8f4d885b6e1c88cf3ae6ecc8d5542b0/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
[modify] https://crrev.com/9cf3fd03d8f4d885b6e1c88cf3ae6ecc8d5542b0/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java
[modify] https://crrev.com/9cf3fd03d8f4d885b6e1c88cf3ae6ecc8d5542b0/content/public/android/java/src/org/chromium/content/browser/ChildSpawnData.java
[modify] https://crrev.com/9cf3fd03d8f4d885b6e1c88cf3ae6ecc8d5542b0/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherIntegrationTest.java
[modify] https://crrev.com/9cf3fd03d8f4d885b6e1c88cf3ae6ecc8d5542b0/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
[modify] https://crrev.com/9cf3fd03d8f4d885b6e1c88cf3ae6ecc8d5542b0/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestHelperService.java
[modify] https://crrev.com/9cf3fd03d8f4d885b6e1c88cf3ae6ecc8d5542b0/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestUtils.java

Sign in to add a comment