Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 702316 Move Android's ChildProcessLauncher from content/ to base/
Starred by 1 user Project Member Reported by jcivelli@chromium.org, Mar 16 Back to list
Status: Untriaged
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment
This bug tracks the effort for moving ChildProcessLauncher on Android to base/.
Some of the motivations:
- base/test/android uses MultiprocessTestClientLauncher which duplicates what's done in ChildProcessLauncher. It could use ChildProcessLauncher when it's moved to base.
- as part of the servicification effort the Mojo service manager will be used to start all child processes and cannot depend on content/
 
Cc: yfried...@chromium.org mariakhomenko@chromium.org agrieve@chromium.org
Labels: OS-Android
will pull out things that don't belong in base, and then move pieces when they no longer depend on things in content. no code duplication here. semi-orthogonal to all the refactor stuff I want to do.
Project Member Comment 2 by bugdroid1@chromium.org, Mar 17
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9796a271448f237118bbc54316c664a678ada68b

commit 9796a271448f237118bbc54316c664a678ada68b
Author: jcivelli <jcivelli@chromium.org>
Date: Fri Mar 17 03:45:11 2017

Abstracting parameters passed to child processes on Android.

Making the parameters passed to a child process part of a Bundle as part
of the effort to move child process launcher code to base/.

BUG=702316

Review-Url: https://codereview.chromium.org/2756053002
Cr-Commit-Position: refs/heads/master@{#457679}

[modify] https://crrev.com/9796a271448f237118bbc54316c664a678ada68b/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
[modify] https://crrev.com/9796a271448f237118bbc54316c664a678ada68b/content/public/android/java/src/org/chromium/content/app/ChromiumLinkerParams.java
[modify] https://crrev.com/9796a271448f237118bbc54316c664a678ada68b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
[modify] https://crrev.com/9796a271448f237118bbc54316c664a678ada68b/content/public/android/java/src/org/chromium/content/browser/ChildProcessConstants.java
[modify] https://crrev.com/9796a271448f237118bbc54316c664a678ada68b/content/public/android/java/src/org/chromium/content/browser/ChildProcessCreationParams.java
[modify] https://crrev.com/9796a271448f237118bbc54316c664a678ada68b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

Project Member Comment 3 by bugdroid1@chromium.org, Mar 21 (4 days ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08f54ecc76964badb626b2426b6f01f46cac7717

commit 08f54ecc76964badb626b2426b6f01f46cac7717
Author: jcivelli <jcivelli@chromium.org>
Date: Tue Mar 21 01:22:38 2017

Remove the linker parameter from ChildProcessConnection.

Removing a library loader linker specific parameter from the Android
ChildProcessConnection class to make it more generic (it was always
set to the same value).
This is part of the effort to move Android child process creation to
base/.

BUG=702316

Review-Url: https://codereview.chromium.org/2762773002
Cr-Commit-Position: refs/heads/master@{#458267}

[modify] https://crrev.com/08f54ecc76964badb626b2426b6f01f46cac7717/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java
[modify] https://crrev.com/08f54ecc76964badb626b2426b6f01f46cac7717/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
[modify] https://crrev.com/08f54ecc76964badb626b2426b6f01f46cac7717/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
[modify] https://crrev.com/08f54ecc76964badb626b2426b6f01f46cac7717/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java

Project Member Comment 4 by bugdroid1@chromium.org, Mar 21 (3 days ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d62ca1238e8c477dfbbbe928febfa67dd19bfe35

commit d62ca1238e8c477dfbbbe928febfa67dd19bfe35
Author: jcivelli <jcivelli@chromium.org>
Date: Tue Mar 21 21:54:43 2017

Moving FileDescriptorInfo from content/ to base/ and making base
multiprocess test client use this class (instead of their own version).

BUG=702316

Review-Url: https://codereview.chromium.org/2765453004
Cr-Commit-Position: refs/heads/master@{#458568}

[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/base/BUILD.gn
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/base/android/OWNERS
[rename] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/base/android/java/src/org/chromium/base/process_launcher/FileDescriptorInfo.aidl
[add] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/base/android/java/src/org/chromium/base/process_launcher/FileDescriptorInfo.java
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/base/android/java/src/org/chromium/base/process_launcher/OWNERS
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/base/test/BUILD.gn
[delete] https://crrev.com/a0a1b3df67b6a958b8dd7007cc8edcae18a4d9bb/base/test/android/java/src/org/chromium/base/FileDescriptorInfo.java
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/base/test/android/java/src/org/chromium/base/ITestClient.aidl
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/base/test/android/java/src/org/chromium/base/MultiprocessTestClientLauncher.java
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/base/test/android/java/src/org/chromium/base/MultiprocessTestClientService.java
[add] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/base/test/android/java/src/org/chromium/base/OWNERS
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/content/browser/child_process_launcher_helper_android.cc
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/content/public/android/BUILD.gn
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
[delete] https://crrev.com/a0a1b3df67b6a958b8dd7007cc8edcae18a4d9bb/content/public/android/java/src/org/chromium/content/common/FileDescriptorInfo.java
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java
[modify] https://crrev.com/d62ca1238e8c477dfbbbe928febfa67dd19bfe35/content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ChildProcessLauncherTestHelperService.java

Project Member Comment 5 by bugdroid1@chromium.org, Mar 22 (3 days ago)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27d06a66030cece252b659e1eca0be955d4d7475

commit 27d06a66030cece252b659e1eca0be955d4d7475
Author: jcivelli <jcivelli@chromium.org>
Date: Wed Mar 22 01:40:37 2017

Making callbacks in Android ChildProcessLauncher generic.

As part of the effort of moving ChildProcessLauncher.java to base,
making the callbacks passed to the child processes generic (an IBinder)
and moving the content ones to a specific content class.

BUG=702316

Review-Url: https://codereview.chromium.org/2760093002
Cr-Commit-Position: refs/heads/master@{#458612}

[modify] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/browser/BUILD.gn
[modify] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/browser/android/browser_jni_registrar.cc
[add] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/browser/android/gpu_process_callback.cc
[add] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/browser/android/gpu_process_callback.h
[modify] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/browser/child_process_launcher_helper_android.cc
[modify] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/public/android/BUILD.gn
[modify] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/public/android/java/src/org/chromium/content/app/ChildProcessServiceImpl.java
[modify] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java
[modify] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java
[modify] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java
[add] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/public/android/java/src/org/chromium/content/browser/GpuProcessCallback.java
[modify] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/public/android/java/src/org/chromium/content/common/IChildProcessService.aidl
[rename] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/public/android/java/src/org/chromium/content/common/IGpuProcessCallback.aidl
[modify] https://crrev.com/27d06a66030cece252b659e1eca0be955d4d7475/content/public/android/junit/src/org/chromium/content/browser/BindingManagerImplTest.java

Sign in to add a comment