Fix IsDeviceOwner() check in arc_net_host_impl.cc |
|||||||
Issue descriptionTEST=run cts -c android.net.wifi.cts.WifiEnterpriseConfigTest -m testAddEapNetwork TEST=run cts -c android.net.wifi.cts.WifiManagerTest -m testWifiManagerNetWork Both these CTS tests fails because of BUG= 702308 . The IsDeviceOwner() helper function fails because the LoginState API incorrectly reports the user as a regular user. Update this helper to use UserManager APIs that seem to be working correctly.
,
Mar 16 2017
,
Mar 16 2017
https://codereview.chromium.org/2757783002 Cherry pick to 57 https://codereview.chromium.org/2756673003 Cherry pick to 58
,
Mar 16 2017
,
Mar 16 2017
,
Mar 16 2017
Approving merge to M57 Chrome OS.
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42857f2ed421f4b47ff68cca13ea9266016451cd commit 42857f2ed421f4b47ff68cca13ea9266016451cd Author: abhishekbh <abhishekbh@google.com> Date: Thu Mar 16 23:37:08 2017 arc: Update device owner check implementation Update the device owner check to compare the account id of the active user with the account id of the owner as provided by the user manager API. The old implementation uses the logged in user state API which for unbeknownst reasons returns the owner as a regular user. It can also change asynchronously at boot resulting in racy behavior as its used right now. BUG= 702311 BUG=b:34661187 BUG=b:33488433 TEST=run cts -c android.net.wifi.cts.WifiEnterpriseConfigTest -m testAddEapNetwork TEST=run cts -c android.net.wifi.cts.WifiManagerTest -m testWifiManagerNetWork NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2756443003 Cr-Commit-Position: refs/heads/master@{#457563} (cherry picked from commit eb260ae77f464ec4b53627278b9e842cafb3490e) Review-Url: https://codereview.chromium.org/2756673003 Cr-Commit-Position: refs/branch-heads/2987@{#837} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/42857f2ed421f4b47ff68cca13ea9266016451cd/components/arc/net/DEPS [modify] https://crrev.com/42857f2ed421f4b47ff68cca13ea9266016451cd/components/arc/net/arc_net_host_impl.cc
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63b114848a8a4b72925cf14bbcd15d9f540271c3 commit 63b114848a8a4b72925cf14bbcd15d9f540271c3 Author: abhishekbh <abhishekbh@google.com> Date: Thu Mar 16 23:41:31 2017 arc: Update device owner check implementation Update the device owner check to compare the account id of the active user with the account id of the owner as provided by the user manager API. The old implementation uses the logged in user state API which for unbeknownst reasons returns the owner as a regular user. It can also change asynchronously at boot resulting in racy behavior as its used right now. BUG= 702311 BUG=b:34661187 BUG=b:33488433 TEST=run cts -c android.net.wifi.cts.WifiEnterpriseConfigTest -m testAddEapNetwork TEST=run cts -c android.net.wifi.cts.WifiManagerTest -m testWifiManagerNetWork NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2756443003 Cr-Commit-Position: refs/heads/master@{#457563} (cherry picked from commit eb260ae77f464ec4b53627278b9e842cafb3490e) Review-Url: https://codereview.chromium.org/2757783002 Cr-Commit-Position: refs/branch-heads/3029@{#251} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/63b114848a8a4b72925cf14bbcd15d9f540271c3/components/arc/net/DEPS [modify] https://crrev.com/63b114848a8a4b72925cf14bbcd15d9f540271c3/components/arc/net/arc_net_host_impl.cc
,
Mar 17 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by abhishekbh@google.com
, Mar 16 2017