New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702287 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: The text to import the bookmarks on the Bokkmarks Bar is broken

Project Member Reported by meh...@chromium.org, Mar 16 2017

Issue description

Chrome Version: 59.0.3043.0 canary (64-bit)
OS: MacOS 10.12.3

What steps will reproduce the problem?
(1) Open a new window with a clean profile
(2) Take a look at the Bookmarks Bar

What is the expected result? What happens instead?
The text to import bookmarks is broken.

Please use labels and text to provide additional information.
Screenshots are attached.
 
actual.png
43.7 KB View Download
expected.png
42.6 KB View Download

Comment 1 by shrike@chromium.org, Mar 16 2017

Owner: lgrey@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by ajha@chromium.org, Mar 17 2017

Labels: Needs-Triage-M59
Cc: sureshkumari@chromium.org
Labels: Needs-Feedback
Unable to reproduce the issue on Mac-10.12.3,Windows-7 and Linux Ubuntu-14.04 using chrome stable version 57.0.2987.110 and chrome version 59.0.3043.0 with the steps mentioned in comment#0.

Please find the attached screen cast and let us know if anything missed here to reproduce the issue.

Thanks..
702287.mov
2.1 MB Download

Comment 4 Deleted

Comment 5 by meh...@chromium.org, Mar 17 2017

I think it depends on the language. Please try it in German - The string is longer there.

defaults write com.google.Chrome.canary AppleLanguages '(de)' 

Comment 6 by lgrey@chromium.org, Mar 17 2017

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3146dac1c094489c1eba84a95f699f5b553ef32

commit e3146dac1c094489c1eba84a95f699f5b553ef32
Author: lgrey <lgrey@chromium.org>
Date: Mon Mar 20 14:45:40 2017

[Mac] Resize bookmark bar no item container after localizing

BUG= 702287 

Review-Url: https://codereview.chromium.org/2751913008
Cr-Commit-Position: refs/heads/master@{#458059}

[modify] https://crrev.com/e3146dac1c094489c1eba84a95f699f5b553ef32/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.mm

Labels: -Needs-Feedback TE-Verified-M59 TE-Verified-59.0.3047.0
Tested the issue on Mac 10.12.3 using Chrome version 59.0.3047.0 as per the comment #5.
Observed that the fix is working as expected.Hence adding the verified labels.

Please find the attached screen cast for reference.


Thanks.
Mac-702287.mov
3.1 MB Download

Comment 9 by lgrey@chromium.org, Mar 21 2017

Status: Fixed (was: Started)
Hey lgrey@, this is still not fixed in latest Canary Version 59.0.3054.0 canary (64-bit) after your patch.

Please see the screenshots Stable vs. Canary.
Canary_broken.png
116 KB View Download
Stable_okay.png
115 KB View Download
Status: Assigned (was: Fixed)
Labels: -Needs-Bisect -Needs-Triage-M59 -TE-Verified-M59 -TE-Verified-59.0.3047.0 M-59
Removing triage labels, as the suspect is already known.
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e46fe03681067bf67b40be80affabd6103880133

commit e46fe03681067bf67b40be80affabd6103880133
Author: lgrey <lgrey@chromium.org>
Date: Fri Mar 31 14:46:20 2017

[Mac] Fix bookmark bar no item container autoresizing mask

More fallout from XIB removal :/

BUG= 702287 

Review-Url: https://codereview.chromium.org/2789613002
Cr-Commit-Position: refs/heads/master@{#461120}

[modify] https://crrev.com/e46fe03681067bf67b40be80affabd6103880133/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.mm

Fixed in Chrome Version 59.0.3059.0 canary (64-bit). Thank you lgrey@.
Bildschirmfoto 2017-04-01 um 08.45.53.png
85.1 KB View Download
Status: Verified (was: Assigned)
Labels: TE-Verified-M59 TE-Verified-59.0.3061.3
Tested the issue on Mac 10.12.3 using chrome version 59.0.3061.3.Able to see the complete text import bookmarks now in German language.
Please find the attached screen shot for the same.

Adding TE-Verified labels.

Thanks,
702287.png
212 KB View Download

Sign in to add a comment