Issue metadata
Sign in to add a comment
|
Regression: The text to import the bookmarks on the Bokkmarks Bar is broken |
||||||||||||||||||||||
Issue descriptionChrome Version: 59.0.3043.0 canary (64-bit) OS: MacOS 10.12.3 What steps will reproduce the problem? (1) Open a new window with a clean profile (2) Take a look at the Bookmarks Bar What is the expected result? What happens instead? The text to import bookmarks is broken. Please use labels and text to provide additional information. Screenshots are attached.
,
Mar 17 2017
,
Mar 17 2017
Unable to reproduce the issue on Mac-10.12.3,Windows-7 and Linux Ubuntu-14.04 using chrome stable version 57.0.2987.110 and chrome version 59.0.3043.0 with the steps mentioned in comment#0. Please find the attached screen cast and let us know if anything missed here to reproduce the issue. Thanks..
,
Mar 17 2017
I think it depends on the language. Please try it in German - The string is longer there. defaults write com.google.Chrome.canary AppleLanguages '(de)'
,
Mar 17 2017
,
Mar 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3146dac1c094489c1eba84a95f699f5b553ef32 commit e3146dac1c094489c1eba84a95f699f5b553ef32 Author: lgrey <lgrey@chromium.org> Date: Mon Mar 20 14:45:40 2017 [Mac] Resize bookmark bar no item container after localizing BUG= 702287 Review-Url: https://codereview.chromium.org/2751913008 Cr-Commit-Position: refs/heads/master@{#458059} [modify] https://crrev.com/e3146dac1c094489c1eba84a95f699f5b553ef32/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.mm
,
Mar 21 2017
Tested the issue on Mac 10.12.3 using Chrome version 59.0.3047.0 as per the comment #5. Observed that the fix is working as expected.Hence adding the verified labels. Please find the attached screen cast for reference. Thanks.
,
Mar 21 2017
,
Mar 28 2017
Hey lgrey@, this is still not fixed in latest Canary Version 59.0.3054.0 canary (64-bit) after your patch. Please see the screenshots Stable vs. Canary.
,
Mar 28 2017
,
Mar 29 2017
Removing triage labels, as the suspect is already known.
,
Mar 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e46fe03681067bf67b40be80affabd6103880133 commit e46fe03681067bf67b40be80affabd6103880133 Author: lgrey <lgrey@chromium.org> Date: Fri Mar 31 14:46:20 2017 [Mac] Fix bookmark bar no item container autoresizing mask More fallout from XIB removal :/ BUG= 702287 Review-Url: https://codereview.chromium.org/2789613002 Cr-Commit-Position: refs/heads/master@{#461120} [modify] https://crrev.com/e46fe03681067bf67b40be80affabd6103880133/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_view_cocoa.mm
,
Apr 1 2017
Fixed in Chrome Version 59.0.3059.0 canary (64-bit). Thank you lgrey@.
,
Apr 3 2017
,
Apr 4 2017
Tested the issue on Mac 10.12.3 using chrome version 59.0.3061.3.Able to see the complete text import bookmarks now in German language. Please find the attached screen shot for the same. Adding TE-Verified labels. Thanks, |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by shrike@chromium.org
, Mar 16 2017Status: Assigned (was: Untriaged)