New issue
Advanced search Search tips

Issue 702286 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

remove lint warnings in android_webview/tools/system_webview_shell/

Project Member Reported by timvolod...@chromium.org, Mar 16 2017

Issue description

e.g.:

../../android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/JankActivity.java:32: warning: [deprecation] shouldOverrideUrlLoading(WebView,String) in WebViewClient has been deprecated
            public boolean shouldOverrideUrlLoading(WebView webView, String url) {
                           ^
../../android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryActivity.java:57: warning: [deprecation] shouldOverrideUrlLoading(WebView,String) in WebViewClient has been deprecated
                public boolean shouldOverrideUrlLoading(WebView view, String url) {
                               ^
../../android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryMemoryPressureActivity.java:37: warning: [deprecation] shouldOverrideUrlLoading(WebView,String) in WebViewClient has been deprecated
                public boolean shouldOverrideUrlLoading(WebView webView, String url) {
                               ^
../../android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewCreateDestroyActivity.java:65: warning: [deprecation] shouldOverrideUrlLoading(WebView,String) in WebViewClient has been deprecated
                public boolean shouldOverrideUrlLoading(WebView view, String url) {
                               ^
../../android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java:273: warning: [deprecation] shouldOverrideUrlLoading(WebView,String) in WebViewClient has been deprecated
            public boolean shouldOverrideUrlLoading(WebView webView, String url) {
                           ^
../../android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java:468: warning: [deprecation] setGeolocationDatabasePath(String) in WebSettings has been deprecated
        settings.setGeolocationDatabasePath(getDir("geolocation", 0).getPath());
                ^
../../android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewLayoutTestActivity.java:49: warning: [deprecation] shouldOverrideUrlLoading(WebView,String) in WebViewClient has been deprecated
            public boolean shouldOverrideUrlLoading(WebView webView, String url) {
                           ^

 
Labels: OS-Android
Status: Started (was: Assigned)
Components: Mobile>WebView
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bebdf5033d1104e9ae902ef7a6fdbadb78e61d77

commit bebdf5033d1104e9ae902ef7a6fdbadb78e61d77
Author: timvolodine <timvolodine@chromium.org>
Date: Mon Mar 20 13:31:24 2017

[WebViewShell] Clean-up lint warnings in android_webview/tools/system_webview_shell/apk/

Suppress and document lint warnings due to api level deprecations.
The supressions are added because the SystemWebViewShell supports
api level 19 and up, while the deprecations happened at higher
level.

In particular the following methods are involved:
- shouldOverrideUrlLoading()
- setGeolocationDatabasePath()

BUG= 702286 

Review-Url: https://codereview.chromium.org/2759473002
Cr-Commit-Position: refs/heads/master@{#458050}

[modify] https://crrev.com/bebdf5033d1104e9ae902ef7a6fdbadb78e61d77/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/JankActivity.java
[modify] https://crrev.com/bebdf5033d1104e9ae902ef7a6fdbadb78e61d77/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryActivity.java
[modify] https://crrev.com/bebdf5033d1104e9ae902ef7a6fdbadb78e61d77/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/TelemetryMemoryPressureActivity.java
[modify] https://crrev.com/bebdf5033d1104e9ae902ef7a6fdbadb78e61d77/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewBrowserActivity.java
[modify] https://crrev.com/bebdf5033d1104e9ae902ef7a6fdbadb78e61d77/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewCreateDestroyActivity.java
[modify] https://crrev.com/bebdf5033d1104e9ae902ef7a6fdbadb78e61d77/android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewLayoutTestActivity.java

Status: Fixed (was: Started)

Sign in to add a comment