New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 702285 link

Starred by 1 user
Status: WontFix
Owner: ----
Closed: Apr 2017
Cc:
danakj@chromium.org
samans@chromium.org
█ fsam...@chromium.org
rjkroege@chromium.org
sadrul@chromium.org
piman@chromium.org
kylec...@chromium.org
enne@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Surface::EvictFrame needs more test coverage

Project Member Reported by samans@chromium.org, Mar 16 2017 
After introducing surface synchronization, things got more complicated in cc::Surface since we are now holding two frames. This calls for more test coverage. For example, Surface::EvictFrame needs unit tests to make sure it evicts both frames and not just active or pending frame.

Comment 1 by fsam...@chromium.org, Mar 16 2017

Blocking: 601863
Cc: rjkroege@chromium.org sadrul@chromium.org kylec...@chromium.org enne@chromium.org danakj@chromium.org samans@chromium.org piman@chromium.org
If ForceReclaimResources goes away, then we don't need to worry about this test coverage, but if we intend to keep it around, then we need test coverage.

I was chatting offline to erick@, I feel like fundamentally ForceReclaimResources is a bad API for an out of process display compositor because it's async and so we can't guarantee that resources will be returned for use by the next frame generated by the browser. Perhaps we need to rethink ForceReclaimResources?

Comment 2 by danakj@chromium.org, Mar 16 2017 

eric almost removed it, but it got reverted. can we go back to removing it? i am not clear why it was reverted

Comment 3 by fsam...@chromium.org, Apr 18 2017

Status: WontFix (was: Available)
kylechar@ is currently looking into removing it. I'm marking this bug as WONTFIX.

Comment 4 by fsam...@chromium.org, Jun 13 2017

Blocking: -601863

Comment 5 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService
►

Sign in to add a comment