New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702278 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Upstream Physical Web code specific to v10 of Play Services

Project Member Reported by cco3@chromium.org, Mar 16 2017

Issue description

Play services 10 is out...we should upstream code that is specific to it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/203431000fbc3145c7732a85cadd348378bc7d24

commit 203431000fbc3145c7732a85cadd348378bc7d24
Author: cco3 <cco3@chromium.org>
Date: Tue Mar 21 21:44:13 2017

Remove unused methods from PhysicalWebBleClient

These various subscription methods have been moved out into subclasses
of NearbySubscription.

BUG= 702278 

Review-Url: https://codereview.chromium.org/2756513004
Cr-Commit-Position: refs/heads/master@{#458561}

[modify] https://crrev.com/203431000fbc3145c7732a85cadd348378bc7d24/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/faba79b70831e1f83d831419ba6d58e1cc3ed461

commit faba79b70831e1f83d831419ba6d58e1cc3ed461
Author: cco3 <cco3@chromium.org>
Date: Thu Mar 23 17:17:13 2017

Use NearbyPermissions.BLE for Physical Web

This determines the scope of permissions that Nearby needs.
This will avoid the permissions dialogue when we have
ACCESS_FINE_LOCATION.

BUG= 702278 

Review-Url: https://codereview.chromium.org/2746013009
Cr-Commit-Position: refs/heads/master@{#459125}

[modify] https://crrev.com/faba79b70831e1f83d831419ba6d58e1cc3ed461/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/NearbySubscription.java
[modify] https://crrev.com/faba79b70831e1f83d831419ba6d58e1cc3ed461/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/1bc3e86a677b3e6937c20d632922877114d3d998

commit 1bc3e86a677b3e6937c20d632922877114d3d998
Author: Conley Owens <cco3@google.com>
Date: Thu Mar 23 20:46:24 2017

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5449aeb35dda45e9eb037bafd8ef50fb9c47fa95

commit 5449aeb35dda45e9eb037bafd8ef50fb9c47fa95
Author: cco3 <cco3@chromium.org>
Date: Thu Mar 23 21:13:06 2017

Read onDistanceChange events from Nearby Messages

This change uses the new onDistanceChange events from Nearby Messages.
Additionally, we move our code out of PhysicalWebBleClient since there
is no longer a need for downstream code to override it.

BUG= 702278 

Review-Url: https://codereview.chromium.org/2752313003
Cr-Commit-Position: refs/heads/master@{#459219}

[modify] https://crrev.com/5449aeb35dda45e9eb037bafd8ef50fb9c47fa95/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/NearbyForegroundSubscription.java
[modify] https://crrev.com/5449aeb35dda45e9eb037bafd8ef50fb9c47fa95/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/e4cf2987d0cd8f927270af76433b2e7a9d2f7d0e

commit e4cf2987d0cd8f927270af76433b2e7a9d2f7d0e
Author: Conley Owens <cco3@google.com>
Date: Thu Mar 23 22:48:19 2017

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a5d9139a1a58cc2324cfe51f305fb0b1b71024e

commit 7a5d9139a1a58cc2324cfe51f305fb0b1b71024e
Author: cco3 <cco3@chromium.org>
Date: Thu Mar 23 23:37:40 2017

Remove ForegroundMessageListener definition

This is no longer used or needed.

BUG= 702278 

Review-Url: https://codereview.chromium.org/2768423002
Cr-Commit-Position: refs/heads/master@{#459280}

[modify] https://crrev.com/7a5d9139a1a58cc2324cfe51f305fb0b1b71024e/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PhysicalWebBleClient.java

Comment 7 by cco3@chromium.org, Mar 23 2017

Components: Internals>PhysicalWeb
Status: Fixed (was: Untriaged)

Sign in to add a comment