!activating_ in system_tray.cc |
|||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=4818830703722496 Fuzzer: cdiehl_peach Job Type: linux_asan_chrome_chromeos Platform Id: linux Crash Type: CHECK failure Crash Address: Crash State: !activating_ in system_tray.cc ash::SystemTray::ActivationObserver::OnWindowActivated ash::WmShell::OnWindowActivated Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_chromeos&range=423512:423881 Reproducer Testcase: https://clusterfuzz.com/download/AMIfv94eFJVyeUj73nJy5tTmZhPoU2FM5M-AQwaHJGxoVKEmgIu4nYcMdbDZyRenl5UQnbGoRehhuhwuGmctPlVNZgyBnODXQL4ZpSY6I7XlvJQCIFqhH76wzcPteT82R5Yrnuegy4Qn0H3pu63c6MCwpIhBMEzbZo7uPkJTqFZ0lAl5I4yyImOh0NTCn8w1_33zQMVQjasdWh7HWCEBBxIBhxb95WKkkQD8wyfzZ6RrLTd9SVHn4PgSTkc4XsR9wzUegz8aS6m3Mr6Lh66BZ7Ryz7oultBDwwRCeA5rxnJueB4RvgxlJRS00wSw5XuleKjB03fx9IrNURcd15yrfs4Fy1Jbicb8jeu19tsI08Qqk0D3efFg-Z1Va63PeFpalP_2raTZKfUAALEYOd5dPW7kbRjIYGf9sQ?testcase_id=4818830703722496 Additional requirements: Requires Gestures Issue filed automatically. See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
,
Mar 17 2017
Oshima added this check to help track what I think is the same clusterfuzz report. Specifically 651242. Passing to Oshima.
,
Mar 24 2017
warx@, let's have a chat today.
,
Mar 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85eb99035fea825bca1ecb8b12b36fb12f6065ea commit 85eb99035fea825bca1ecb8b12b36fb12f6065ea Author: warx <warx@chromium.org> Date: Thu Mar 30 01:23:05 2017 cros: do not try to activate system tray bubble if it is in process of closing Changes: SystemTray::CloseSystemBubble() !activating_ is caught, reported in crbug.com/702267 . Widget::IsClosed() indicates a widget is in process of closing, so we use this to do the check in ActivateBubble(). This is speculative fix for the bug. BUG= 702267 TEST=none Review-Url: https://codereview.chromium.org/2785823002 Cr-Commit-Position: refs/heads/master@{#460616} [modify] https://crrev.com/85eb99035fea825bca1ecb8b12b36fb12f6065ea/ash/common/system/tray/system_tray.cc
,
Mar 30 2017
A speculative fix is just landed. Assign back to mummareddy@. Please assign back to me if CHECK failure still happens. Thanks!
,
Mar 30 2017
ClusterFuzz has detected this issue as fixed in range 460544:460618. Detailed report: https://clusterfuzz.com/testcase?key=4818830703722496 Fuzzer: cdiehl_peach Job Type: linux_asan_chrome_chromeos Platform Id: linux Crash Type: CHECK failure Crash Address: Crash State: !activating_ in system_tray.cc ash::SystemTray::ActivationObserver::OnWindowActivated ash::WmShell::OnWindowActivated Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_chromeos&range=423512:423881 Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_chromeos&range=460544:460618 Reproducer Testcase: https://clusterfuzz.com/download/AMIfv94eFJVyeUj73nJy5tTmZhPoU2FM5M-AQwaHJGxoVKEmgIu4nYcMdbDZyRenl5UQnbGoRehhuhwuGmctPlVNZgyBnODXQL4ZpSY6I7XlvJQCIFqhH76wzcPteT82R5Yrnuegy4Qn0H3pu63c6MCwpIhBMEzbZo7uPkJTqFZ0lAl5I4yyImOh0NTCn8w1_33zQMVQjasdWh7HWCEBBxIBhxb95WKkkQD8wyfzZ6RrLTd9SVHn4PgSTkc4XsR9wzUegz8aS6m3Mr6Lh66BZ7Ryz7oultBDwwRCeA5rxnJueB4RvgxlJRS00wSw5XuleKjB03fx9IrNURcd15yrfs4Fy1Jbicb8jeu19tsI08Qqk0D3efFg-Z1Va63PeFpalP_2raTZKfUAALEYOd5dPW7kbRjIYGf9sQ?testcase_id=4818830703722496 Additional requirements: Requires Gestures See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Mar 30 2017
ClusterFuzz testcase 4818830703722496 is verified as fixed, so closing issue. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
Mar 30 2017
Thank you warx@ for fixing this one. will assign if it fails again.
,
Apr 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78581ae9b930e09bb0640986eb693d703dde905c commit 78581ae9b930e09bb0640986eb693d703dde905c Author: warx <warx@chromium.org> Date: Mon Apr 03 20:39:24 2017 cleanup: Remove the system tray bubble crash investigation CHECK Changes: Now that Clusterfuzz reports crash fixed in crbug.com/702267 , it is time to remove the check induced in crrev.com/2392183002. BUG= 702267 BUG= 651242 TEST=none Review-Url: https://codereview.chromium.org/2789653002 Cr-Commit-Position: refs/heads/master@{#461523} [modify] https://crrev.com/78581ae9b930e09bb0640986eb693d703dde905c/ash/common/system/tray/system_tray.cc [modify] https://crrev.com/78581ae9b930e09bb0640986eb693d703dde905c/ash/common/system/tray/system_tray.h |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mummare...@chromium.org
, Mar 16 2017Owner: sky@chromium.org
Status: Assigned (was: Untriaged)