Issue metadata
Sign in to add a comment
|
3.5%-7% regression in v8 at 43848:43848 |
||||||||||||||||||||
Issue descriptionRelated to ToDirectStringAssembler.
,
Mar 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/338257509d7f5ec8ea0a16ba3eb263265efa06f9 commit 338257509d7f5ec8ea0a16ba3eb263265efa06f9 Author: jgruber <jgruber@chromium.org> Date: Fri Mar 17 12:19:29 2017 [string] Optimize ToDirectStringAssembler for sequential strings ToDirectStringAssembler is used in StringCharCodeAt and SubString (which uses StringCharCodeAt internally). SubString is used all over the place (e.g. RegExp result construction), and is critical for benchmark performance. The CL introducing ToDirectStringAssembler caused a couple of regressions which this is intended to fix by adding a fast path for sequential strings. BUG= chromium:702246 Review-Url: https://codereview.chromium.org/2754933003 Cr-Commit-Position: refs/heads/master@{#43897} [modify] https://crrev.com/338257509d7f5ec8ea0a16ba3eb263265efa06f9/src/code-stub-assembler.cc
,
Mar 20 2017
This seems to have mostly recovered. Atom_x64/JetStream/base64 is still down, will keep an eye on this. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by jgruber@chromium.org
, Mar 16 2017