New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702241 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Create content suggestions provider for Reading List

Project Member Reported by gambard@chromium.org, Mar 16 2017

Issue description

The Reading List will be displayed as a content suggestions. It needs a provider to be interfaced with the Content Suggestions Service.
 
As the Reading List are content added by the user it should surface on top.

Comment 2 by treib@chromium.org, Mar 17 2017

Note that we have a personal section ranker, which will (probably, soon) mostly replace the fixed ordering.
Thanks for the information.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9bff741d84b56d8f5963a398958fe85cc110fae

commit c9bff741d84b56d8f5963a398958fe85cc110fae
Author: gambard <gambard@chromium.org>
Date: Tue Mar 28 07:58:20 2017

Create ReadingListSuggestionsProvider

This CL creates the ReadingListSuggestionsProvider.

BUG= 702241 

Review-Url: https://codereview.chromium.org/2755113002
Cr-Commit-Position: refs/heads/master@{#460039}

[modify] https://crrev.com/c9bff741d84b56d8f5963a398958fe85cc110fae/components/ntp_snippets/BUILD.gn
[modify] https://crrev.com/c9bff741d84b56d8f5963a398958fe85cc110fae/components/ntp_snippets/DEPS
[modify] https://crrev.com/c9bff741d84b56d8f5963a398958fe85cc110fae/components/ntp_snippets/category.h
[modify] https://crrev.com/c9bff741d84b56d8f5963a398958fe85cc110fae/components/ntp_snippets/category_rankers/constant_category_ranker.cc
[modify] https://crrev.com/c9bff741d84b56d8f5963a398958fe85cc110fae/components/ntp_snippets/content_suggestions_metrics.cc
[add] https://crrev.com/c9bff741d84b56d8f5963a398958fe85cc110fae/components/ntp_snippets/reading_list/reading_list_suggestions_provider.cc
[add] https://crrev.com/c9bff741d84b56d8f5963a398958fe85cc110fae/components/ntp_snippets/reading_list/reading_list_suggestions_provider.h
[add] https://crrev.com/c9bff741d84b56d8f5963a398958fe85cc110fae/components/ntp_snippets/reading_list/reading_list_suggestions_provider_unittest.cc
[modify] https://crrev.com/c9bff741d84b56d8f5963a398958fe85cc110fae/components/ntp_snippets_strings.grdp
[modify] https://crrev.com/c9bff741d84b56d8f5963a398958fe85cc110fae/tools/metrics/histograms/histograms.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 30 2017

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24939285bd24532cc0c2ffca609c5e80073cd9f4

commit 24939285bd24532cc0c2ffca609c5e80073cd9f4
Author: gambard <gambard@chromium.org>
Date: Thu Mar 30 12:12:11 2017

Add ContentSuggestion for ReadingList

This CL allows the ContentSuggestionsUpdater to display the
ReadingListContentSuggestions.

BUG= 702241 ,  706296 

Review-Url: https://codereview.chromium.org/2755383002
Cr-Commit-Position: refs/heads/master@{#460731}

[modify] https://crrev.com/24939285bd24532cc0c2ffca609c5e80073cd9f4/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
[modify] https://crrev.com/24939285bd24532cc0c2ffca609c5e80073cd9f4/ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn
[add] https://crrev.com/24939285bd24532cc0c2ffca609c5e80073cd9f4/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_reading_list_item.h
[add] https://crrev.com/24939285bd24532cc0c2ffca609c5e80073cd9f4/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_reading_list_item.mm
[modify] https://crrev.com/24939285bd24532cc0c2ffca609c5e80073cd9f4/ios/chrome/browser/ui/content_suggestions/content_suggestion.h
[modify] https://crrev.com/24939285bd24532cc0c2ffca609c5e80073cd9f4/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
[modify] https://crrev.com/24939285bd24532cc0c2ffca609c5e80073cd9f4/ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
[modify] https://crrev.com/24939285bd24532cc0c2ffca609c5e80073cd9f4/ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.h

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42692e1c75507ae5a4f9f55c357c5fda2b0a89ab

commit 42692e1c75507ae5a4f9f55c357c5fda2b0a89ab
Author: gambard <gambard@chromium.org>
Date: Fri Mar 31 09:15:23 2017

Register the ReadingListProvider

This CL register the ReadingListProvider in the ContentSuggestionsService,
allowing the ReadingListEntries to be displayed.

BUG= 702241 

Review-Url: https://codereview.chromium.org/2790543002
Cr-Commit-Position: refs/heads/master@{#461085}

[modify] https://crrev.com/42692e1c75507ae5a4f9f55c357c5fda2b0a89ab/ios/chrome/browser/ntp_snippets/BUILD.gn
[modify] https://crrev.com/42692e1c75507ae5a4f9f55c357c5fda2b0a89ab/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fea421c12c5499a4f6b04291a97705662cf41d1c

commit fea421c12c5499a4f6b04291a97705662cf41d1c
Author: gambard <gambard@chromium.org>
Date: Wed Apr 05 08:57:12 2017

Update provider on Reading List model update

When the Reading List model is updated, the provider notifies the service.

BUG= 702241 

Review-Url: https://codereview.chromium.org/2794853004
Cr-Commit-Position: refs/heads/master@{#462013}

[modify] https://crrev.com/fea421c12c5499a4f6b04291a97705662cf41d1c/components/ntp_snippets/reading_list/reading_list_suggestions_provider.cc
[modify] https://crrev.com/fea421c12c5499a4f6b04291a97705662cf41d1c/components/ntp_snippets/reading_list/reading_list_suggestions_provider.h

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/892e302345218f7ed2ecfd9295a6011df806026e

commit 892e302345218f7ed2ecfd9295a6011df806026e
Author: gambard <gambard@chromium.org>
Date: Thu Apr 06 10:39:07 2017

Display offline availability on ContentSuggestions

This CL displays the offline availability of the ReadingList items in
ContentSuggestions.

BUG= 706296 ,  702241 

Review-Url: https://codereview.chromium.org/2796273002
Cr-Commit-Position: refs/heads/master@{#462416}

[modify] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/content_suggestions/BUILD.gn
[modify] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm
[modify] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/ui/content_suggestions/BUILD.gn
[modify] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/ui/content_suggestions/content_suggestion.h
[modify] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/ui/content_suggestions/content_suggestion.mm
[add] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/ui/content_suggestions/content_suggestion_extra_builder.h
[add] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/ui/content_suggestions/content_suggestion_extra_builder.mm
[modify] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm
[modify] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
[modify] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/ui/reading_list/reading_list_utils.h
[modify] https://crrev.com/892e302345218f7ed2ecfd9295a6011df806026e/ios/chrome/browser/ui/reading_list/reading_list_utils.mm

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15343e304623319dfd5612ac3d22930977a7e20c

commit 15343e304623319dfd5612ac3d22930977a7e20c
Author: gambard <gambard@chromium.org>
Date: Fri Apr 07 11:59:12 2017

ReadingListProvider returns empty image

The Reading List provider does not have an image to provide to the UI.
The FetchImage method runs the callback with an empty image.

BUG= 702241 

Review-Url: https://codereview.chromium.org/2802973004
Cr-Commit-Position: refs/heads/master@{#462840}

[modify] https://crrev.com/15343e304623319dfd5612ac3d22930977a7e20c/components/ntp_snippets/reading_list/reading_list_suggestions_provider.cc

Status: Fixed (was: Assigned)

Sign in to add a comment