New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702230 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Refactor components/sync/driver/about_sync_util.cc to remove usages of raw pointers

Project Member Reported by jdoerrie@chromium.org, Mar 16 2017

Issue description

As discussed in http://crrev.com/2740143002 this bug exists to track the deletion of raw pointer usages in components/sync/driver/about_sync_util.cc.

 

Comment 1 by s...@chromium.org, Mar 16 2017

Components: Services>Sync
Status: Assigned (was: Untriaged)

Comment 2 by s...@chromium.org, Jan 17 2018

Cc: s...@chromium.org
Labels: SyncHandoff2018 SyncStarter2018
Owner: ----
Status: Available (was: Assigned)
This still needs to be done. My apologies for never getting around to it.

Comment 3 by zea@chromium.org, Jan 17 2018

Labels: -SyncStarter2018 Hotlist-GoodFirstBug

Comment 4 by treib@chromium.org, Mar 8 2018

Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Owner: treib@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ac3ad8c6df8a6d86eb6d152895592894a18fc65

commit 0ac3ad8c6df8a6d86eb6d152895592894a18fc65
Author: Marc Treib <treib@chromium.org>
Date: Thu Mar 15 16:11:28 2018

Refactor about_sync_util.cc to remove unsafe usage of raw pointers

The previous [Bool|Int|String]SyncStat classes relied on raw pointers
into base::ListValue, which is bad because they become invalid when
the actual std::vector backing the list gets resized. They're replaced
by new SectionList/Section/Stat classes that are less fragile.
While we're here, this also updates the code to use the new base::Value
APIs, i.e. using values instead of unique_ptrs.

Bug:  702230 
Change-Id: I5da50857587acb50ffb8849a7fa2cf8dabce9e45
Reviewed-on: https://chromium-review.googlesource.com/955324
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543384}
[modify] https://crrev.com/0ac3ad8c6df8a6d86eb6d152895592894a18fc65/components/sync/driver/about_sync_util.cc

Comment 6 by treib@chromium.org, Mar 15 2018

Status: Fixed (was: Started)

Sign in to add a comment