New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702180 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

aura_unittests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1): UserActivityForwarderTest.ForwardActivityToDetector

Project Member Reported by hua...@chromium.org, Mar 16 2017

Issue description

aura_unittests failing on chromium.memory/Linux Chromium OS ASan LSan Tests (1)

Builders failed on: 
- Linux Chromium OS ASan LSan Tests (1): 
  https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29



 

Comment 1 by hua...@chromium.org, Mar 16 2017

Status: Assigned (was: Available)
Findit points to http://crbug.com/2725133002 for Linux Chromium OS ASan LSan failure (memory leak) with 75% confidence.

Comment 2 by hua...@chromium.org, Mar 16 2017

Labels: Pri-1 Type-Bug

Comment 3 by roc...@chromium.org, Mar 16 2017

I have a verified fix out for review: https://codereview.
chromium.org/2754863002

TL;DR: It's not a real leak in production. Will land the fix ASAP to green
the red bot.

Comment 4 by hua...@chromium.org, Mar 16 2017

Ah okay, thanks for the update!
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58e6cc73277d3bc9e67687df2c1dd575019d3282

commit 58e6cc73277d3bc9e67687df2c1dd575019d3282
Author: rockot <rockot@chromium.org>
Date: Thu Mar 16 16:36:36 2017

Mojo: Don't hold a watch context ref in SimpleWatcher posted task

In test environments it's fairly common for task runners to be
torn down without flushing posted tasks. If there's e.g. a binding
object on the test function stack that gets destroyed on unwind,
this might end up posting a SimpleWatcher notification task that
then never runs.

Currently we disambiguate watch contexts in SimpleWatcher by
retaining a ref to the Context in said notification task and comparing
to the currently known Context instance on the SimpleWatcher's thread.
This can lead to indirect leaks in the aforementioned testing scenario.

This CL instead introduces a sequence number in SimpleWatcher which is
incremented every time a new watch is started. This sequence number is
used to disambiguate notifications which might have come from a previous
watch, thus avoiding the unnecessary ref count on Context.

BUG= 702180 
R=yzshen@chromium.org

Review-Url: https://codereview.chromium.org/2754863002
Cr-Commit-Position: refs/heads/master@{#457455}

[modify] https://crrev.com/58e6cc73277d3bc9e67687df2c1dd575019d3282/mojo/public/cpp/system/simple_watcher.cc
[modify] https://crrev.com/58e6cc73277d3bc9e67687df2c1dd575019d3282/mojo/public/cpp/system/simple_watcher.h

Comment 6 by roc...@chromium.org, Mar 16 2017

Status: Fixed (was: Assigned)
Should go green once this is picked up.

Sign in to add a comment