Named browsing context _blank, _parent, _top, _self should not be case-sensitive
Reported by
l...@bocoup.com,
Mar 16 2017
|
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 Steps to reproduce the problem: 1. `window.open` a document into `_bLAnk`. 2. `window.open` a document into `_bLAnk`. What is the expected behavior? The browser should create two new browsing contexts. What went wrong? Only one new browsing context is created. The browser is treating `_bLAnk` (or other case-mixing of `_blank`) as a new, named, non-keyword browsing context. The second `window.open` call is reusing the browsing context (`_bLAnk`) created by the first `window.open`. Did this work before? N/A Does this work in other browsers? Yes Chrome version: 56.0.2924.87 Channel: n/a OS Version: OS X 10.11.6 Flash Version: Relevant HTML spec section 7.1.5 Named Browsing Contexts: https://html.spec.whatwg.org/#browsing-context-names Relevant web-platform-tests tests: https://github.com/w3c/web-platform-tests/pull/5145
,
Mar 17 2017
Reporter@ - Thanks for filing the issue...!! Could you please provide a sample html file to test this issue. This will help us in triaging the issue further. Thanks...!!
,
Mar 17 2017
Here is a test case - https://jsfiddle.net/8v7ots9x/ Only Firefox gets this right.
,
Mar 17 2017
Filed an HTML issue - https://github.com/whatwg/html/issues/2443
,
Mar 27 2017
Concluded in https://github.com/whatwg/html/issues/2443#issuecomment-289043039 that case-insensitive is better.
,
Mar 27 2017
,
Mar 30 2017
I will have a look at this. The failing test is located here: http://w3c-test.org/html/browsers/windows/browsing-context-names/browsing-context-_blank.html
,
Mar 30 2017
Should be fixed in https://codereview.chromium.org/2785063002/
,
Mar 30 2017
,
Mar 30 2017
Issue 705646 has been merged into this issue.
,
Mar 30 2017
Issue 702188 has been merged into this issue.
,
Mar 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c631cd11f112484251cf04ae4845cc747b5c1aaf commit c631cd11f112484251cf04ae4845cc747b5c1aaf Author: martin <martin@martinrogalla.com> Date: Fri Mar 31 04:41:11 2017 Make browsing context keywords case-insensitive. The patch makes the browsing context keywords (_blank, _self, _parent, _top) case-insensitive as is specified in [1]. The patch ensures that all the tests in [2] pass. [1] - https://html.spec.whatwg.org/#browsing-context-names [2] - wpt/html/browsers/windows/browsing-context-names/ BUG= 702178 Review-Url: https://codereview.chromium.org/2785063002 Cr-Commit-Position: refs/heads/master@{#461034} [modify] https://crrev.com/c631cd11f112484251cf04ae4845cc747b5c1aaf/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/ab6d23d22c9b28c9ca9b7568db2091db6b70c090/third_party/WebKit/LayoutTests/external/wpt/html/browsers/windows/browsing-context-names/browsing-context-_blank-expected.txt [modify] https://crrev.com/c631cd11f112484251cf04ae4845cc747b5c1aaf/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp [modify] https://crrev.com/c631cd11f112484251cf04ae4845cc747b5c1aaf/third_party/WebKit/Source/core/page/CreateWindow.cpp [modify] https://crrev.com/c631cd11f112484251cf04ae4845cc747b5c1aaf/third_party/WebKit/Source/core/page/FrameTree.cpp
,
Mar 31 2017
,
Apr 4 2017
Tested the issue on Windows 7 and Mac 10.12.3 using chrome version 59.0.3061.3 with the sample test file from comment #3.Observed all the links opened in new tab only. Please find the attached screen cast for the same. Adding TE-Verified labels. Thanks, |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by rsesek@chromium.org
, Mar 16 2017