New issue
Advanced search Search tips

Issue 702171 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 705306
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

DevToolsBeforeUnloadTest.TestUndockedDevToolsApplicationClose flaky on Win7 Tests (dbg) bot

Project Member Reported by guidou@chromium.org, Mar 16 2017

Issue description

See:
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/58148
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/58155

Sample logs:
DevToolsBeforeUnloadTest.TestUndockedDevToolsApplicationClose (run #1):
[ RUN      ] DevToolsBeforeUnloadTest.TestUndockedDevToolsApplicationClose
[1444:5340:0315/185656.336:INFO:media_foundation_video_encode_accelerator_win.cc(329)] Windows versions earlier than 8 are not supported.
[1444:5340:0315/185656.337:INFO:media_foundation_video_encode_accelerator_win.cc(329)] Windows versions earlier than 8 are not supported.
HTTP server started on http://127.0.0.1:58422...
sending server_data: {"host": "127.0.0.1", "port": 58422} (36 bytes)
c:\c\win\src\chrome	estase\ui_test_utils.cc(117): error: Value of: dialog_
  Actual: false
Expected: true
Backtrace:
	DevToolsBeforeUnloadTest::GetDialog [0x0072F335+37]
	DevToolsBeforeUnloadTest::AcceptModalDialog [0x0072DFA1+17]
	DevToolsBeforeUnloadTest::RunBeforeUnloadSanityTest [0x0073088A+282]
	DevToolsBeforeUnloadTest_TestUndockedDevToolsApplicationClose_Test::RunTestOnMainThread [0x0073144C+44]
	InProcessBrowserTest::RunTestOnMainThreadLoop [0x024A9E8D+605]
	content::BrowserTestBase::ProxyRunTestOnMainThreadLoop [0x035721F0+224]
	??$Invoke@PAVBrowserTestBase@content@@$$V@?$FunctorTraits@P8BrowserTestBase@content@@AEXXZX@internal@base@@SAXP8BrowserTestBase@content@@AEXXZ$$QAPAV34@@Z [0x03571582+18]
	base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall content::BrowserTestBase::*const &)(void),content::BrowserTestBase *> [0x03571654+36]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::BrowserTestBase::*)(void),base::internal::UnretainedWrapper<content::BrowserTestBase> >,void __cdecl(void)>::RunImpl<void (__thiscall content::BrowserTestBase::*const &)(void),std [0x0357175B+59]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::BrowserTestBase::*)(void),base::internal::UnretainedWrapper<content::BrowserTestBase> >,void __cdecl(void)>::Run [0x03572574+36]
	base::internal::RunMixin<base::Callback<void __cdecl(void),1,1> >::Run [0x0061107F+63]
	ChromeBrowserMainParts::PreMainMessageLoopRunImpl [0x030198E7+5575]
	ChromeBrowserMainParts::PreMainMessageLoopRun [0x030182C4+244]
	content::BrowserMainLoop::PreMainMessageLoopRun [0x1195C137+215]
	??$Invoke@PAVBrowserMainLoop@content@@$$V@?$FunctorTraits@P8BrowserMainLoop@content@@AEHXZX@internal@base@@SAHP8BrowserMainLoop@content@@AEHXZ$$QAPAV34@@Z [0x11950212+18]
	base::internal::InvokeHelper<0,int>::MakeItSo<int (__thiscall content::BrowserMainLoop::*const &)(void),content::BrowserMainLoop *> [0x119507E4+36]
	base::internal::Invoker<base::internal::BindState<int (__thiscall content::BrowserMainLoop::*)(void),base::internal::UnretainedWrapper<content::BrowserMainLoop> >,int __cdecl(void)>::RunImpl<int (__thiscall content::BrowserMainLoop::*const &)(void),std::t [0x11950C5B+59]
	base::internal::Invoker<base::internal::BindState<int (__thiscall content::BrowserMainLoop::*)(void),base::internal::UnretainedWrapper<content::BrowserMainLoop> >,int __cdecl(void)>::Run [0x1195C774+36]
	base::internal::RunMixin<base::Callback<int __cdecl(void),1,1> >::Run [0x125BFF5F+63]
	content::StartupTaskRunner::RunAllTasksNow [0x1260195E+110]
	content::BrowserMainLoop::CreateStartupTasks [0x11958209+569]
	content::BrowserMainRunnerImpl::Initialize [0x11962B75+981]
	content::BrowserMain [0x1194D5DF+95]
	content::RunNamedProcessTypeMain [0x132C5727+135]
	content::ContentMainRunnerImpl::Run [0x132C5605+405]
	content::ContentMain [0x132C3784+100]
	content::BrowserTestBase::SetUp [0x03572B66+1430]
	InProcessBrowserTest::SetUp [0x024AA375+741]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x036CAC04+52]
	testing::Test::Run [0x036DE17D+77]
	testing::TestInfo::Run [0x036DE3CD+173]
	testing::TestCase::Run [0x036DE2AF+191]
	testing::internal::UnitTestImpl::RunAllTests [0x036DE7D5+661]
	testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x036CACC4+52]
	testing::UnitTest::Run [0x036DE50F+207]
	RUN_ALL_TESTS [0x024DBC4F+15]
	base::TestSuite::Run [0x024DBD53+115]
	ChromeTestSuiteRunner::RunTestSuite [0x0605649A+42]
	ChromeTestLauncherDelegate::RunTestSuite [0x06056462+34]
	content::LaunchTests [0x0355CE1F+431]
	LaunchChromeTests [0x06056420+96]
	main [0x060560E9+89]
	invoke_main [0x06054A8E+30] (f:\ddctools\crtcstartup\src\startup\exe_common.inl:64)
	__scrt_common_main_seh [0x06054990+336] (f:\ddctools\crtcstartup\src\startup\exe_common.inl:253)
	__scrt_common_main [0x0605483D+13] (f:\ddctools\crtcstartup\src\startup\exe_common.inl:296)
	mainCRTStartup [0x06054AA8+8] (f:\ddctools\crtcstartup\src\startup\exe_main.cpp:17)
	BaseThreadInitThunk [0x75CD338A+18]
	RtlInitializeExceptionChain [0x77D49F72+99]
	RtlInitializeExceptionChain [0x77D49F45+54]
 

Comment 1 by guidou@chromium.org, Mar 16 2017

Summary: DevToolsBeforeUnloadTest.TestUndockedDevToolsApplicationClose flaky on Win7 Tests (dbg) bot (was: vToolsBeforeUnloadTest.TestUndockedDevToolsApplicationClose flaky on Win7 Tests (dbg) bot)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/863d4c79ad1ace6f225f125fb38cdd22ed5c5ed2

commit 863d4c79ad1ace6f225f125fb38cdd22ed5c5ed2
Author: guidou <guidou@chromium.org>
Date: Thu Mar 16 13:28:15 2017

Disable flaky DevToolsBeforeUnloadTest.TestUndockedDevToolsApplicationClose on Windows.

BUG= 702171 
TBR=pfeldman@chromium.org

Review-Url: https://codereview.chromium.org/2747293006
Cr-Commit-Position: refs/heads/master@{#457416}

[modify] https://crrev.com/863d4c79ad1ace6f225f125fb38cdd22ed5c5ed2/chrome/browser/devtools/devtools_sanity_browsertest.cc

Owner: nhiroki@chromium.org
Status: Assigned (was: Untriaged)
(Sheriff-Chromium) I'll disable the tests...
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b326e0b847c88c8ef6be8fb0e53b7109f5b5018

commit 2b326e0b847c88c8ef6be8fb0e53b7109f5b5018
Author: nhiroki <nhiroki@chromium.org>
Date: Fri Mar 17 02:33:50 2017

Disable flaky DevToolsBeforeUnloadTest.TestUndockedDevToolsApplicationClose on Linux

BUG= 702171 
TBR=pfeldman@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2756843002
Cr-Commit-Position: refs/heads/master@{#457661}

[modify] https://crrev.com/2b326e0b847c88c8ef6be8fb0e53b7109f5b5018/chrome/browser/devtools/devtools_sanity_browsertest.cc

Re c#6, "Disable flaky DevToolsBeforeUnloadTest.TestUndockedDevToolsClose on Linux" is correct (sorry)

I'm now making a patch to disable other tests, too...
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41b5fdf37917746450bd1b89127f98b80a8f66cf

commit 41b5fdf37917746450bd1b89127f98b80a8f66cf
Author: nhiroki <nhiroki@chromium.org>
Date: Fri Mar 17 03:35:12 2017

Disable flaky DevToolsBeforeUnloadTest.TestUndockedDevTools* tests

BUG= 702171 
TBR=pfeldman@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2756733004
Cr-Commit-Position: refs/heads/master@{#457674}

[modify] https://crrev.com/41b5fdf37917746450bd1b89127f98b80a8f66cf/chrome/browser/devtools/devtools_sanity_browsertest.cc

Labels: -Sheriff-Chromium
Owner: pfeldman@chromium.org
All flaky tests were disabled.

pfeldman@, could you triage this?
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2814cf2e4cc82c77b54d30e9b34287505edd8929

commit 2814cf2e4cc82c77b54d30e9b34287505edd8929
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Mar 17 10:07:47 2017

Disable DevToolsBeforeUnloadTest.TestUndockedDevToolsInspectedTabClose and DevToolsBeforeUnloadTest.TestDockedDevToolsInspectedBrowserClose on Win

BUG= 702171 
TBR=nhiroki@chromium.org

Review-Url: https://codereview.chromium.org/2756143002 .
Cr-Commit-Position: refs/heads/master@{#457729}

[modify] https://crrev.com/2814cf2e4cc82c77b54d30e9b34287505edd8929/chrome/browser/devtools/devtools_sanity_browsertest.cc

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/944aaecb9e6925dd90cec8c5b8d9505195a887e8

commit 944aaecb9e6925dd90cec8c5b8d9505195a887e8
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Mar 17 12:35:41 2017

Really disable DevToolsBeforeUnloadTest.TestUndockedDevToolsInspectedTabClose

BUG= 702171 
TBR=nhiroki@chromium.org

Review-Url: https://codereview.chromium.org/2753223003 .
Cr-Commit-Position: refs/heads/master@{#457742}

[modify] https://crrev.com/944aaecb9e6925dd90cec8c5b8d9505195a887e8/chrome/browser/devtools/devtools_sanity_browsertest.cc

 Bug 702767  looks related and it's a UAF. Should this be M59 + RBS?

Comment 13 by a...@chromium.org, Mar 28 2017

Mergedinto: 705306
Status: Duplicate (was: Assigned)

Sign in to add a comment