Issue metadata
Sign in to add a comment
|
Colors in theme ignored on windows vs White borders on Mac
Reported by
web.acce...@gmail.com,
Mar 16 2017
|
||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 Steps to reproduce the problem: 1. Install attached theme (blue-theme.zip) 2. Notice that on windows 10 the window title bar does not change What is the expected behavior? Windows title bar showing colors as defined in the theme. What went wrong? Actually this is a longer story: When you only define color values in a manifest file of a theme and do not supply image files for the frame, your theme shows these colors as expected on macOS&Linux. But on Windows 10 the default/native window title bar and colors are shown! All defined color values are ignored! (see blue-theme.zip). You can fix this for windows by supplying image files with solid colors. However, such a theme shows an ugly white border on top of the window title bar on macOS (see blue-theme-2.zip). Ideally, the color values should NOT be ignored on Windows 10 which would fix the issue. Right now, defining color values for the frame (active, inactive, incognito) is totally pointless on Windows. Alternativly, when supplying images with solid colors, NO ugly white border should be drawn on macOS! (Why is no such border drawn when you do not supply images?) I hope this is understandable. Thank you very much! Did this work before? N/A Does this work in other browsers? Yes Chrome version: 56.0.2924.87 Channel: n/a OS Version: 10 Flash Version: As a side note: Defining color values and supplying a transparent image for the frame as a workaround does not work: colors are just ignored on macOS. Can anyone think of another workaround?
,
Mar 16 2017
I filed the bug and just realized: There is actually another problem with themes on Windows vs themes on the Mac: If you install blue-theme-2.zip on a Mac, you will notice (1) the ugly white border AND (2) you will notice that the color of the frame is too bright, because the image is displayed with wrong (too bright) colors. Why is that?
,
Mar 21 2017
,
Apr 13 2017
Could you please check this issue on latest chrome stable-57.0.2987.133 or Canary-59.0.3069.0 and let us know your observations on the same. Thanks in advance!!
,
Apr 21 2017
@jmukthavaram@chromium.org: Sorry for my late response. I checked the issue in chrome 57 and 58 on Windows and macOS. But its still the same. Right now, you can't create themes with solid colors for the title bar without sacrifices. If you define colors only in the manifest and do not use any bitmaps, then these colors are ignored on Windows as if you wouldnt have any theme installed. That is, the theme looks good on macOS only. If you use bitmaps (with solid colors), then on macOS these colors are distorted (they look brighter) and you have a whitish upper edge in the title bar which looks ugly. That is, such a theme looks good on Windows only. Right now, the only solution would be to provide two themes: one for Windows and one for macOS. On Linux all themes look as expected.
,
Apr 21 2017
Thank you for providing more feedback. Adding requester "jmukthavaram@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 23 2017
,
May 4 2017
Able to reproduce the issue on Windows 10 with chrome stable #58.0.3029.96, Canary #60.0.3088.3 and also in earlier version M30-30.0.1599.0 This is a non-regression issue, hence marking it as untriaged. Observed that on loading "blue-theme" extension, the title bar has not turned into blue, whereas after loading "blue-theme-2" extension immediately title bar is turning into blue. Attaching the screen-cast for reference. Note: Not able to repro this issue on Ubuntu 14.04 and Mac 10.12.4
,
Jul 14 2017
@pkotwicz for triaging, also is UI>Browser>Themes the correct component?
,
Jul 17 2017
Yes, this is the right component. Assigning to estade@ who works on Chrome desktop UI (who is likely to get to this earlier than I am)
,
Jul 17 2017
over to bsep/pkasting for Windows theming
,
Jul 17 2017
This is either a dupe of bug 505013 or blocked on it.
,
Jul 17 2017
I've been using bug 554033 as the "Make Windows 10 themes better" bug so I'll dupe it there. Don't have any idea about the Mac-specific problems. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 Deleted