New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702148 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 701143



Sign in to add a comment

Add a LayoutTest for a partially loaded GIF

Project Member Reported by noel@chromium.org, Mar 16 2017

Issue description

Add a LayoutTest for a partially loaded GIF

We should add a test for a partially loaded animated GIF image.  Create a HTTP layout test using the load-and-stall script, crib from the following examples:

LayoutTests/http/tests/images/png-partial-load.html
LayoutTests/http/tests/images/jpeg-partial-load.html

The test should verify that the first frame of the GIF when partially received is rendered (partially), and that any background is visible in the undecoded regions of the first frame.
 

Comment 1 by noel@chromium.org, Mar 16 2017

Components: Blink>Image

Comment 2 by noel@chromium.org, Mar 16 2017

Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dd150883791d4d7aecf7bb93edb3f733fa11237

commit 7dd150883791d4d7aecf7bb93edb3f733fa11237
Author: noel <noel@chromium.org>
Date: Thu Mar 16 14:24:04 2017

Add a partial load test for an animated GIF image

Use HTTP test load-and-stall script to partially load the initial
frame of a animated GIF image.

Render the image over CSS background color green and confirm that
the CSS color appears in the undecoded regions of the image.

TBR=scroggo@chromium.org
BUG= 702148 

Review-Url: https://codereview.chromium.org/2756443005
Cr-Commit-Position: refs/heads/master@{#457428}

[modify] https://crrev.com/7dd150883791d4d7aecf7bb93edb3f733fa11237/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/7dd150883791d4d7aecf7bb93edb3f733fa11237/third_party/WebKit/LayoutTests/http/tests/images/gif-animated-partial-load.html

Comment 4 by noel@chromium.org, Mar 16 2017

Cc: scroggo@chromium.org

Comment 5 by noel@chromium.org, Mar 16 2017

Owner: noel@chromium.org

Comment 6 by noel@chromium.org, Mar 16 2017

Awaiting rebaselines ...
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d757cae1fb34145830714904a7cb83e5ac4b840c

commit d757cae1fb34145830714904a7cb83e5ac4b840c
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu Mar 16 16:02:13 2017

Auto-rebaseline for r457428

Build: https://build.chromium.org/p/chromium.infra.cron/builders/rebaseline-o-matic/builds/634117

https://chromium.googlesource.com/chromium/src/+/7dd150883791d

BUG= 702148 
TBR=noel@chromium.org

Review-Url: https://codereview.chromium.org/2747123006 .
Cr-Commit-Position: refs/heads/master@{#457450}

[modify] https://crrev.com/d757cae1fb34145830714904a7cb83e5ac4b840c/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/d757cae1fb34145830714904a7cb83e5ac4b840c/third_party/WebKit/LayoutTests/http/tests/images/gif-animated-partial-load-expected.png
[add] https://crrev.com/d757cae1fb34145830714904a7cb83e5ac4b840c/third_party/WebKit/LayoutTests/http/tests/images/gif-animated-partial-load-expected.txt
[add] https://crrev.com/d757cae1fb34145830714904a7cb83e5ac4b840c/third_party/WebKit/LayoutTests/platform/linux/http/tests/images/gif-animated-partial-load-expected.png
[add] https://crrev.com/d757cae1fb34145830714904a7cb83e5ac4b840c/third_party/WebKit/LayoutTests/platform/linux/virtual/mojo-loading/http/tests/images/gif-animated-partial-load-expected.png
[add] https://crrev.com/d757cae1fb34145830714904a7cb83e5ac4b840c/third_party/WebKit/LayoutTests/virtual/mojo-loading/http/tests/images/gif-animated-partial-load-expected.png

Comment 8 by noel@chromium.org, Mar 16 2017

Odd that the linux result is not the exactly the same, we'll let this run around
for many builds to see if linux wants to play up.

The result for all other bots:

third_party/WebKit/LayoutTests/http/tests/images/gif-animated-partial-load-expected.png

looks spot-on perfect.

Comment 9 by noel@chromium.org, Mar 16 2017

Seems to be stable on the test bots:
test-dashboard-gif-animated-partial-load.png
157 KB View Download

Comment 10 by noel@chromium.org, Mar 16 2017

Test result looks right, partial image decode region drawn and the green <img> CSS background is visible in the undecoded image regions.

gif-animated-partial-load-result.png
24.0 KB View Download

Comment 11 by noel@chromium.org, Mar 16 2017

Status: Fixed (was: Started)

Comment 12 by noel@chromium.org, Mar 16 2017

Blocking: 701143

Comment 13 by noel@chromium.org, Mar 17 2017

This to cover any changes in https://codereview.chromium.org/2749703002 and the patch split out from there.

Sign in to add a comment