New issue
Advanced search Search tips

Issue 702129 link

Starred by 1 user
Status: Fixed
Owner:
olivierrobin@chromium.org
Closed: Apr 2017
Cc:
mard...@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Refine ReadingList.OfflineVersionDisplayed histogram

Project Member Reported by olivierrobin@chromium.org, Mar 16 2017 
Current behavior is
- true: an offline page is displayed
- false: an online page is displayed (even if not in Reading List).

We may want to limit the false bucket to URLs in the Reading List.

Comment 1 by olivierrobin@chromium.org, Mar 23 2017 

ping mardini

Comment 2 by mard...@chromium.org, Mar 23 2017 

Correct. We should indeed limit the false bucket to URLs in the Reading List.

Comment 3 by olivierrobin@chromium.org, Mar 30 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4856780bb75144b6e7df21dcaead690da8e4d08a

commit 4856780bb75144b6e7df21dcaead690da8e4d08a
Author: olivierrobin <olivierrobin@chromium.org>
Date: Tue Apr 04 10:12:45 2017

Only report ReadingList.OfflineVersionDisplayed for URL in Reading List.

Previous behavior was to report for all pages.

BUG= 702129 

Review-Url: https://codereview.chromium.org/2791263002
Cr-Commit-Position: refs/heads/master@{#461674}

[modify] https://crrev.com/4856780bb75144b6e7df21dcaead690da8e4d08a/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm

Comment 5 by olivierrobin@chromium.org, Apr 4 2017

Status: Fixed (was: Started)
►

Sign in to add a comment