New issue
Advanced search Search tips

Issue 702126 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"ServiceWorkerTest.WorkerRefCount" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 16 2017

Issue description

"ServiceWorkerTest.WorkerRefCount" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiBTZXJ2aWNlV29ya2VyVGVzdC5Xb3JrZXJSZWZDb3VudAw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Components: Blink>ServiceWorker
Components: Platform>Extensions>API
Owner: lazyboy@chromium.org
Status: Assigned (was: Untriaged)
(Sheriff-Chromium)

This test is for Extension APIs. Added the proper label.

lazyboy@, could you handle this? For now, I'll mark this as DISABLED.
Hmmm... according to the flakiness dashboard, this test sometimes failed and then passed, but I couldn't find a mark of such the failure from outputs...
^^^ dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests (with patch)&tests=ServiceWorkerTest.WorkerRefCount
Labels: -Sheriff-Chromium
Project Member

Comment 6 by chromium...@appspot.gserviceaccount.com, Mar 19 2017

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "ServiceWorkerTest.WorkerRefCount". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiBTZXJ2aWNlV29ya2VyVGVzdC5Xb3JrZXJSZWZDb3VudAw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 7 by chromium...@appspot.gserviceaccount.com, Mar 20 2017

Detected 3 new flakes for test/step "ServiceWorkerTest.WorkerRefCount". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiBTZXJ2aWNlV29ya2VyVGVzdC5Xb3JrZXJSZWZDb3VudAw. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 8 by chromium...@appspot.gserviceaccount.com, Mar 23 2017

Detected 4 new flakes for test/step "ServiceWorkerTest.WorkerRefCount". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiBTZXJ2aWNlV29ya2VyVGVzdC5Xb3JrZXJSZWZDb3VudAw. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 9 by chromium...@appspot.gserviceaccount.com, Mar 25 2017

Detected 3 new flakes for test/step "ServiceWorkerTest.WorkerRefCount". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiBTZXJ2aWNlV29ya2VyVGVzdC5Xb3JrZXJSZWZDb3VudAw. This message was posted automatically by the chromium-try-flakes app.
Labels: -Sheriff-Chromium
Project Member

Comment 11 by chromium...@appspot.gserviceaccount.com, Mar 27 2017

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "ServiceWorkerTest.WorkerRefCount". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiBTZXJ2aWNlV29ya2VyVGVzdC5Xb3JrZXJSZWZDb3VudAw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
Project Member

Comment 13 by chromium...@appspot.gserviceaccount.com, Apr 4 2017

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "ServiceWorkerTest.WorkerRefCount". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyKwsSBUZsYWtlIiBTZXJ2aWNlV29ya2VyVGVzdC5Xb3JrZXJSZWZDb3VudAw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
I'm going to disable the test for now since it has been flaking for the last three weeks. lazyboy@, when you get a chance please have a look to see if you can resolve the flakiness.
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/721dc720dd05224a1e0968f77d47372601c0164b

commit 721dc720dd05224a1e0968f77d47372601c0164b
Author: timloh <timloh@chromium.org>
Date: Tue Apr 04 09:00:47 2017

Disable flaky test ServiceWorkerTest.WorkerRefCount on Linux

The test ServiceWorkerTest.WorkerRefCount has been flaky on Linux for
the last three weeks.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=WorkerRefCount

TBR=lazyboy
BUG= 702126 

Review-Url: https://codereview.chromium.org/2797663002
Cr-Commit-Position: refs/heads/master@{#461665}

[modify] https://crrev.com/721dc720dd05224a1e0968f77d47372601c0164b/chrome/browser/extensions/service_worker_apitest.cc

Labels: -Sheriff-Chromium
I've tried to reproduce the flake locally yesterday but no luck.
Will keep looking.
(blink-worker triage)
re c#17: Could you reproduce it?
Labels: -Pri-1 Pri-2
Downgrading priority since the test was disabled.
Project Member

Comment 20 by bugdroid1@chromium.org, Aug 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b57c9753a6187ac1f118d6935493c58d0aecd424

commit b57c9753a6187ac1f118d6935493c58d0aecd424
Author: Istiaque Ahmed <lazyboy@chromium.org>
Date: Sun Aug 20 19:08:57 2017

Deflake and enable ServiceWorkerTest.WorkerRefCount.

There are two fixes:
  - JS should have sent SUCCESS message after two messages from worker, it
    incorrectly sent SUCCESS on each of those messages. Fix it.
  - Decrement ref count message initiated from renderer/ asynchronously
    reaches IO thread. Previously GetWorkerRefCount could have inspected
    the ref count even before the IPC reaches IO thread on the browser/.
    Make sure we wait for those IPCs to arrive in the browser/ process.

Bug:  702126 
Change-Id: I67a10f4371b4f9831ec2bb74b126f89ccc190f48
Reviewed-on: https://chromium-review.googlesource.com/620307
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495845}
[modify] https://crrev.com/b57c9753a6187ac1f118d6935493c58d0aecd424/chrome/browser/extensions/service_worker_apitest.cc
[modify] https://crrev.com/b57c9753a6187ac1f118d6935493c58d0aecd424/chrome/test/data/extensions/api_test/service_worker/api_worker_ref_count/page.js
[modify] https://crrev.com/b57c9753a6187ac1f118d6935493c58d0aecd424/chrome/test/data/extensions/api_test/service_worker/api_worker_ref_count/sw.js

Status: Fixed (was: Assigned)

Sign in to add a comment