Issue metadata
Sign in to add a comment
|
Many Files app browser tests are flaky. |
||||||||||||||||||||||
Issue descriptionMany flaky tests are reported recently. Issue 699534 Issue 699978 Issue 700156 Issue 699083 Issue 698834 Issue 698772 Issue 699171 Issue 699426 Issue 701922 Issue 701923 We'll disable them, but I guess there is an issue which makes all Files app browser tests flaky. Since we are losing many protections for Files app by disabling these test, we need to investigate the root cause asap and bring back the tests.
,
Mar 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/633ac075e5897f9ed9bf928e004658833447a4f1 commit 633ac075e5897f9ed9bf928e004658833447a4f1 Author: fukino <fukino@chromium.org> Date: Thu Mar 16 12:05:10 2017 Disable flaky tests in Chrome OS file manager. Though there seems to be a shared issue which makes many tests flaky, we should disable each one for now not to slow down the CQ. BUG= 702119 , 699534 , 699978 , 700156 , 699083 , 698834 , 698772 , 699171 TEST=none Review-Url: https://codereview.chromium.org/2754003003 Cr-Commit-Position: refs/heads/master@{#457400} [modify] https://crrev.com/633ac075e5897f9ed9bf928e004658833447a4f1/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Mar 16 2017
The logs contain suspicious line "ALSA lib confmisc.c:768:(parse_card) cannot find card '0'", but it might be a red herring. https://bugs.chromium.org/p/chromium/issues/detail?id=472083
,
Mar 17 2017
According to the Flakiness dashboard (https://test-results.appspot.com/dashboards/flakiness_dashboard.html) following tests are flaky too. I'll disable them. FolderShortcuts/FileManagerBrowserTest.Test/1 Providers/FileManagerBrowserTest.Test/3 ShareDialog/FileManagerBrowserTest.Test/1 ShareDialog/FileManagerBrowserTest.
,
Mar 17 2017
FolderShortcuts/FileManagerBrowserTest.Test/1 Providers/FileManagerBrowserTest.Test/3 ShareDialog/FileManagerBrowserTest.Test/1 ShareDialog/FileManagerBrowserTest.Test/0
,
Mar 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1025d669c602e25b072bcc1632cfe4845af1d9f4 commit 1025d669c602e25b072bcc1632cfe4845af1d9f4 Author: fukino <fukino@chromium.org> Date: Tue Mar 21 04:59:25 2017 Disable flaky tests in Chrome OS file manager. BUG= 702119 TEST=none TBR=oka@chromium.org Review-Url: https://codereview.chromium.org/2758743002 Cr-Commit-Position: refs/heads/master@{#458312} [modify] https://crrev.com/1025d669c602e25b072bcc1632cfe4845af1d9f4/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
Mar 22 2017
I'm suspecting Issue 701601 causes this flakiness on browser tests. As the fix has landed, maybe it's work revising these browser tests and monitoring the flakiness dashboard.
,
Mar 28 2017
Could you revive the tests? I think it's important to previent regression.
,
Mar 29 2017
Yes I'll do it after stress tests.
,
Apr 3 2017
Hmm... It seems FileManager tests are still flaky.
During a stress test, following tests failed at least once.
There seems another issue which makes Files app flaky.
CreateNewFolder/FileManagerBrowserTest.Test/0
CreateNewFolder/FileManagerBrowserTest.Test/2
CreateNewFolder/FileManagerBrowserTest.Test/3
DefaultTaskDialog/FileManagerBrowserTest.Test/0
DefaultTaskDialog/FileManagerBrowserTest.Test/2
Delete/FileManagerBrowserTest.Test/0
Delete/FileManagerBrowserTest.Test/1
DriveSpecific/FileManagerBrowserTest.Test/0
DriveSpecific/FileManagerBrowserTest.Test/1
DriveSpecific/FileManagerBrowserTest.Test/2
DriveSpecific/FileManagerBrowserTest.Test/3
DriveSpecific/FileManagerBrowserTest.Test/4
DriveSpecific/FileManagerBrowserTest.Test/5
DriveSpecific/FileManagerBrowserTest.Test/6
ExecuteDefaultTaskOnDownloads/FileManagerBrowserTest.Test/0
ExecuteDefaultTaskOnDownloads/FileManagerBrowserTest.Test/1
ExecuteDefaultTaskOnDrive/FileManagerBrowserTest.Test/0
FileDisplay/FileManagerBrowserTest.Test/0
FileDisplay/FileManagerBrowserTest.Test/2
FileDisplay/FileManagerBrowserTest.Test/3
FileDisplay/FileManagerBrowserTest.Test/4
FileDisplay/FileManagerBrowserTest.Test/5
FileDisplay/FileManagerBrowserTest.Test/6
FolderShortcuts/FileManagerBrowserTest.Test/0
GearMenu/FileManagerBrowserTest.Test/0
GearMenu/FileManagerBrowserTest.Test/1
GearMenu/FileManagerBrowserTest.Test/2
GenericTask/FileManagerBrowserTest.Test/0
KeyboardOperations/FileManagerBrowserTest.Test/1
KeyboardOperations/FileManagerBrowserTest.Test/10
KeyboardOperations/FileManagerBrowserTest.Test/11
KeyboardOperations/FileManagerBrowserTest.Test/2
KeyboardOperations/FileManagerBrowserTest.Test/4
KeyboardOperations/FileManagerBrowserTest.Test/5
KeyboardOperations/FileManagerBrowserTest.Test/6
KeyboardOperations/FileManagerBrowserTest.Test/7
KeyboardOperations/FileManagerBrowserTest.Test/8
KeyboardOperations/FileManagerBrowserTest.Test/9
NAYBE_TabindexFocusDownloads/FileManagerBrowserTestWithLegacyEventDispatch.Test/0
OpenAudioFiles/FileManagerBrowserTest.Test/0
OpenAudioFiles/FileManagerBrowserTest.Test/1
OpenAudioFiles/FileManagerBrowserTest.Test/2
OpenAudioFiles/FileManagerBrowserTest.Test/3
OpenAudioFiles/FileManagerBrowserTest.Test/4
OpenAudioFiles/FileManagerBrowserTest.Test/5
OpenAudioFiles/FileManagerBrowserTest.Test/6
OpenAudioFiles/FileManagerBrowserTest.Test/7
OpenAudioFiles/FileManagerBrowserTest.Test/8
OpenFileDialog/FileManagerBrowserTest.Test/0
OpenFileDialog/FileManagerBrowserTest.Test/1
OpenFileDialog/FileManagerBrowserTest.Test/2
OpenFileDialog/FileManagerBrowserTest.Test/5
OpenImageFiles/FileManagerBrowserTest.Test/1
OpenImageFiles/FileManagerBrowserTest.Test/2
OpenVideoFiles/FileManagerBrowserTest.Test/1
OpenVideoFiles/FileManagerBrowserTest.Test/2
Providers/FileManagerBrowserTest.Test/0
Providers/FileManagerBrowserTest.Test/1
Providers/FileManagerBrowserTest.Test/2
Providers/FileManagerBrowserTest.Test/3
RestoreGeometry/FileManagerBrowserTest.Test/0
RestoreGeometry/FileManagerBrowserTest.Test/2
RestorePrefs/FileManagerBrowserTest.Test/1
RestorePrefs/FileManagerBrowserTest.Test/3
ShareDialog/FileManagerBrowserTest.Test/0
ShareDialog/FileManagerBrowserTest.Test/1
ShowGridView/FileManagerBrowserTest.Test/0
ShowGridView/FileManagerBrowserTest.Test/2
SortColumns/FileManagerBrowserTest.Test/0
SortColumns/FileManagerBrowserTest.Test/1
SuggestAppDialog/FileManagerBrowserTest.Test/0
TabIndex/FileManagerBrowserTestWithLegacyEventDispatch.Test/0
TabindexFocus/FileManagerBrowserTestWithLegacyEventDispatch.Test/0
TabindexFocusDirectorySelected/FileManagerBrowserTestWithLegacyEventDispatch.Test/0
TabindexOpenDialog/FileManagerBrowserTest.Test/0
TabindexOpenDialog/FileManagerBrowserTest.Test/1
TabindexOpenDialog/FileManagerBrowserTest.Test/2
Transfer/FileManagerBrowserTest.Test/0
Transfer/FileManagerBrowserTest.Test/1
Transfer/FileManagerBrowserTest.Test/2
Transfer/FileManagerBrowserTest.Test/3
Transfer/FileManagerBrowserTest.Test/4
Transfer/FileManagerBrowserTest.Test/5
Transfer/FileManagerBrowserTest.Test/6
Transfer/FileManagerBrowserTest.Test/7
Traverse/FileManagerBrowserTest.Test/1
Traverse/FileManagerBrowserTest.Test/2
,
Apr 3 2017
Can you post the instructions for reproducing the "stress" test locally? I will try and see if it is still GC related. (At conference right now, so this will take a bit.)
,
Apr 4 2017
Thank you mlippautz@ for the help! As tests which don't touch the context menu also fail, I guess Files app itself has an issue. I did the test by running browser tests repeatedly. out/Release/browser_tests --gtest_filter=*FileManager* --gtest_repeat=20 (It can take more than 1 hour even on Z840)
,
Apr 5 2017
tetsui@ is looking into the flakiness.
,
Apr 6 2017
I found many of them did not reproduce on the latest master. However, some tests are still failing. I tried the following command locally on commit 421f86bb22686a086062ffde46fb746039dd2490 with the patch https://crrev.com/2801573002/ out/Release/browser_tests --gtest_repeat=100 '--gtest_filter=*FileManager*' Following tests failed, but others succeeded. MultiProfileFileManagerBrowserTest.PRE_BasicDrive OpenFileDialog/FileManagerBrowserTest.Test/3 OpenImageFiles/FileManagerBrowserTest.Test/1
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54a3dd064413a8d341253c27cb944ba739acba2c commit 54a3dd064413a8d341253c27cb944ba739acba2c Author: tetsui <tetsui@google.com> Date: Tue Apr 11 01:50:55 2017 Enable once flaky tests in Chrome OS file manager. These tests were previously flaky and there seems to be a shared issue. However, they do not reproduce anymore on the latest master branch. It reproduced on commit a2b501b65e0987b4f2a23561a4906eb02f955a40 and it did not reproduce on 577b8f369864082950e5922472780e54317ea2ac. BUG= 699426 , 700156 , 699083 , 698834 , 702119 , 701923 , 699171 , 699978 , 702119 , 699534 , 615259 , 698772 TEST=none TBR=fukino@chromium.org Review-Url: https://codereview.chromium.org/2801573002 Cr-Commit-Position: refs/heads/master@{#463493} [modify] https://crrev.com/54a3dd064413a8d341253c27cb944ba739acba2c/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
,
May 31 2017
Most of the tests mentioned in this bug is not flaky now, so common underlying issue mentioned in #0 seems to be resolved.
,
Aug 1 2017
,
Jan 22 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by fukino@chromium.org
, Mar 16 2017