New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 702102 link

Starred by 1 user
Status: Fixed
Owner:
est...@chromium.org
Closed: Jun 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
est...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression:UI issue is observed for 'discard' button in download bar after installing theme.

Reported by vku...@etouch.net, Mar 16 2017 
Chrome Version: 59.0.3043.0 (Official Build) fe785a58e31217e1ef0e1c8946a4e853829371f8-refs/heads/master@{#457297} (32/64 bit)
OS:Windows (7,8,10)


What steps will reproduce the problem?
(1)Launch chrome and install theme 'earth in space' from https://chrome.google.com/webstore/category/themes?hl=en
(2)Open new tab page and navigate to http://www.provos.org/tmp/content.exe
(3)Observe the 'discard' button in download bar.

Actual: UI issue is observed for 'discard' button in download bar after installing theme.

Expected: UI issue should not be seen for 'discard' button in download bar after installing theme.

This is a regression issue broken in 'M56' and below is the manual regression range
Good Build: 56.0.2897.0
Bad Build:  56.0.2899.0 

Note: Issue not seen on Mac & Linux OS.
ActualTheme.mp4
1022 KB View Download
ExpectedTheme.mp4
473 KB View Download

Comment 1 by rbasuvula@chromium.org, Mar 16 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)
Actual : After mouse hover on "Discard" button color is changing when theme set to default.

Using the per-revision bisect providing the bisect results,
Good build:56.0.2897.0 (Revision:426673).
Bad build:56.0.2899.0 (Revision:426989).

You are probably looking for a change made after 426827 (known good), but no later than 426828 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/8975b80a50bb91c4723c8fc29a871a940b7fdb2f..c9ac8cf058d18afc6ab23455560da81bc2154c35

From the CL above, assigning the issue to the concern owner

@estade : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url: https://chromiumcodereview.appspot.com/2439873002
Note: Windows specific issue and able to reproduce the issue in latest canary #59.0.3043.0

Comment 2 by est...@chromium.org, Mar 16 2017 

I'm not really sure what you're calling a "ui issue" here. On trunk I don't see the problem of not repainting till hover.

Comment 3 by jmukthavaram@chromium.org, Apr 5 2017 

Friendly ping!!
estade@,
Still we are able to reproduce the issue on latest Canary-59.0.3063.0 .Could you please check the issue & update the thread accordingly.
Thank you!!

Comment 4 by jmukthavaram@chromium.org, Apr 13 2017 

estade@, Gentle ping to get an update on this issue since we are able to reproduce the issue on latest Canary-59.0.3069.0.

Thank you!!
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88f31457146e38cec7f095276fb9741056cefdb8

commit 88f31457146e38cec7f095276fb9741056cefdb8
Author: Evan Stade <estade@chromium.org>
Date: Thu Jun 01 15:53:57 2017

Repaint MdTextButton after updating colors.

Bug:  702102 
Change-Id: I2fd9c78208b95b9401f8099e2311b595817670ee
Reviewed-on: https://chromium-review.googlesource.com/520182
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476308}
[modify] https://crrev.com/88f31457146e38cec7f095276fb9741056cefdb8/ui/views/controls/button/md_text_button.cc

Comment 6 by est...@chromium.org, Jun 1 2017

Labels: -Pri-1 Pri-2
Status: Fixed (was: Assigned)
fixed, but I don't think it's worth worrying about merging.
►

Sign in to add a comment