New issue
Advanced search Search tips

Issue 702097 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Task

Blocking:
issue 670237



Sign in to add a comment

Enable FasterLocationReload feature by default on beta

Project Member Reported by toyoshim@chromium.org, Mar 16 2017

Issue description

This is a dummy bug entry to request merge approval.

Now the feature is rolled out via experimental-controls on the stable channel of 57.

As the last step of the launch process, I flipped the flag in the source code to enable the feature by default on ToT. I'd merge this change to the beta channel as the launch process explains.
 
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc7bbd667335209110948cd2f07b4e3b7f44b56c

commit bc7bbd667335209110948cd2f07b4e3b7f44b56c
Author: toyoshim <toyoshim@chromium.org>
Date: Thu Mar 16 04:05:54 2017

Enable FasterLocationReload feature by default

As a third step of experiment-controlled rollouts, enable
FasterLocationReload feature by default for trunk.

BUG=591245

Review-Url: https://codereview.chromium.org/2747413002
Cr-Commit-Position: refs/heads/master@{#457346}

[modify] https://crrev.com/bc7bbd667335209110948cd2f07b4e3b7f44b56c/content/public/common/content_features.cc

----
This is the change I want to merge to beta.
Copied from https://bugs.chromium.org/p/chromium/issues/detail?id=591245#c37
If this merge request is approved, the dashboard (https://www.chromestatus.com/feature/5724282256621568) should be updated to reflect this merge.
Labels: Reload
Please add applicable OSs.  Thanks.
Labels: OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 17 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Your change is approved for M58. Please merge ASAP so that it will be picked up for next Beta Release, RC cut on (Monday-03/20) at 5.00 PM PST.
Project Member

Comment 8 by sheriffbot@chromium.org, Mar 20 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Gentle Ping for merge.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 21 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d638e22ec6543d3484de4279b2614b4626973b99

commit d638e22ec6543d3484de4279b2614b4626973b99
Author: toyoshim <toyoshim@chromium.org>
Date: Tue Mar 21 07:10:05 2017

Enable FasterLocationReload feature by default

As a third step of experiment-controlled rollouts, enable
FasterLocationReload feature by default for trunk.

BUG= 702097 ,591245

TBR=kinuko@chromium.org
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2747413002
Cr-Commit-Position: refs/heads/master@{#457346}
(cherry picked from commit bc7bbd667335209110948cd2f07b4e3b7f44b56c)

Review-Url: https://codereview.chromium.org/2765803002
Cr-Commit-Position: refs/branch-heads/3029@{#320}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/d638e22ec6543d3484de4279b2614b4626973b99/content/public/common/content_features.cc

Sorry, it was a corp holiday yesterday.

I just merged the CL to the branch 3029, but it is probably after the RC cut.
Should I take another action to reflect this change?
Status: Fixed (was: Started)
Assuming that the merge will catch the next train.
Components: UI>Browser>Navigation Blink>Loader

Sign in to add a comment