New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 702093 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Mar 2017
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression

Blocking:
issue 671375



Sign in to add a comment

Regression: Misalignment is observed on Sample text for 'Minimum font size' when slider is dragged towards RHS.

Reported by dmascare...@etouch.net, Mar 16 2017 
Chrome Version: 59.0.3043.0 (Official Build) fe785a58e31217e1ef0e1c8946a4e853829371f8-refs/heads/master@{#457297}
OS : Windows (7,8,10)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://md-settings/fonts.
2. Drag the slider towards RHS of 'Minimum font size' option (i.e. Size above 15),observe.

Actual : Sample text for 'Minimum font size' is misaligned when slider dragged towards RHS. (i.e. Misalignment between numeric value and colon) 
Expected : Misalignment should not be seen.

This is a regression issue broken in ‘M-59’, below is the Manual Regression range.
Good build : 59.0.3042.0
Bad build : 59.0.3043.0

Note: Will soon update the other OS info.
Actual_1.png
35.4 KB View Download

Comment 1 by rbasuvula@chromium.org, Mar 16 2017

Cc: rbasuvula@chromium.org
Labels: hasbisect-per-revision
Owner: dschuyler@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:59.0.3042.0 (Revision:456934).
Bad build:59.0.3043.0 (Revision:457297).

You are probably looking for a change made after 457279 (known good), but no later than 457280 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/f35a8655b34c3117793502c936f619a5317bff02..566e65ab665604104285fc725c65753423b1cb92

From the CL above, assigning the issue to the concern owner

@dschuyler : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:https://codereview.chromium.org/2751063003
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #59.0.3043.0

Comment 2 by dschuyler@chromium.org, Mar 16 2017

Blocking: 671375

Comment 3 by dschuyler@chromium.org, Mar 16 2017

Status: Started (was: Assigned)

Comment 5 by dschuyler@chromium.org, Mar 16 2017 

screen shot of "fixed" version
Screenshot from 2017-03-16 13:43:02.png
32.7 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bb896d38e5404ae87b613e7f55e876e594d78ad

commit 5bb896d38e5404ae87b613e7f55e876e594d78ad
Author: dschuyler <dschuyler@chromium.org>
Date: Fri Mar 17 20:46:38 2017

[MD settings] align minimum font size on example

This CL removes a <span> so that the font size number is aligned with
the font example text.

BUG= 702093 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2751253003
Cr-Commit-Position: refs/heads/master@{#457879}

[modify] https://crrev.com/5bb896d38e5404ae87b613e7f55e876e594d78ad/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html

Comment 7 by dschuyler@chromium.org, Mar 17 2017

Status: Fixed (was: Started)

Comment 8 by jmukthavaram@chromium.org, Mar 21 2017

Labels: TE-Verified-M59 TE-Verified-59.0.3047.0
Tested the issue on windows 7 using chrome version#59.0.3047.0 with the steps mentioned in comment #0.Observed that the Sample text for 'Minimum font size' is aligned properly when slider dragged towards RHS i.e alignment between numeric value and colon is displayed intended. Hence adding TE-Verified labels.
Please find the attached screen cast for the same.
Thanks!!
702093.mp4
798 KB View Download
►

Sign in to add a comment