Issue metadata
Sign in to add a comment
|
Regression: Spell check appears enabled after opening custom spelling dictionary subpage
Reported by
mni...@etouch.net,
Mar 16 2017
|
||||||||||||||||||||||
Issue descriptionVersion: 57.0.2987.110 11f66db67ea1f20d200d6f9add50fc1c345d71f7-refs/branch-heads/2987@{#832} OS: Windows (7,8,8.1,10),Linux (14.04 LTS) What steps will reproduce the problem? 1. Freshly launch chrome and navigate to chrome://md-settings 2. Now scroll down the page and click on 'Advanced' and go to 'Languages' 3. Now click on 'Spell check' to expand it and then click on 'custom spelling' to open 'Manage spell check' overlay and then click on back navigation arrow, immediately observe below options like 'Downloads' etc Actual: Unnecessary movement of options(like Downloads) below 'Spell check' is seen after click on back navigation arrow Expected: Unnecessary movement of options(like Downloads) below 'Spell check' should not be seen after click on back navigation arrow This is regression issue, broken in ‘M 57’ and will soon update other info : Good build:57.0.2945.0 Bad build: 57.0.2946.0 Note : Issue is not seen on Mac OS.
,
Mar 28 2017
I'm unable to reproduce this in 57 or Canary. Does it still repro? dschuyler: maybe an overscroll recalculation bug, since a card is expanding? :-\
,
Apr 6 2017
With response to comment #1 : Rechecked the above issue on Windows OS with latest canary chrome version : 59.0.3064.0 and the issue is still reproduced.Kindly refer the attached screen cast for reference. Note : Issue is reproduced on fresh install of chrome at first instance. Re bisected the issue and getting same bisect range. Narrow Bisect info : https://chromium.googlesource.com/chromium/src/+log/c3d5b3984f26d77db5042b7218404052c1ad4e7a..f8614e087b47efbc3f359234b461cd2d88833f8a?pretty=fuller&n=100 Suspecting: r437139 from Narrow bisect @michaelpg : Could you please help to reassign if your change is not the cause for this change.
,
Apr 6 2017
Thank you for the details. The difference in card size is because spell check appears enabled for en-US when opening the Edit Dictionary subpage -- which is definitely a bug. I can't fathom how opening the dictionary subpage would enable spellcheck. It does call languageSettingsPrivate.getSpellcheckWords, which is implemented at https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc?type=cs&q=%22getSpellcheckWords%22+file:%5C.cc&l=346 recent changes to spellchecker code: https://chromium.googlesource.com/chromium/src/+log/4e099370ea139acdc38a2efd3ee827aee7b445d0/chrome/browser/spellchecker The other possibility, which is more likely given this was a fresh install, is that spellcheck is already enabled by default for en-US, but for some reason, Settings is not showing it as enabled until this interaction happens. I'll look at this on Windows soon to verify the spellchecker state before and after.
,
Oct 4 2017
Bulk unassigning my language settings bugs as I am no longer working on Settings.
,
Oct 5
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 5
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mni...@etouch.net
, Mar 16 2017Owner: michae...@chromium.org
Status: Assigned (was: Unconfirmed)