New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 702070 link

Starred by 2 users
Status: Fixed
Owner:
█ allada@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

"Offline" network option out-of-sync between Application and Network panels

Reported by ja...@apphaus.co.uk, Mar 16 2017 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.98 Safari/537.36

Steps to reproduce the problem:
1. Open a webpage and open devtools
2. In the "Application" panel under "Service Workers", check "Offline"
3. In the "Network" panel, uncheck "Offline".
4. Note the application is still offline.

This can also be done in the "Network" panel first, where toggling "Offline" in the "Application" panel then has no impact.

What is the expected behavior?
That the "Offline" option is synchronised between the "Network" and "Application" panel, and that the option can be toggled from either.

What went wrong?
On the first toggle of the "Offline" checkbox, the offline emulation cannot then be toggled in the alternate panel (Network or Application). If the checkbox is toggled more than once in the same panel, then this issue appears to resolve itself.

Did this work before? N/A 

Chrome version: 57.0.2987.98  Channel: stable
OS Version: OS X 10.10.5
Flash Version: Shockwave Flash 25.0 r0

Comment 1 by brajkumar@chromium.org, Mar 16 2017

Labels: M-59 OS-Linux OS-Windows
Status: Untriaged (was: Unconfirmed)
Able to reproduce this issue on Ubuntu 14.04 and Windows-10 using chrome stable #57.0.2987.98 by following steps mentioned in the original comment, Observed the the offline option is not synchronised between the "Network" and "Application" panel.

This issue is observed in M52-52.0.2743.0 as well, There is no application panel was available previous to M52 builds. Considering this is a non-regression issue and marking it as untriaged.

Thanks!

Comment 2 by chenwilliam@chromium.org, Mar 17 2017

Components: -Platform>DevTools Platform>DevTools>Network
Owner: allada@chromium.org
Status: Assigned (was: Untriaged)
Able to repro on Linux 59.0.3045.0 (Developer Build) (64-bit).

Comment 3 by ja...@apphaus.co.uk, Mar 18 2017 

I hope I'm not stepping on other's toes, as I know this issue has been assigned. Curiosity took over and I have shared my findings in the form of a CL to Code Review (2757093002).
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e2177f8dde7e53ab585a1fb09dc3e69dd81c78b

commit 8e2177f8dde7e53ab585a1fb09dc3e69dd81c78b
Author: james <james@apphaus.co.uk>
Date: Wed Mar 22 09:34:38 2017

[Devtools] Fix offline checkbox state sharing across Network and Application>Service Workers panels

Fixes an issue where the last network condition prior to going offline was not shared between offline checkboxes (NetworkConditionsSelectors).

Due to this change, it is also no longer necessary for each NetworkConditionsSelector to update the state in the networkConditionsChanged() callback and so this has been removed.

BUG= 702070 

Review-Url: https://codereview.chromium.org/2757093002
Cr-Commit-Position: refs/heads/master@{#458699}

[modify] https://crrev.com/8e2177f8dde7e53ab585a1fb09dc3e69dd81c78b/third_party/WebKit/Source/devtools/front_end/network_conditions/NetworkConditionsSelector.js

Comment 5 by allada@chromium.org, Jul 20 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment