New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702064 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Direct-leak in FPDFAvail_Create

Project Member Reported by ClusterFuzz, Mar 16 2017

Issue description

Cc: msrchandra@chromium.org
Labels: M-57 Test-Predator-Correct-CLs
Owner: tsepez@chromium.org
Status: Assigned (was: Untriaged)
Assigning to the concern owner from Predator results --
The result is a list of CLs that change the crashed files. 

Author: tsepez
Project: chromium-pdfium
Changelist: https://pdfium.googlesource.com/pdfium.git/+/833619b4441915c7c55085d44b3221eaef0d9800
Time: Wed Dec 07 09:21:17 2016 -0800
Lines 122-125 of file fpdf_dataavail.cpp which potentially caused crash are changed in this cl (frame #1, "FPDFAvail_Create"; frame #2, "FPDFAvail_Create").
Minimum distance from crash line to modified line: 0. (file: fpdf_dataavail.cpp, crashed on: 122, modified: 122).

@tsepez -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e13fdde8bc0fbc7a85c7caa21fe2ff766ced836a

commit e13fdde8bc0fbc7a85c7caa21fe2ff766ced836a
Author: tsepez <tsepez@chromium.org>
Date: Fri Mar 17 19:06:45 2017

Avoid leaks in pdfium_fuzzer by using unique_ptr<>

BUG= 702064 

Review-Url: https://codereview.chromium.org/2746363009
Cr-Commit-Position: refs/heads/master@{#457838}

[modify] https://crrev.com/e13fdde8bc0fbc7a85c7caa21fe2ff766ced836a/pdf/pdfium/fuzzers/pdfium_fuzzer.cc

Comment 3 by tsepez@chromium.org, Mar 17 2017

Status: Fixed (was: Assigned)

Comment 4 by tsepez@chromium.org, Mar 17 2017

Cc: thestig@chromium.org dsinclair@chromium.org tsepez@chromium.org
 Issue 702054  has been merged into this issue.

Comment 5 by tsepez@chromium.org, Mar 17 2017

 Issue 702053  has been merged into this issue.
Project Member

Comment 6 by ClusterFuzz, Mar 21 2017

ClusterFuzz has detected this issue as fixed in range 457505:457874.

Detailed report: https://clusterfuzz.com/testcase?key=6569350195838976

Fuzzer: libfuzzer_pdfium_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  FPDFAvail_Create
  RenderPdf
  pdfium::internal::MakeUniqueResult<CPDF_DataAvail>::Scalar pdfium::MakeUnique<CP
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=436968:437035
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=457505:457874

Reproducer Testcase: https://clusterfuzz.com/download/AMIfv96n7cnR9_rbgVK4MIlmaWycPqKC3DKEthm2Jo9Kf3WHV4Amh9EwuEo9lEDrBppJ-sDtdjdpTbYMm6JC9y9HWQWDiSSlDINOvUcXyYmi_eorENwdW58RBbhXJfsuAG2a52vPE6vx6wddz5DnLcku805RJHteofjwKlJg8b7qbVaxNpQSm8aKeNytFyw2BEF9mexdWcd5LkAffWodTev9ooRqjH3LUlx_LxCJvwc9BCXU_tjGpv6xY3Ur5ke9UA170OuKEzw3CGrH89miV2ztkjsmI6IrM6zJdzDUdmGutRFw5p8Ag51w3JjRWqw2_-4kKF6rE8v_aZ9dY1MH6g4HzOPxW9P53IpMNDOH0GsWxQkTfv1azjc?testcase_id=6569350195838976


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Mar 21 2017

ClusterFuzz has detected this issue as fixed in range 457505:457874.

Detailed report: https://clusterfuzz.com/testcase?key=6569350195838976

Fuzzer: libfuzzer_pdfium_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  FPDFAvail_Create
  RenderPdf
  pdfium::internal::MakeUniqueResult<CPDF_DataAvail>::Scalar pdfium::MakeUnique<CP
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=436968:437035
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=457505:457874

Reproducer Testcase: https://clusterfuzz.com/download/AMIfv96n7cnR9_rbgVK4MIlmaWycPqKC3DKEthm2Jo9Kf3WHV4Amh9EwuEo9lEDrBppJ-sDtdjdpTbYMm6JC9y9HWQWDiSSlDINOvUcXyYmi_eorENwdW58RBbhXJfsuAG2a52vPE6vx6wddz5DnLcku805RJHteofjwKlJg8b7qbVaxNpQSm8aKeNytFyw2BEF9mexdWcd5LkAffWodTev9ooRqjH3LUlx_LxCJvwc9BCXU_tjGpv6xY3Ur5ke9UA170OuKEzw3CGrH89miV2ztkjsmI6IrM6zJdzDUdmGutRFw5p8Ag51w3JjRWqw2_-4kKF6rE8v_aZ9dY1MH6g4HzOPxW9P53IpMNDOH0GsWxQkTfv1azjc?testcase_id=6569350195838976


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Mar 21 2017

ClusterFuzz has detected this issue as fixed in range 457505:457874.

Detailed report: https://clusterfuzz.com/testcase?key=6569350195838976

Fuzzer: libfuzzer_pdfium_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  FPDFAvail_Create
  RenderPdf
  pdfium::internal::MakeUniqueResult<CPDF_DataAvail>::Scalar pdfium::MakeUnique<CP
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=436968:437035
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=457505:457874

Reproducer Testcase: https://clusterfuzz.com/download/AMIfv96n7cnR9_rbgVK4MIlmaWycPqKC3DKEthm2Jo9Kf3WHV4Amh9EwuEo9lEDrBppJ-sDtdjdpTbYMm6JC9y9HWQWDiSSlDINOvUcXyYmi_eorENwdW58RBbhXJfsuAG2a52vPE6vx6wddz5DnLcku805RJHteofjwKlJg8b7qbVaxNpQSm8aKeNytFyw2BEF9mexdWcd5LkAffWodTev9ooRqjH3LUlx_LxCJvwc9BCXU_tjGpv6xY3Ur5ke9UA170OuKEzw3CGrH89miV2ztkjsmI6IrM6zJdzDUdmGutRFw5p8Ag51w3JjRWqw2_-4kKF6rE8v_aZ9dY1MH6g4HzOPxW9P53IpMNDOH0GsWxQkTfv1azjc?testcase_id=6569350195838976


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Components: Internals>Plugins>PDF

Sign in to add a comment