New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 702052 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 706993
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Yahoo! Sports crash in "Account key" menu item

Project Member Reported by sgu...@chromium.org, Mar 16 2017

Issue description

- Package name: com.yahoo.mobile.client.android.sportacular
- Android build (Home > Settings > About phone > Build number): marlin-OPR1.170308.002
- Carrier: verizon

=====STEPS TO REPRODUCE=====
[Be as specific as possible; rather than "browse around a few web pages", say "go to this URL, then click on this specific link".]
1. hamburger menu
2. account key
(may need to be signed in)

EXPECTED RESULTS:
unknown, don't what that is supposed to take me to

OBSERVED RESULTS:
crash, see log below

NUMBER OF TIMES YOU WERE ABLE TO REPRODUCE (e.g. 3/10): 3/3

DEVICES TESTED:
marlin

03-10 17:30:41.096 15305 15305 E AndroidRuntime: FATAL EXCEPTION: main
03-10 17:30:41.096 15305 15305 E AndroidRuntime: Process: , PID: 15305
03-10 17:30:41.096 15305 15305 E AndroidRuntime: java.lang.IllegalStateException: Cannot execute task: the task has already been executed (a task can be executed only once)
03-10 17:30:41.096 15305 15305 E AndroidRuntime:        at android.os.AsyncTask.executeOnExecutor(AsyncTask.java:612)
03-10 17:30:41.096 15305 15305 E AndroidRuntime:        at android.os.AsyncTask.execute(AsyncTask.java:567)
03-10 17:30:41.096 15305 15305 E AndroidRuntime:        at com.yahoo.mobile.client.share.activity.BaseWebViewActivity$AccountWebViewClient.shouldOverrideUrlLoading(Yahoo:1019)
03-10 17:30:41.096 15305 15305 E AndroidRuntime:        at android.webkit.WebViewClient.shouldOverrideUrlLoading(WebViewClient.java:73)
03-10 17:30:41.096 15305 15305 E AndroidRuntime:        at com.android.webview.chromium.WebViewContentsClientAdapter.shouldOverrideUrlLoading(WebViewContentsClientAdapter.java:354)
03-10 17:30:41.096 15305 15305 E AndroidRuntime:        at org.chromium.android_webview.AwContentsClient.shouldIgnoreNavigation(AwContentsClient.java:168)
03-10 17:30:41.096 15305 15305 E AndroidRuntime:        at org.chromium.android_webview.AwContentsClientBridge.shouldOverrideUrlLoading(AwContentsClientBridge.java:352)
03-10 17:30:41.096 15305 15305 E AndroidRuntime:        at org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method)
03-10 17:30:41.096 15305 15305 E AndroidRuntime:        at org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:41)
03-10 17:30:41.096 15305 15305 E AndroidRuntime:        at android.os.Handler.dispatchMessage(Handler.java:102)
03-10 17:30:41.096 15305 15305 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:156)
03-10 17:30:41.096 15305 15305 E AndroidRuntime:        at android.app.ActivityThread.main(ActivityThread.java:6408)
03-10 17:30:41.096 15305 15305 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
03-10 17:30:41.096 15305 15305 E AndroidRuntime:        at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:232)
03-10 17:30:41.096 15305 15305 E AndroidRuntime:        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:751)
=====HELPFUL DETAILS=====
 

Comment 1 by sgu...@chromium.org, Mar 16 2017

Components: Mobile>WebView
hat unfortunately seems to be a WebView bug or at least a bug that exposes itself because of a behavior change in WebView in M58

https://chromium.googlesource.com/chromium/src/+log/58.0.2994.0..58.0.2995.0?pretty=fuller&n=10000

is the range of CLs that are responsible. The bug is not O specific.
We will track the bug in chromium bug tracker.

The bug is likely due to a behavior change in shouldoverrideurlloading path, which may impact a large number of apps depending on what it is. I did not see anything very obvious in the list yet. but it is a bummer.

Comment 2 by sgu...@chromium.org, Mar 16 2017

Cc: gsennton@chromium.org tobiasjs@chromium.org

Comment 3 by sgu...@chromium.org, Mar 16 2017

can someone from london investigate tomorrow.
Friendly ping here...  who will finalize investigation?

Comment 5 by sgu...@chromium.org, Mar 17 2017

I will look, it seems :)

Comment 6 by sgu...@chromium.org, Mar 21 2017

Cc: -tobiasjs@chromium.org -gsennton@chromium.org jww@chromium.org
This is broken by  https://codereview.chromium.org/2633663003, strict secure cookies.


Comment 7 by sgu...@chromium.org, Mar 22 2017

Cc: mkwst@chromium.org

Comment 8 by sgu...@chromium.org, Mar 22 2017

Mike/Joel: I guess the action is connecting Yahoo in this case. Do we expect such breakages to be rare?

Alex: FYI, for M58 potential WebView breakages. 

Comment 9 by mkwst@chromium.org, Mar 22 2017

Cc: -jww@chromium.org torne@chromium.org
Components: Internals>Network>Cookies
Labels: OS-Android
Joel has left the company, so he's unlikely to take a look at this. :)

The patch mentioned in comment 7 implements behavior we want, so I'd like to make sure we keep it in in some form. That said, it's not at all clear to me how it affects the codepath we're discussing here. Could you help me understand the error? If we can implement the change in a way less likely to break WebView apps, we certainly will.
I think in this particular case, it is Yahoo to blame. after adding some logs I see that Yahoo is using WebView's setCookie API to set a secure cookie for url "yahoo.com"

SSL=v=1&s=W1oCYMzCdd20UIGyyWjQdE...(some other stuff)...&kv=0; path=/; domain=.yahoo.com; secure; httponly

With the strict secure cookies, this will not be set anymore. There is probably some other part of the code that relies on this cookie, and not work.

I will close the bug as won't fix, and will ping Yahoo about it.
Status: WontFix (was: Assigned)
Mergedinto: 706993
Status: Duplicate (was: WontFix)

Sign in to add a comment