New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 702051 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
█ dsansome@chromium.org
thakis@chromium.org
j...@chromium.org
flyboy@chromium.org
rauch+monorail-auto@google.com
█ orodley+autocc@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Git



Sign in to add a comment

Link to clang_format script folder in docs is broken.

Project Member Reported by lgar...@chromium.org, Mar 16 2017 

What steps will reproduce the problem?
(1) Visit https://chromium.googlesource.com/chromium/src/+/master/docs/clang_format.md
(2) Under "Editor integrations", click `src/buildtools/clang_format/script/`

What is the expected result?
A valid link.

What happens instead?
`Could not load src/buildtools/clang_format/script/: Could not resolve path src/buildtools/clang_format/script.`

Comment 1 by bpastene@chromium.org, Mar 22 2017

Cc: thakis@chromium.org
Components: -Infra Infra>Codesearch
That script directory is DEPS'ed into buildtools (https://chromium.googlesource.com/chromium/buildtools.git/+/master/DEPS#12) and then buildtools is DEPS'ed into chromium/src (https://chromium.googlesource.com/chromium/src/+/master/DEPS#129) and whitelisted for recursedeps (https://chromium.googlesource.com/chromium/src/+/master/DEPS#1149)

I'm not sure if our codesearch pipeline supports recursedeps.

Comment 2 by thakis@chromium.org, Mar 22 2017 

I guess we could make it not a link, and possibly have a separate link point to https://chromium.googlesource.com/chromium/llvm-project/cfe/tools/clang-format/+/master or so. lgarron, want to give this a stab?

Comment 3 by emso@chromium.org, Mar 23 2017

Cc: dsansome@chromium.org
Status: Available (was: Untriaged)
Code search doesn't currently support nested DEPS. dsansome probably knows what adding support would entail (CC:ing).

Comment 4 by emso@chromium.org, May 17 2017

Labels: Git Deps
Owner: dsansome@chromium.org
Status: Assigned (was: Available)

Comment 5 by dsansome@chromium.org, Jul 6 2017

Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 6 by sheriffbot@chromium.org, Jul 6

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by j...@chromium.org, Jul 9

Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
►

Sign in to add a comment