New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Merge Request for WebRTC DesktopCapture component

Project Member Reported by zijiehe@chromium.org, Mar 16 2017 
Change https://codereview.chromium.org/2755493003/ needs to be merged to M58.

A field has not been correctly initialized in DxgiOutputDuplicator, which is a component of DesktopCapture in WebRTC.

This change has been verified by test cases running in win_x64_win8 / win_x64_win10 trybots, and manually tested on my machine.

Comment 1 Deleted

Comment 2 Deleted

Comment 3 Deleted

Comment 4 by candr...@chromium.org, Mar 16 2017 

Please add applicable OSs.  Thanks.

Comment 5 by sergeyu@chromium.org, Mar 16 2017

Labels: OS-Windows
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 17 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Mar 20 2017 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by ligim...@chromium.org, Mar 20 2017 

Your change is approved for M58. Please merge ASAP so that it will be picked up for next Beta Release, RC cut on (Tuesday-03/21) at 4.00 PM PST.
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 21 2017

Labels: merge-merged-58
The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/d339f300ce5e5848c66c41de6206dd8f0a448aa3

commit d339f300ce5e5848c66c41de6206dd8f0a448aa3
Author: Sergey Ulanov <sergeyu@chromium.org>
Date: Tue Mar 21 21:54:39 2017

DxgiOutputDuplicator should initialize num_frames_captured_

Otherwise Check failed: !!last_frame_ == num_frames_captured_ > 0 (1 vs. 0) may
be triggered.

BUG= webrtc:7339 ,  chromium:702044 

Review-Url: https://codereview.webrtc.org/2755493003
Cr-Commit-Position: refs/heads/master@{#17266}
(cherry picked from commit 299b67809adb928d446440367ec16da865f64166)

Review-Url: https://codereview.webrtc.org/2767773002 .
Cr-Commit-Position: refs/branch-heads/58@{#6}
Cr-Branched-From: f31969a584bcafe9406c214a9d4c3afb49d19650-refs/heads/master@{#16937}

[modify] https://crrev.com/d339f300ce5e5848c66c41de6206dd8f0a448aa3/webrtc/modules/desktop_capture/win/dxgi_output_duplicator.h

Comment 10 by sergeyu@chromium.org, Mar 21 2017

Status: Fixed (was: Assigned)
Project Member

Comment 11 by sheriffbot@chromium.org, Mar 24 2017

Cc: hirono@chromium.org gkihumba@chromium.org kkhorimoto@chromium.org gkihumba@google.com ligim...@chromium.org moch@chromium.org ketakid@google.com keta...@chromium.org gov...@chromium.org bhthompson@google.com dimu@chromium.org tin...@google.com dimu@google.com maxkirsch@chromium.org jbau...@chromium.org yueherngl@chromium.org cma...@chromium.org krishna...@chromium.org bhthompson@chromium.org kinuko@chromium.org tienchang@chromium.org awhalley@chromium.org ntang@google.com marcheu@google.com reve...@chromium.org hablich@chromium.org vsu...@chromium.org carusom@chromium.org sshru...@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by moch@chromium.org, Mar 24 2017

Cc: -moch@chromium.org

Comment 13 by ligim...@chromium.org, Mar 27 2017 

If there is no pending work , please remove Merge-Approved-58 label.

Comment 14 by zijiehe@chromium.org, Mar 27 2017

Labels: -Merge-Approved-58
Removed.
►

Sign in to add a comment